Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/798931/?format=api
{ "id": 798931, "url": "http://patchwork.ozlabs.org/api/patches/798931/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170807142839.60975-12-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170807142839.60975-12-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-08-07T14:28:38", "name": "[next,S78-V6,11/12] i40e: fix client notify of VF reset", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "b1691fc43919c90e1d2b33db7de72f07dc47edd3", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170807142839.60975-12-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/798931/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/798931/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xRC3c15DKz9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 8 Aug 2017 08:33:16 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 97373863E0;\n\tMon, 7 Aug 2017 22:33:14 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PWu9Ks386i7T; Mon, 7 Aug 2017 22:33:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 81338863D9;\n\tMon, 7 Aug 2017 22:33:13 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id EB8B71C415B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Aug 2017 22:33:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E5AB52FBB1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Aug 2017 22:33:10 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JF7NUL-QQ2OU for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Aug 2017 22:33:10 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 9DF652F970\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Aug 2017 22:33:09 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Aug 2017 15:33:09 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga003.jf.intel.com with ESMTP; 07 Aug 2017 15:33:07 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.41,339,1498546800\"; d=\"scan'208\";\n\ta=\"1001084750\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Mon, 7 Aug 2017 10:28:38 -0400", "Message-Id": "<20170807142839.60975-12-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170807142839.60975-1-alice.michael@intel.com>", "References": "<20170807142839.60975-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S78-V6 11/12] i40e: fix client notify\n\tof VF reset", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alan Brady <alan.brady@intel.com>\n\nCurrently there is a bug in which the PF driver fails to inform clients\nof a VF reset which then causes clients to leak resources. The bug\nexists because we were incorrectly checking the I40E_VF_STATE_PRE_ENABLE\nbit.\n\nWhen a VF is first init we go through a reset to initialize variables\nand allocate resources but we don't want to inform clients of this first\nreset since the client isn't fully enabled yet so we set a state bit\nsignifying we're in a \"pre-enabled\" client state. During the first\nreset we should be clearing the bit, allowing all following resets to\nnotify the client of the reset when the bit is not set. This patch\nfixes the issue by negating the 'test_and_clear_bit' check to accurately\nreflect the behavior we want.\n\nSigned-off-by: Alan Brady <alan.brady@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 4db7b05..42490b4 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1047,8 +1047,8 @@ static void i40e_cleanup_reset_vf(struct i40e_vf *vf)\n \t\tset_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states);\n \t\tclear_bit(I40E_VF_STATE_DISABLED, &vf->vf_states);\n \t\t/* Do not notify the client during VF init */\n-\t\tif (test_and_clear_bit(I40E_VF_STATE_PRE_ENABLE,\n-\t\t\t\t &vf->vf_states))\n+\t\tif (!test_and_clear_bit(I40E_VF_STATE_PRE_ENABLE,\n+\t\t\t\t\t&vf->vf_states))\n \t\t\ti40e_notify_client_of_vf_reset(pf, abs_vf_id);\n \t\tvf->num_vlan = 0;\n \t}\n", "prefixes": [ "next", "S78-V6", "11/12" ] }