Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/798506/?format=api
{ "id": 798506, "url": "http://patchwork.ozlabs.org/api/patches/798506/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170807080257.13708-1-npiggin@gmail.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170807080257.13708-1-npiggin@gmail.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170807080257.13708-1-npiggin@gmail.com/", "date": "2017-08-07T08:02:57", "name": "powerpc/64e: Fix perf hardlockup detector build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "505a1a5a48b2338aea2ba70810a2cb5e15eaf44a", "submitter": { "id": 69518, "url": "http://patchwork.ozlabs.org/api/people/69518/?format=api", "name": "Nicholas Piggin", "email": "npiggin@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170807080257.13708-1-npiggin@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/798506/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/798506/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xQqnV5W2cz9sNc\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 7 Aug 2017 18:04:46 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xQqnV4MRgzDqnm\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 7 Aug 2017 18:04:46 +1000 (AEST)", "from mail-pf0-x243.google.com (mail-pf0-x243.google.com\n\t[IPv6:2607:f8b0:400e:c00::243])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xQqlm2c9czDqkF\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tMon, 7 Aug 2017 18:03:15 +1000 (AEST)", "by mail-pf0-x243.google.com with SMTP id c65so8329568pfl.0\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tMon, 07 Aug 2017 01:03:15 -0700 (PDT)", "from roar.au.ibm.com (203-219-56-202.tpgi.com.au. [203.219.56.202])\n\tby smtp.gmail.com with ESMTPSA id\n\tb9sm14415592pfl.13.2017.08.07.01.03.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 07 Aug 2017 01:03:12 -0700 (PDT)" ], "Authentication-Results": [ "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KHRCzLch\"; dkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KHRCzLch\"; dkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KHRCzLch\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=oZKogYBV2Wkp3WoYqQtZGSnFhe0PJcK2x4YZOU2YtCc=;\n\tb=KHRCzLchy6u+oj3jghiLBVlWGw44vusrIkzuj0DdPXdyzRVLNS5e2jiSYc94kvpwmh\n\teL2So+AYw9lN7XqAjlmiLPkV8+kOx0V3Q7E3vx+06W4nAhipYAYJvoKRH6brSjB6OYdD\n\t7GX9/XMfj4jfKz7TSp1hnLnQ3KkJNcbmUAms1EyYaFjAlhWFVzQJUzk5VCOcR8H+F44j\n\tiRRs5+2BCPa1phFr3Vi4/Wk+e5SXmpaobTnwDEILTXJbnwlqfHB8HFi33cV+v0miZXxw\n\tcZwXK9UFhzrQxR8dMrpVsEj9bfVyy6SGKM6ICZGEyybJih61ITFSnqe6qHEHKNygoEqy\n\tw9Tg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=oZKogYBV2Wkp3WoYqQtZGSnFhe0PJcK2x4YZOU2YtCc=;\n\tb=J3yl/4EqYGxMIYML4sU1gxAheHI3i/ROg8LhRQMQPawPCdAK48C1uT2/hg8LftFJxn\n\tPZoG4u8E24E3zHCd8t9nAyjd6nmlEqpbxD/SUin5YCfemJgIXsN4e2vjOBO38nh70Ju5\n\t8H6qwAueC6cQnMpXySedh6S1i+FXTYRBG2dwB/6E3Gdc49KKZMjsGwO8yEYll+tGeONF\n\t07PmbouzDBTelPmwzWj6V5u2tkoDAndZ/XD94Db/4m88oHztemFLY436YsbLm7xP1Mro\n\thIlXcnSE3jPEQ2puw04REpx/EAn2MyKUC1rSqsBXeiqFYrIkVHudxTNff3snG0Fb+D5+\n\t3ZIg==", "X-Gm-Message-State": "AIVw112hb8qHOnPoR545ekmpN6g7CMQg8ldfswFW+EpKU3uqXEIBOlAI\n\tleSf0uSr2yDu2PQd", "X-Received": "by 10.99.45.194 with SMTP id t185mr10567200pgt.388.1502092993287;\n\tMon, 07 Aug 2017 01:03:13 -0700 (PDT)", "From": "Nicholas Piggin <npiggin@gmail.com>", "To": "linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH] powerpc/64e: Fix perf hardlockup detector build", "Date": "Mon, 7 Aug 2017 18:02:57 +1000", "Message-Id": "<20170807080257.13708-1-npiggin@gmail.com>", "X-Mailer": "git-send-email 2.13.3", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Nicholas Piggin <npiggin@gmail.com>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "This fixes a couple more bits of fallout when enabling the hardlockup\ndetector for 64e.\n\nIt restores the required hw_nmi_get_sample_period() function for the\nperf watchdog, and restores disabling of the watchdog there. It also\nremoves API definitions that are only defined for 64s.\n\nFixes: 2104180a53 (\"powerpc/64s: implement arch-specific hardlockup watchdog\")\nSigned-off-by: Nicholas Piggin <npiggin@gmail.com>\n---\n\nThis patch should go on top of the previous:\n\nhttp://patchwork.ozlabs.org/patch/796202/\n\n arch/powerpc/include/asm/nmi.h | 3 +--\n arch/powerpc/kernel/setup_64.c | 21 +++++++++++++++++++++\n 2 files changed, 22 insertions(+), 2 deletions(-)", "diff": "diff --git a/arch/powerpc/include/asm/nmi.h b/arch/powerpc/include/asm/nmi.h\nindex 6f8e79cd35d8..3760150a0ff0 100644\n--- a/arch/powerpc/include/asm/nmi.h\n+++ b/arch/powerpc/include/asm/nmi.h\n@@ -1,9 +1,8 @@\n #ifndef _ASM_NMI_H\n #define _ASM_NMI_H\n \n-#ifdef CONFIG_HARDLOCKUP_DETECTOR\n+#ifdef CONFIG_PPC_WATCHDOG\n extern void arch_touch_nmi_watchdog(void);\n-\n extern void arch_trigger_cpumask_backtrace(const cpumask_t *mask,\n \t\t\t\t\t bool exclude_self);\n #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace\ndiff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c\nindex af23d4b576ec..5db2ddd8c31d 100644\n--- a/arch/powerpc/kernel/setup_64.c\n+++ b/arch/powerpc/kernel/setup_64.c\n@@ -751,3 +751,24 @@ unsigned long memory_block_size_bytes(void)\n struct ppc_pci_io ppc_pci_io;\n EXPORT_SYMBOL(ppc_pci_io);\n #endif\n+\n+#ifdef CONFIG_HARDLOCKUP_DETECTOR_PERF\n+u64 hw_nmi_get_sample_period(int watchdog_thresh)\n+{\n+\treturn ppc_proc_freq * watchdog_thresh;\n+}\n+\n+/*\n+ * The perf based hardlockup detector breaks PMU event based branches and is\n+ * likely to get false positives in KVM guests, so disable it by default.\n+ * Book3S has a soft-nmi version based on the decrementer interrupt so it does\n+ * not suffer from these problems.\n+ */\n+static int __init disable_hardlockup_detector(void)\n+{\n+\thardlockup_detector_disable();\n+\n+\treturn 0;\n+}\n+early_initcall(disable_hardlockup_detector);\n+#endif\n", "prefixes": [] }