Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/797021/?format=api
{ "id": 797021, "url": "http://patchwork.ozlabs.org/api/patches/797021/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/20170803070852.6746-1-cyril.bur@au1.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170803070852.6746-1-cyril.bur@au1.ibm.com>", "list_archive_url": null, "date": "2017-08-03T07:08:52", "name": "[v2] external/gard: Print an error if run on an FSP system", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4d7add73a6a5f56f7b7e958225537e805f5ea810", "submitter": { "id": 64738, "url": "http://patchwork.ozlabs.org/api/people/64738/?format=api", "name": "Cyril Bur", "email": "cyril.bur@au1.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/20170803070852.6746-1-cyril.bur@au1.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/797021/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/797021/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xNLml4fhXz9s7v\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 3 Aug 2017 17:10:31 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xNLmk2VjNzDrLg\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 3 Aug 2017 17:10:30 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xNLmf0Ng0zDrLV\n\tfor <skiboot@lists.ozlabs.org>; Thu, 3 Aug 2017 17:10:25 +1000 (AEST)", "from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv73791b3082853\n\tfor <skiboot@lists.ozlabs.org>; Thu, 3 Aug 2017 03:10:23 -0400", "from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2c3wyac0b8-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Thu, 03 Aug 2017 03:10:23 -0400", "from localhost\n\tby e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <cyril.bur@au1.ibm.com>;\n\tThu, 3 Aug 2017 17:10:21 +1000", "from d23relay08.au.ibm.com (202.81.31.227)\n\tby e23smtp06.au.ibm.com (202.81.31.212) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 3 Aug 2017 17:10:18 +1000", "from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])\n\tby d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv73793VE23986404\n\tfor <skiboot@lists.ozlabs.org>; Thu, 3 Aug 2017 17:09:03 +1000", "from d23av03.au.ibm.com (localhost [127.0.0.1])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7378rjV031605\n\tfor <skiboot@lists.ozlabs.org>; Thu, 3 Aug 2017 17:08:54 +1000", "from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7378rto031602; Thu, 3 Aug 2017 17:08:53 +1000", "from camb691.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby ozlabs.au.ibm.com (Postfix) with ESMTPSA id 966F6A0098;\n\tThu, 3 Aug 2017 17:09:02 +1000 (AEST)" ], "From": "Cyril Bur <cyril.bur@au1.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Thu, 3 Aug 2017 17:08:52 +1000", "X-Mailer": "git-send-email 2.13.3", "X-TM-AS-MML": "disable", "x-cbid": "17080307-0040-0000-0000-0000034C6840", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17080307-0041-0000-0000-00000CC90237", "Message-Id": "<20170803070852.6746-1-cyril.bur@au1.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-03_03:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000\n\tdefinitions=main-1708030109", "Subject": "[Skiboot] [PATCH v2] external/gard: Print an error if run on an FSP\n\tsystem", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com>\n---\n external/gard/gard.c | 15 ++++++++++++++-\n 1 file changed, 14 insertions(+), 1 deletion(-)", "diff": "diff --git a/external/gard/gard.c b/external/gard/gard.c\nindex 4b26a3b8..55e2a924 100644\n--- a/external/gard/gard.c\n+++ b/external/gard/gard.c\n@@ -43,7 +43,9 @@\n \n #define CLEARED_RECORD_ID 0xFFFFFFFF\n \n-#define FDT_ACTIVE_FLASH_PATH \"/proc/device-tree/chosen/ibm,system-flash\"\n+#define FDT_PATH \"/proc/device-tree\"\n+#define FDT_FSP_NODE FDT_PATH\"/fsps\"\n+#define FDT_ACTIVE_FLASH_PATH FDT_PATH\"/chosen/ibm,system-flash\"\n #define SYSFS_MTD_PATH \"/sys/class/mtd/\"\n #define FLASH_GARD_PART \"GUARD\"\n \n@@ -563,6 +565,11 @@ static void usage(const char *progname)\n \t}\n }\n \n+static bool is_fsp(void)\n+{\n+\treturn access(FDT_FSP_NODE, F_OK) == 0;\n+}\n+\n static struct option global_options[] = {\n \t{ \"file\", required_argument, 0, 'f' },\n \t{ \"part\", no_argument, 0, 'p' },\n@@ -586,6 +593,12 @@ int main(int argc, char **argv)\n \tctx = &_ctx;\n \tmemset(ctx, 0, sizeof(*ctx));\n \n+\tif (is_fsp()) {\n+\t\tfprintf(stderr, \"This is the OpenPower gard tool which does \"\n+\t\t\t\t\"not support FSP systems\\n\");\n+\t\treturn EXIT_FAILURE;\n+\t}\n+\n \t/* process global options */\n \tfor (;;) {\n \t\tint c;\n", "prefixes": [ "v2" ] }