Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/794516/?format=api
{ "id": 794516, "url": "http://patchwork.ozlabs.org/api/patches/794516/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1501150629-20305-1-git-send-email-lihong.yang@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1501150629-20305-1-git-send-email-lihong.yang@intel.com>", "list_archive_url": null, "date": "2017-07-27T10:17:09", "name": "i40e: remove logically dead code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1a5516272656f2f3f6daf43b70bcd5b524d4f1e7", "submitter": { "id": 72053, "url": "http://patchwork.ozlabs.org/api/people/72053/?format=api", "name": "Lihong Yang", "email": "lihong.yang@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1501150629-20305-1-git-send-email-lihong.yang@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/794516/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/794516/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xJHJd5nckz9s06\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 28 Jul 2017 02:20:32 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1A9BA8A53B;\n\tThu, 27 Jul 2017 16:20:31 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yOwlYkOrPSp8; Thu, 27 Jul 2017 16:20:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A92BC8A2E5;\n\tThu, 27 Jul 2017 16:20:30 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 420811C0C65\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Jul 2017 16:20:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3A0492E131\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Jul 2017 16:20:29 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 88aluxrqHN7D for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Jul 2017 16:20:28 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 8758E2E08C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Jul 2017 16:20:28 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga104.jf.intel.com with ESMTP; 27 Jul 2017 09:20:27 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.35.176])\n\tby fmsmga002.fm.intel.com with ESMTP; 27 Jul 2017 09:20:20 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.40,421,1496127600\"; d=\"scan'208\";\n\ta=\"1199948449\"", "From": "Lihong Yang <lihong.yang@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 27 Jul 2017 03:17:09 -0700", "Message-Id": "<1501150629-20305-1-git-send-email-lihong.yang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[Intel-wired-lan] [PATCH] i40e: remove logically dead code", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch removes the !vf condition check that cannot be\ntrue in i40e_ndo_set_vf_trust function\n\nDetected by CoverityScan, CID 1397531 Logically dead code\n\nSigned-off-by: Lihong Yang <lihong.yang@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex f78aa7e..a1d2391 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -3312,8 +3312,6 @@ int i40e_ndo_set_vf_trust(struct net_device *netdev, int vf_id, bool setting)\n \n \tvf = &pf->vf[vf_id];\n \n-\tif (!vf)\n-\t\treturn -EINVAL;\n \tif (setting == vf->trusted)\n \t\tgoto out;\n \n", "prefixes": [] }