Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/793666/?format=api
{ "id": 793666, "url": "http://patchwork.ozlabs.org/api/patches/793666/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170725214427.25768-4-robh@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170725214427.25768-4-robh@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170725214427.25768-4-robh@kernel.org/", "date": "2017-07-25T21:44:26", "name": "[3/4] powerpc: pseries: only store the device node basename in full_name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3adf38151568786aaff96d3c87ad853d15ef3123", "submitter": { "id": 62529, "url": "http://patchwork.ozlabs.org/api/people/62529/?format=api", "name": "Rob Herring", "email": "robh@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170725214427.25768-4-robh@kernel.org/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/793666/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/793666/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xHBkY5W6Mz9sN7\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 26 Jul 2017 07:50:45 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xHBkY4jpMzDqv8\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 26 Jul 2017 07:50:45 +1000 (AEST)", "from mail-yw0-f193.google.com (mail-yw0-f193.google.com\n\t[209.85.161.193])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xHBbY2mZTzDqn9\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 26 Jul 2017 07:44:41 +1000 (AEST)", "by mail-yw0-f193.google.com with SMTP id u207so3655648ywc.0\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tTue, 25 Jul 2017 14:44:41 -0700 (PDT)", "from localhost.localdomain (24-223-123-72.static.usa-companies.net.\n\t[24.223.123.72]) by smtp.googlemail.com with ESMTPSA id\n\t204sm2386383ywx.35.2017.07.25.14.44.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 25 Jul 2017 14:44:38 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=BqhfycaKF9SPab3bheBzng4f7afjpmRuZgcFkBpJ/Zg=;\n\tb=nnQITzwUKDpabyoRUkUlPzO6owp3zmmka1fe2FNCPH3xwiVYpsQGpRYzxIJFGAddxx\n\t4oqdWTAsk6hDVWV5Vd7FMMr0VhLbmmEdiKsSBuAIDErxPmzt1X0s6eFgclIlQSwlID7A\n\tkvlO3pKREUkEohEXYMzitgqTERen0a0142QDK7PYA2FPWRcCdgaWkYZDYP7eFjESDfGl\n\tcaKPeIAmpl+Xqjj6MbuyedukIX5m8Lz/MlIG3mCnLUmz21nT4F3KosdUJtl9AW5xsIbO\n\tG5gAaIb3u2Jm4mSXBgUKeAlg9dlJP376AN7wEcItzS69tZBZqxTlafrNDj83FqBelSHM\n\tzvTQ==", "X-Gm-Message-State": "AIVw112KNMacAdzspLZ3AW4rS+MhTHwcBVI4ndHjZnfA3lPOa781hwpx\n\tXGqlefWuF5tKYA==", "X-Received": "by 10.129.78.137 with SMTP id\n\tc131mr17304362ywb.464.1501019079433; \n\tTue, 25 Jul 2017 14:44:39 -0700 (PDT)", "From": "Rob Herring <robh@kernel.org>", "To": "devicetree@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH 3/4] powerpc: pseries: only store the device node basename in\n\tfull_name", "Date": "Tue, 25 Jul 2017 16:44:26 -0500", "Message-Id": "<20170725214427.25768-4-robh@kernel.org>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170725214427.25768-1-robh@kernel.org>", "References": "<20170725214427.25768-1-robh@kernel.org>", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Frank Rowand <frowand.list@gmail.com>, linux-kernel@vger.kernel.org,\n\tPaul Mackerras <paulus@samba.org>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "With dependencies on full_name containing the entire device node path\nremoved, stop storing the full_name in nodes created by\ndlpar_configure_connector() and pSeries_reconfig_add_node().\n\nSigned-off-by: Rob Herring <robh@kernel.org>\nCc: Benjamin Herrenschmidt <benh@kernel.crashing.org>\nCc: Paul Mackerras <paulus@samba.org>\nCc: Michael Ellerman <mpe@ellerman.id.au>\nCc: linuxppc-dev@lists.ozlabs.org\n---\n arch/powerpc/platforms/pseries/dlpar.c | 20 ++++----------------\n arch/powerpc/platforms/pseries/reconfig.c | 2 +-\n 2 files changed, 5 insertions(+), 17 deletions(-)", "diff": "diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c\nindex 783f36364690..8ab0be0706fd 100644\n--- a/arch/powerpc/platforms/pseries/dlpar.c\n+++ b/arch/powerpc/platforms/pseries/dlpar.c\n@@ -75,24 +75,17 @@ static struct property *dlpar_parse_cc_property(struct cc_workarea *ccwa)\n \treturn prop;\n }\n \n-static struct device_node *dlpar_parse_cc_node(struct cc_workarea *ccwa,\n-\t\t\t\t\t const char *path)\n+static struct device_node *dlpar_parse_cc_node(struct cc_workarea *ccwa)\n {\n \tstruct device_node *dn;\n \tchar *name;\n \n-\t/* If parent node path is \"/\" advance path to NULL terminator to\n-\t * prevent double leading slashs in full_name.\n-\t */\n-\tif (!path[1])\n-\t\tpath++;\n-\n \tdn = kzalloc(sizeof(*dn), GFP_KERNEL);\n \tif (!dn)\n \t\treturn NULL;\n \n \tname = (char *)ccwa + be32_to_cpu(ccwa->name_offset);\n-\tdn->full_name = kasprintf(GFP_KERNEL, \"%s/%s\", path, name);\n+\tdn->full_name = kasprintf(GFP_KERNEL, \"%s\", name);\n \tif (!dn->full_name) {\n \t\tkfree(dn);\n \t\treturn NULL;\n@@ -148,7 +141,6 @@ struct device_node *dlpar_configure_connector(__be32 drc_index,\n \tstruct property *last_property = NULL;\n \tstruct cc_workarea *ccwa;\n \tchar *data_buf;\n-\tconst char *parent_path = parent->full_name;\n \tint cc_token;\n \tint rc = -1;\n \n@@ -182,7 +174,7 @@ struct device_node *dlpar_configure_connector(__be32 drc_index,\n \t\t\tbreak;\n \n \t\tcase NEXT_SIBLING:\n-\t\t\tdn = dlpar_parse_cc_node(ccwa, parent_path);\n+\t\t\tdn = dlpar_parse_cc_node(ccwa);\n \t\t\tif (!dn)\n \t\t\t\tgoto cc_error;\n \n@@ -192,10 +184,7 @@ struct device_node *dlpar_configure_connector(__be32 drc_index,\n \t\t\tbreak;\n \n \t\tcase NEXT_CHILD:\n-\t\t\tif (first_dn)\n-\t\t\t\tparent_path = last_dn->full_name;\n-\n-\t\t\tdn = dlpar_parse_cc_node(ccwa, parent_path);\n+\t\t\tdn = dlpar_parse_cc_node(ccwa);\n \t\t\tif (!dn)\n \t\t\t\tgoto cc_error;\n \n@@ -226,7 +215,6 @@ struct device_node *dlpar_configure_connector(__be32 drc_index,\n \n \t\tcase PREV_PARENT:\n \t\t\tlast_dn = last_dn->parent;\n-\t\t\tparent_path = last_dn->parent->full_name;\n \t\t\tbreak;\n \n \t\tcase CALL_AGAIN:\ndiff --git a/arch/powerpc/platforms/pseries/reconfig.c b/arch/powerpc/platforms/pseries/reconfig.c\nindex e5bf1e84047f..73e4063ad997 100644\n--- a/arch/powerpc/platforms/pseries/reconfig.c\n+++ b/arch/powerpc/platforms/pseries/reconfig.c\n@@ -33,7 +33,7 @@ static int pSeries_reconfig_add_node(const char *path, struct property *proplist\n \tif (!np)\n \t\tgoto out_err;\n \n-\tnp->full_name = kstrdup(path, GFP_KERNEL);\n+\tnp->full_name = kstrdup(kbasename(path), GFP_KERNEL);\n \tif (!np->full_name)\n \t\tgoto out_err;\n \n", "prefixes": [ "3/4" ] }