Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/793147/?format=api
{ "id": 793147, "url": "http://patchwork.ozlabs.org/api/patches/793147/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1500945462-33176-1-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1500945462-33176-1-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2017-07-25T01:17:42", "name": "[net-next] i40e: limit lan queue count in large cpu count machine", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f7125801de54d5a06ca39cfcc392f6bde2c06478", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1500945462-33176-1-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/793147/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/793147/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xGgK01KT7z9s78\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 25 Jul 2017 11:15:14 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5DCBA85C8E;\n\tTue, 25 Jul 2017 01:15:12 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UHXL9d6QrFwq; Tue, 25 Jul 2017 01:15:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id ABE0786511;\n\tTue, 25 Jul 2017 01:15:11 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 06EEC1C3EBA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Jul 2017 01:15:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E6A1586511\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Jul 2017 01:15:10 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CKQlPAkGvsFl for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Jul 2017 01:15:10 +0000 (UTC)", "from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 47F3985C8E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Jul 2017 01:15:10 +0000 (UTC)", "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v6P1F7HS031184\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 25 Jul 2017 01:15:08 GMT", "from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv6P1F6a9011224\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 25 Jul 2017 01:15:06 GMT", "from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13])\n\tby aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv6P1F6t8019450; Tue, 25 Jul 2017 01:15:06 GMT", "from sln75.us.oracle.com (/10.147.27.211)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Mon, 24 Jul 2017 18:15:06 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "davem@davemloft.net, netdev@vger.kernel.org", "Date": "Mon, 24 Jul 2017 18:17:42 -0700", "Message-Id": "<1500945462-33176-1-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 1.7.1", "X-Source-IP": "userv0022.oracle.com [156.151.31.74]", "Cc": "intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH net-next] i40e: limit lan queue count in\n\tlarge cpu count machine", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When a machine has more cpus than queuepairs, e.g. 512 cores, the\ncounting gets a little funky and turns off Flow Director with the\nmessage:\n not enough queues for Flow Director. Flow Director feature is disabled\n\nThis patch limits the number of lan queues initially allocated to\nbe sure we have some left for FD and other features.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 11 +++++++----\n 1 files changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 2db93d3..a694e99 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -11059,6 +11059,7 @@ static int i40e_setup_pf_switch(struct i40e_pf *pf, bool reinit)\n static void i40e_determine_queue_usage(struct i40e_pf *pf)\n {\n \tint queues_left;\n+\tint q_max;\n \n \tpf->num_lan_qps = 0;\n \n@@ -11105,10 +11106,12 @@ static void i40e_determine_queue_usage(struct i40e_pf *pf)\n \t\t\t\t\tI40E_FLAG_DCB_ENABLED);\n \t\t\tdev_info(&pf->pdev->dev, \"not enough queues for DCB. DCB is disabled.\\n\");\n \t\t}\n-\t\tpf->num_lan_qps = max_t(int, pf->rss_size_max,\n-\t\t\t\t\tnum_online_cpus());\n-\t\tpf->num_lan_qps = min_t(int, pf->num_lan_qps,\n-\t\t\t\t\tpf->hw.func_caps.num_tx_qp);\n+\n+\t\t/* limit lan qps to the smaller of qps, cpus or msix */\n+\t\tq_max = max_t(int, pf->rss_size_max, num_online_cpus());\n+\t\tq_max = min_t(int, q_max, pf->hw.func_caps.num_tx_qp);\n+\t\tq_max = min_t(int, q_max, pf->hw.func_caps.num_msix_vectors);\n+\t\tpf->num_lan_qps = q_max;\n \n \t\tqueues_left -= pf->num_lan_qps;\n \t}\n", "prefixes": [ "net-next" ] }