Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/790947/?format=api
{ "id": 790947, "url": "http://patchwork.ozlabs.org/api/patches/790947/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/1500458848-22634-1-git-send-email-majopela@redhat.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1500458848-22634-1-git-send-email-majopela@redhat.com>", "list_archive_url": null, "date": "2017-07-19T10:07:28", "name": "[ovs-dev,v1,1/1] ovn: l3ha fix unexpected ARP requests on pcap during tests", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "a3b95fa15573c77bda19528813c032f808fec349", "submitter": { "id": 67170, "url": "http://patchwork.ozlabs.org/api/people/67170/?format=api", "name": "Miguel Angel Ajo", "email": "majopela@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/1500458848-22634-1-git-send-email-majopela@redhat.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/790947/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/790947/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xCCQ86fr0z9s06\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 19 Jul 2017 20:07:44 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 477DAABA;\n\tWed, 19 Jul 2017 10:07:41 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 8E0D6727\n\tfor <dev@openvswitch.org>; Wed, 19 Jul 2017 10:07:39 +0000 (UTC)", "from mail-wm0-f48.google.com (mail-wm0-f48.google.com\n\t[74.125.82.48])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id D48C2CD\n\tfor <dev@openvswitch.org>; Wed, 19 Jul 2017 10:07:38 +0000 (UTC)", "by mail-wm0-f48.google.com with SMTP id t70so4728979wmt.1\n\tfor <dev@openvswitch.org>; Wed, 19 Jul 2017 03:07:38 -0700 (PDT)", "from gw2.localdomain (111.148.134.37.dynamic.jazztel.es.\n\t[37.134.148.111]) by smtp.gmail.com with ESMTPSA id\n\to16sm3029183wro.56.2017.07.19.03.07.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 19 Jul 2017 03:07:35 -0700 (PDT)" ], "X-Greylist": "whitelisted by SQLgrey-1.7.6", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=KJz9AzR3Z4Nc1SNcqX1EmNxD8yUcYVbtt1T5f3u69S4=;\n\tb=M2upMOR1cKqKdBRDW6/QUfquIvY9AiBwkMPujIby5EYtx6oL2gIDs/Zc0sdK3ZcBCh\n\ttO7/NuGEDsjlD+3/r218tBCz5ATlOlLkCQWMQveZy7UtHxpheMEIApKpDtftC2rHmQyH\n\tcjZwoOGClwmLBNfCWjDxhyStEpP/YAFjLjiq+14vrJO6kM0RFwsycqsC5b0TfVNls+Cc\n\tWl6w6QNME8w/2Jajg2D09Gmeej+gFdcRPyMuP8Ck3q+6ctksa0WbR9tGwkpnFXvHdz1P\n\t9AusGuJsGlMC7cZX21CKwHuyHDNXsKMfvy3Qf2RcddYoyLNy6lW09aZhBinDWpqZpV/S\n\tvDJA==", "X-Gm-Message-State": "AIVw113RTRlezIuIefMt4EyNx3HvGXY6BCO7Ipv76Tz5xci7nJnxU6eC\n\tS4Od+QexGL49ZhBqCli/3Q==", "X-Received": "by 10.28.229.207 with SMTP id c198mr5250941wmh.108.1500458857074;\n\tWed, 19 Jul 2017 03:07:37 -0700 (PDT)", "From": "Miguel Angel Ajo <majopela@redhat.com>", "To": "dev@openvswitch.org", "Date": "Wed, 19 Jul 2017 10:07:28 +0000", "Message-Id": "<1500458848-22634-1-git-send-email-majopela@redhat.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-Spam-Status": "No, score=-1.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=no version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Cc": "Miguel Angel Ajo <majopela@redhat.com>", "Subject": "[ovs-dev] [PATCH v1 1/1] ovn: l3ha fix unexpected ARP requests on\n\tpcap during tests", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "For testing l3ha datapath we have an external port on a separate sim\ninstance (ext1), and we send an UDP packet that we expect to see\ngoing through the specific MASTER gateway (gw1 or gw2) and reaching\nthe final ext1-vif port on ext1.\n\novn_arp_populate macro din't know about the BRIDGE/IP/MAC of ext1-vif\nport, and didn't populate the tables, so in some cases an ARP\nrequest was sent from alice external distributed port to the external\nnetwork, which wasn't expected on the OVN_CHECK_PACKETS macro.\n\nThis patch adds a macro to let us register extra arp entries before\nrunning the tests, also makes sure that ovn-controller has synchronized\nand waits one more second to make sure that BFD sessions are fully\nestablished between gateways.\n\nSigned-off-by: Miguel Angel Ajo <majopela@redhat.com>\n---\n tests/ofproto-macros.at | 11 ++++++++++-\n tests/ovn.at | 17 ++++++++++++-----\n 2 files changed, 22 insertions(+), 6 deletions(-)", "diff": "diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at\nindex 23b0321..afba585 100644\n--- a/tests/ofproto-macros.at\n+++ b/tests/ofproto-macros.at\n@@ -235,6 +235,15 @@ net_attach () {\n || return 1\n }\n \n+# ovn_register_arp BRIDGE IP MAC\n+#\n+# Registers bridge/ip/mac triplet to the arp_table list which can be\n+# populated via the ovn_populate_arp function.\n+ovn_register_arp() {\n+ local sandbox=$1 bridge=$2 ip=$3 mac=$4\n+ arp_table=\"$arp_table $sandbox,$bridge,$ip,$mac\"\n+}\t\n+\n # ovn_attach NETWORK BRIDGE IP [MASKLEN]\n #\n # First, this command attaches BRIDGE to interconnection network NETWORK, just\n@@ -247,7 +256,7 @@ ovn_attach() {\n net_attach $net $bridge || return 1\n \n mac=`ovs-vsctl get Interface $bridge mac_in_use | sed s/\\\"//g`\n- arp_table=\"$arp_table $sandbox,$bridge,$ip,$mac\"\n+ ovn_register_arp $sandbox $bridge $ip $mac\n ovs-appctl netdev-dummy/ip4addr $bridge $ip/$masklen >/dev/null || return 1\n ovs-appctl ovs/route/add $ip/$masklen $bridge >/dev/null || return 1\n ovs-vsctl \\\ndiff --git a/tests/ovn.at b/tests/ovn.at\nindex 248aea4..22d3ab1 100644\n--- a/tests/ovn.at\n+++ b/tests/ovn.at\n@@ -6851,7 +6851,6 @@ ovs-vsctl -- add-port br-int ext1-vif1 -- \\\n # Pre-populate the hypervisors' ARP tables so that we don't lose any\n # packets for ARP resolution (native tunneling doesn't queue packets\n # for ARP resolution).\n-ovn_populate_arp\n \n ovn-nbctl create Logical_Router name=R1\n \n@@ -6907,11 +6906,19 @@ as gw1 ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys\n as gw2 ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys\n as ext1 ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys\n \n-AT_CHECK([ovn-nbctl --timeout=3 --wait=sb sync], [0], [ignore])\n+AT_CHECK([ovn-nbctl --timeout=3 --wait=hv sync], [0], [ignore])\n \n-# Allow some time for ovn-northd and ovn-controller to catch up.\n-# XXX This should be more systematic.\n-sleep 2\n+ovn_register_arp ext1 br-phys 172.16.1.3 f0:00:00:01:02:04\n+\n+ovn_populate_arp\n+\n+for x in hv1 gw1 gw2 ext1; do\n+ echo tnl/arp/show at ${x}:\n+ as $x ovs-appctl tnl/arp/show\n+done\n+\n+# allow BFD sessions to be established and up/steady\n+sleep 3\n \n ip_to_hex() {\n printf \"%02x%02x%02x%02x\" \"$@\"\n", "prefixes": [ "ovs-dev", "v1", "1/1" ] }