Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/790630/?format=api
{ "id": 790630, "url": "http://patchwork.ozlabs.org/api/patches/790630/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170718214339.7774-41-robh@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170718214339.7774-41-robh@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170718214339.7774-41-robh@kernel.org/", "date": "2017-07-18T21:43:21", "name": "PCI: Convert to using %pOF instead of full_name", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "2ddc157101ef6440c2a5e0cb9675ba6cbb298d5f", "submitter": { "id": 62529, "url": "http://patchwork.ozlabs.org/api/people/62529/?format=api", "name": "Rob Herring", "email": "robh@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170718214339.7774-41-robh@kernel.org/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/790630/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/790630/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xBvFt4s1gz9sRg\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 19 Jul 2017 07:59:30 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xBvFt3tc8zDrTZ\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 19 Jul 2017 07:59:30 +1000 (AEST)", "from mail-pg0-f67.google.com (mail-pg0-f67.google.com\n\t[74.125.83.67])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xBtx04nFlzDrLB\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 19 Jul 2017 07:44:52 +1000 (AEST)", "by mail-pg0-f67.google.com with SMTP id d193so4332856pgc.2\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tTue, 18 Jul 2017 14:44:52 -0700 (PDT)", "from localhost.localdomain (24-223-123-72.static.usa-companies.net.\n\t[24.223.123.72]) by smtp.googlemail.com with ESMTPSA id\n\tr207sm7186560pfr.106.2017.07.18.14.44.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 18 Jul 2017 14:44:50 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=FlGD/awA1JBCHc24nfSbJdKXz6jjSi6L+7b8kfSyiB0=;\n\tb=JOOZHeNyWo8twtlXTg4LcN7iewtqzOImm2uPk2Q5wepL/Hqp0ba+i+hAjC/O6ancF/\n\taO0PHw5hcggv/J97AzA5sPbDtJkoKMLlLypv3L8AKGFpz8b/YzGRfs6W/623EbH4K6n2\n\t5LAE0/vHFrLMuIx10nJYOkqcSncSTklUgsGhnapOzq+kqSf+258IKpYWgm0V7W0uHsO+\n\t0/WHDHCb5qcaCp0TFFgdYRKH7A+2oCyeRI0TDe9wE+RRrQI++nT2A24SAWdsCZfeCxu6\n\tj8h9d4tKfNNWf3Lk0oa8wPZK///TRYW9OTYOAXP+hVoygKle0lPWbenQ0FgD0tE4IFvn\n\tesNw==", "X-Gm-Message-State": "AIVw110/ctprJ1OR6yqxjkvHadvGfVreBa86CViBegcI7MezPHepgvR8\n\tV6D92A42jpeauQ==", "X-Received": "by 10.84.224.195 with SMTP id k3mr3885546pln.72.1500414290752;\n\tTue, 18 Jul 2017 14:44:50 -0700 (PDT)", "From": "Rob Herring <robh@kernel.org>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Subject": "[PATCH] PCI: Convert to using %pOF instead of full_name", "Date": "Tue, 18 Jul 2017 16:43:21 -0500", "Message-Id": "<20170718214339.7774-41-robh@kernel.org>", "X-Mailer": "git-send-email 2.11.0", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\tdevicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,\n\tlinux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tJonathan Hunter <jonathanh@nvidia.com>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tPaul Mackerras <paulus@samba.org>, \n\tlinux-tegra@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "Now that we have a custom printf format specifier, convert users of\nfull_name to use %pOF instead. This is preparation to remove storing\nof the full path string for each node.\n\nSigned-off-by: Rob Herring <robh@kernel.org>\nCc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>\nCc: Jason Cooper <jason@lakedaemon.net>\nCc: Bjorn Helgaas <bhelgaas@google.com>\nCc: Thierry Reding <thierry.reding@gmail.com>\nCc: Jonathan Hunter <jonathanh@nvidia.com>\nCc: Benjamin Herrenschmidt <benh@kernel.crashing.org>\nCc: Paul Mackerras <paulus@samba.org>\nCc: Michael Ellerman <mpe@ellerman.id.au>\nCc: linux-pci@vger.kernel.org\nCc: linux-arm-kernel@lists.infradead.org\nCc: linux-tegra@vger.kernel.org\nCc: linuxppc-dev@lists.ozlabs.org\n---\n drivers/pci/host/pci-mvebu.c | 8 ++++----\n drivers/pci/host/pci-tegra.c | 3 +--\n drivers/pci/hotplug/pnv_php.c | 4 ++--\n drivers/pci/hotplug/rpadlpar_core.c | 4 ++--\n drivers/pci/hotplug/rpaphp_core.c | 2 +-\n drivers/pci/hotplug/rpaphp_pci.c | 4 ++--\n drivers/pci/hotplug/rpaphp_slot.c | 4 ++--\n drivers/pci/pci-sysfs.c | 4 ++--\n drivers/pci/pci.c | 4 ++--\n 9 files changed, 18 insertions(+), 19 deletions(-)\n\n--\n2.11.0", "diff": "diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c\nindex f353a6eb2f01..424982997eb9 100644\n--- a/drivers/pci/host/pci-mvebu.c\n+++ b/drivers/pci/host/pci-mvebu.c\n@@ -1054,8 +1054,8 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie *pcie,\n \tport->pcie = pcie;\n\n \tif (of_property_read_u32(child, \"marvell,pcie-port\", &port->port)) {\n-\t\tdev_warn(dev, \"ignoring %s, missing pcie-port property\\n\",\n-\t\t\t of_node_full_name(child));\n+\t\tdev_warn(dev, \"ignoring %pOF, missing pcie-port property\\n\",\n+\t\t\t child);\n \t\tgoto skip;\n \t}\n\n@@ -1106,8 +1106,8 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie *pcie,\n \t\t}\n\n \t\tif (flags & OF_GPIO_ACTIVE_LOW) {\n-\t\t\tdev_info(dev, \"%s: reset gpio is active low\\n\",\n-\t\t\t\t of_node_full_name(child));\n+\t\t\tdev_info(dev, \"%pOF: reset gpio is active low\\n\",\n+\t\t\t\t child);\n \t\t\tgpio_flags = GPIOF_ACTIVE_LOW |\n \t\t\t\t GPIOF_OUT_INIT_LOW;\n \t\t} else {\ndiff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c\nindex b3722b7709df..7eb9be5ae357 100644\n--- a/drivers/pci/host/pci-tegra.c\n+++ b/drivers/pci/host/pci-tegra.c\n@@ -1703,8 +1703,7 @@ static int tegra_pcie_get_legacy_regulators(struct tegra_pcie *pcie)\n \t\tpcie->num_supplies = 2;\n\n \tif (pcie->num_supplies == 0) {\n-\t\tdev_err(dev, \"device %s not supported in legacy mode\\n\",\n-\t\t\tnp->full_name);\n+\t\tdev_err(dev, \"device %pOF not supported in legacy mode\\n\", np);\n \t\treturn -ENODEV;\n \t}\n\ndiff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c\nindex 7c203198b582..74f6a17e4614 100644\n--- a/drivers/pci/hotplug/pnv_php.c\n+++ b/drivers/pci/hotplug/pnv_php.c\n@@ -163,8 +163,8 @@ static void pnv_php_detach_device_nodes(struct device_node *parent)\n \t\tof_node_put(dn);\n \t\trefcount = kref_read(&dn->kobj.kref);\n \t\tif (refcount != 1)\n-\t\t\tpr_warn(\"Invalid refcount %d on <%s>\\n\",\n-\t\t\t\trefcount, of_node_full_name(dn));\n+\t\t\tpr_warn(\"Invalid refcount %d on <%pOF>\\n\",\n+\t\t\t\trefcount, dn);\n\n \t\tof_detach_node(dn);\n \t}\ndiff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c\nindex 3f93a4e79595..a3449d717a99 100644\n--- a/drivers/pci/hotplug/rpadlpar_core.c\n+++ b/drivers/pci/hotplug/rpadlpar_core.c\n@@ -150,8 +150,8 @@ static void dlpar_pci_add_bus(struct device_node *dn)\n \t/* Add EADS device to PHB bus, adding new entry to bus->devices */\n \tdev = of_create_pci_dev(dn, phb->bus, pdn->devfn);\n \tif (!dev) {\n-\t\tprintk(KERN_ERR \"%s: failed to create pci dev for %s\\n\",\n-\t\t\t\t__func__, dn->full_name);\n+\t\tprintk(KERN_ERR \"%s: failed to create pci dev for %pOF\\n\",\n+\t\t\t\t__func__, dn);\n \t\treturn;\n \t}\n\ndiff --git a/drivers/pci/hotplug/rpaphp_core.c b/drivers/pci/hotplug/rpaphp_core.c\nindex 8d132024f06e..1e29abaaea08 100644\n--- a/drivers/pci/hotplug/rpaphp_core.c\n+++ b/drivers/pci/hotplug/rpaphp_core.c\n@@ -318,7 +318,7 @@ int rpaphp_add_slot(struct device_node *dn)\n \tif (!is_php_dn(dn, &indexes, &names, &types, &power_domains))\n \t\treturn 0;\n\n-\tdbg(\"Entry %s: dn->full_name=%s\\n\", __func__, dn->full_name);\n+\tdbg(\"Entry %s: dn=%pOF\\n\", __func__, dn);\n\n \t/* register PCI devices */\n \tname = (char *) &names[1];\ndiff --git a/drivers/pci/hotplug/rpaphp_pci.c b/drivers/pci/hotplug/rpaphp_pci.c\nindex ea41ea1d3c00..32aabc533be8 100644\n--- a/drivers/pci/hotplug/rpaphp_pci.c\n+++ b/drivers/pci/hotplug/rpaphp_pci.c\n@@ -95,7 +95,7 @@ int rpaphp_enable_slot(struct slot *slot)\n\n \tbus = pci_find_bus_by_node(slot->dn);\n \tif (!bus) {\n-\t\terr(\"%s: no pci_bus for dn %s\\n\", __func__, slot->dn->full_name);\n+\t\terr(\"%s: no pci_bus for dn %pOF\\n\", __func__, slot->dn);\n \t\treturn -EINVAL;\n \t}\n\n@@ -125,7 +125,7 @@ int rpaphp_enable_slot(struct slot *slot)\n\n \t\tif (rpaphp_debug) {\n \t\t\tstruct pci_dev *dev;\n-\t\t\tdbg(\"%s: pci_devs of slot[%s]\\n\", __func__, slot->dn->full_name);\n+\t\t\tdbg(\"%s: pci_devs of slot[%pOF]\\n\", __func__, slot->dn);\n \t\t\tlist_for_each_entry(dev, &bus->devices, bus_list)\n \t\t\t\tdbg(\"\\t%s\\n\", pci_name(dev));\n \t\t}\ndiff --git a/drivers/pci/hotplug/rpaphp_slot.c b/drivers/pci/hotplug/rpaphp_slot.c\nindex 388c4d8fcdd1..489862360f2c 100644\n--- a/drivers/pci/hotplug/rpaphp_slot.c\n+++ b/drivers/pci/hotplug/rpaphp_slot.c\n@@ -122,8 +122,8 @@ int rpaphp_register_slot(struct slot *slot)\n \tint retval;\n \tint slotno = -1;\n\n-\tdbg(\"%s registering slot:path[%s] index[%x], name[%s] pdomain[%x] type[%d]\\n\",\n-\t\t__func__, slot->dn->full_name, slot->index, slot->name,\n+\tdbg(\"%s registering slot:path[%pOF] index[%x], name[%s] pdomain[%x] type[%d]\\n\",\n+\t\t__func__, slot->dn, slot->index, slot->name,\n \t\tslot->power_domain, slot->type);\n\n \t/* should not try to register the same slot twice */\ndiff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 2f3780b50723..33d4df7ed591 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -556,9 +556,9 @@ static ssize_t devspec_show(struct device *dev,\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n \tstruct device_node *np = pci_device_to_OF_node(pdev);\n\n-\tif (np == NULL || np->full_name == NULL)\n+\tif (np == NULL)\n \t\treturn 0;\n-\treturn sprintf(buf, \"%s\", np->full_name);\n+\treturn sprintf(buf, \"%pOF\", np);\n }\n static DEVICE_ATTR_RO(devspec);\n #endif\ndiff --git a/drivers/pci/pci.c b/drivers/pci/pci.c\nindex af0cc3456dc1..e8e40dea2842 100644\n--- a/drivers/pci/pci.c\n+++ b/drivers/pci/pci.c\n@@ -5363,8 +5363,8 @@ static int of_pci_bus_find_domain_nr(struct device *parent)\n \t\tuse_dt_domains = 0;\n \t\tdomain = pci_get_new_domain_nr();\n \t} else {\n-\t\tdev_err(parent, \"Node %s has inconsistent \\\"linux,pci-domain\\\" property in DT\\n\",\n-\t\t\tparent->of_node->full_name);\n+\t\tdev_err(parent, \"Node %pOF has inconsistent \\\"linux,pci-domain\\\" property in DT\\n\",\n+\t\t\tparent->of_node);\n \t\tdomain = -1;\n \t}\n\n", "prefixes": [] }