Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/790613/?format=api
{ "id": 790613, "url": "http://patchwork.ozlabs.org/api/patches/790613/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170718214339.7774-26-robh@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170718214339.7774-26-robh@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170718214339.7774-26-robh@kernel.org/", "date": "2017-07-18T21:43:06", "name": "i2c: Convert to using %pOF instead of full_name", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "1802926c914160deb6db3099e86988fb6f4bc3d8", "submitter": { "id": 62529, "url": "http://patchwork.ozlabs.org/api/people/62529/?format=api", "name": "Rob Herring", "email": "robh@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170718214339.7774-26-robh@kernel.org/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/790613/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/790613/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xBv7s0Kz1z9sNw\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 19 Jul 2017 07:54:17 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xBv7r61dYzDrMx\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 19 Jul 2017 07:54:16 +1000 (AEST)", "from mail-pg0-f65.google.com (mail-pg0-f65.google.com\n\t[74.125.83.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xBtwV4VmWzDrK3\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 19 Jul 2017 07:44:26 +1000 (AEST)", "by mail-pg0-f65.google.com with SMTP id v190so4353505pgv.1\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tTue, 18 Jul 2017 14:44:26 -0700 (PDT)", "from localhost.localdomain (24-223-123-72.static.usa-companies.net.\n\t[24.223.123.72]) by smtp.googlemail.com with ESMTPSA id\n\tr207sm7186560pfr.106.2017.07.18.14.44.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 18 Jul 2017 14:44:24 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=mejrZUUboX4Cv2X8kKc1qwAgH0/qYm96RLkpreOK+hM=;\n\tb=DQnZLry5g1l+rdXDfpKGXfywma4FknTHOGK7He64kiVSm9RUOnx6cKlW3sxFI+YYCw\n\tXP2TV2C3nzwAr2NvNZOCwYBnx9GPom9QjtEsHwF51jrugqPBtVY9wz91hVU0guksADEd\n\tjB7gKnKdHpfTa4rjJ5q675aPDz5jvBuwPgCLioAVPR+gxyyxlZV0kzcm7GuR6hICypdl\n\tutAAEQMR/RvwJ6gmEzQnZxEBaO9Sgc66k8/HAV/vEKpa0F64YSwt/y372HVjdag/k1rm\n\tQ5wrLEPSggbHK98TIl/RvluoxkyyTYeCM2R5ed2fYa/LPPwpYzAwI1pmA2xldhCwBq71\n\t0wyg==", "X-Gm-Message-State": "AIVw111wAA2GrF0nrlnh0eBoWkg0dVs8Mmb+o82w7bWQ6BNMeVh2TxwB\n\t2/0/tldseF9bjA==", "X-Received": "by 10.101.69.203 with SMTP id m11mr3721903pgr.105.1500414265002; \n\tTue, 18 Jul 2017 14:44:25 -0700 (PDT)", "From": "Rob Herring <robh@kernel.org>", "To": "Wolfram Sang <wsa@the-dreams.de>", "Subject": "[PATCH] i2c: Convert to using %pOF instead of full_name", "Date": "Tue, 18 Jul 2017 16:43:06 -0500", "Message-Id": "<20170718214339.7774-26-robh@kernel.org>", "X-Mailer": "git-send-email 2.11.0", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tChen-Yu Tsai <wens@csie.org>, Paul Mackerras <paulus@samba.org>,\n\tlinux-i2c@vger.kernel.org,\n\tMaxime Ripard <maxime.ripard@free-electrons.com>, \n\tlinuxppc-dev@lists.ozlabs.org, Peter Rosin <peda@axentia.se>,\n\tlinux-arm-kernel@lists.infradead.org,\n\tHaavard Skinnemoen <hskinnemoen@gmail.com>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "Now that we have a custom printf format specifier, convert users of\nfull_name to use %pOF instead. This is preparation to remove storing\nof the full path string for each node.\n\nSigned-off-by: Rob Herring <robh@kernel.org>\nCc: Haavard Skinnemoen <hskinnemoen@gmail.com>\nCc: Wolfram Sang <wsa@the-dreams.de>\nCc: Benjamin Herrenschmidt <benh@kernel.crashing.org>\nCc: Paul Mackerras <paulus@samba.org>\nCc: Michael Ellerman <mpe@ellerman.id.au>\nCc: Maxime Ripard <maxime.ripard@free-electrons.com>\nCc: Chen-Yu Tsai <wens@csie.org>\nCc: Peter Rosin <peda@axentia.se>\nCc: linux-i2c@vger.kernel.org\nCc: linuxppc-dev@lists.ozlabs.org\nCc: linux-arm-kernel@lists.infradead.org\n---\n drivers/i2c/busses/i2c-gpio.c | 4 ++--\n drivers/i2c/busses/i2c-powermac.c | 10 ++++------\n drivers/i2c/busses/i2c-sun6i-p2wi.c | 4 ++--\n drivers/i2c/i2c-core-of.c | 24 +++++++++++-------------\n drivers/i2c/muxes/i2c-demux-pinctrl.c | 4 ++--\n 5 files changed, 21 insertions(+), 25 deletions(-)\n\n--\n2.11.0", "diff": "diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c\nindex 34cfc0ebdcb9..0ef8fcc6ac3a 100644\n--- a/drivers/i2c/busses/i2c-gpio.c\n+++ b/drivers/i2c/busses/i2c-gpio.c\n@@ -98,8 +98,8 @@ static int of_i2c_gpio_get_pins(struct device_node *np,\n \t\treturn -EPROBE_DEFER;\n\n \tif (!gpio_is_valid(*sda_pin) || !gpio_is_valid(*scl_pin)) {\n-\t\tpr_err(\"%s: invalid GPIO pins, sda=%d/scl=%d\\n\",\n-\t\t np->full_name, *sda_pin, *scl_pin);\n+\t\tpr_err(\"%pOF: invalid GPIO pins, sda=%d/scl=%d\\n\",\n+\t\t np, *sda_pin, *scl_pin);\n \t\treturn -ENODEV;\n \t}\n\ndiff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c\nindex b0d9dee14a7e..ef9c858fe1d4 100644\n--- a/drivers/i2c/busses/i2c-powermac.c\n+++ b/drivers/i2c/busses/i2c-powermac.c\n@@ -234,7 +234,7 @@ static u32 i2c_powermac_get_addr(struct i2c_adapter *adap,\n \telse if (!strcmp(node->name, \"deq\"))\n \t\treturn 0x34;\n\n-\tdev_warn(&adap->dev, \"No i2c address for %s\\n\", node->full_name);\n+\tdev_warn(&adap->dev, \"No i2c address for %pOF\\n\", node);\n\n \treturn 0xffffffff;\n }\n@@ -315,8 +315,7 @@ static bool i2c_powermac_get_type(struct i2c_adapter *adap,\n \t\t}\n \t}\n\n-\tdev_err(&adap->dev, \"i2c-powermac: modalias failure\"\n-\t\t\" on %s\\n\", node->full_name);\n+\tdev_err(&adap->dev, \"i2c-powermac: modalias failure on %pOF\\n\", node);\n \treturn false;\n }\n\n@@ -348,8 +347,7 @@ static void i2c_powermac_register_devices(struct i2c_adapter *adap,\n \t\tif (!pmac_i2c_match_adapter(node, adap))\n \t\t\tcontinue;\n\n-\t\tdev_dbg(&adap->dev, \"i2c-powermac: register %s\\n\",\n-\t\t\tnode->full_name);\n+\t\tdev_dbg(&adap->dev, \"i2c-powermac: register %pOF\\n\", node);\n\n \t\t/*\n \t\t * Keep track of some device existence to handle\n@@ -372,7 +370,7 @@ static void i2c_powermac_register_devices(struct i2c_adapter *adap,\n \t\tnewdev = i2c_new_device(adap, &info);\n \t\tif (!newdev) {\n \t\t\tdev_err(&adap->dev, \"i2c-powermac: Failure to register\"\n-\t\t\t\t\" %s\\n\", node->full_name);\n+\t\t\t\t\" %pOF\\n\", node);\n \t\t\tof_node_put(node);\n \t\t\t/* We do not dispose of the interrupt mapping on\n \t\t\t * purpose. It's not necessary (interrupt cannot be\ndiff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c\nindex 7668e2e9b8fd..8a24464dc337 100644\n--- a/drivers/i2c/busses/i2c-sun6i-p2wi.c\n+++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c\n@@ -223,8 +223,8 @@ static int p2wi_probe(struct platform_device *pdev)\n \tif (childnp) {\n \t\tret = of_property_read_u32(childnp, \"reg\", &slave_addr);\n \t\tif (ret) {\n-\t\t\tdev_err(dev, \"invalid slave address on node %s\\n\",\n-\t\t\t\tchildnp->full_name);\n+\t\t\tdev_err(dev, \"invalid slave address on node %pOF\\n\",\n+\t\t\t\tchildnp);\n \t\t\treturn -EINVAL;\n \t\t}\n\ndiff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c\nindex ccf82fdbcd8e..8d474bb1dc15 100644\n--- a/drivers/i2c/i2c-core-of.c\n+++ b/drivers/i2c/i2c-core-of.c\n@@ -32,18 +32,17 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,\n \tu32 addr;\n \tint len;\n\n-\tdev_dbg(&adap->dev, \"of_i2c: register %s\\n\", node->full_name);\n+\tdev_dbg(&adap->dev, \"of_i2c: register %pOF\\n\", node);\n\n \tif (of_modalias_node(node, info.type, sizeof(info.type)) < 0) {\n-\t\tdev_err(&adap->dev, \"of_i2c: modalias failure on %s\\n\",\n-\t\t\tnode->full_name);\n+\t\tdev_err(&adap->dev, \"of_i2c: modalias failure on %pOF\\n\",\n+\t\t\tnode);\n \t\treturn ERR_PTR(-EINVAL);\n \t}\n\n \taddr_be = of_get_property(node, \"reg\", &len);\n \tif (!addr_be || (len < sizeof(*addr_be))) {\n-\t\tdev_err(&adap->dev, \"of_i2c: invalid reg on %s\\n\",\n-\t\t\tnode->full_name);\n+\t\tdev_err(&adap->dev, \"of_i2c: invalid reg on %pOF\\n\", node);\n \t\treturn ERR_PTR(-EINVAL);\n \t}\n\n@@ -59,8 +58,8 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,\n \t}\n\n \tif (i2c_check_addr_validity(addr, info.flags)) {\n-\t\tdev_err(&adap->dev, \"of_i2c: invalid addr=%x on %s\\n\",\n-\t\t\taddr, node->full_name);\n+\t\tdev_err(&adap->dev, \"of_i2c: invalid addr=%x on %pOF\\n\",\n+\t\t\taddr, node);\n \t\treturn ERR_PTR(-EINVAL);\n \t}\n\n@@ -76,8 +75,7 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,\n\n \tresult = i2c_new_device(adap, &info);\n \tif (result == NULL) {\n-\t\tdev_err(&adap->dev, \"of_i2c: Failure registering %s\\n\",\n-\t\t\tnode->full_name);\n+\t\tdev_err(&adap->dev, \"of_i2c: Failure registering %pOF\\n\", node);\n \t\tof_node_put(node);\n \t\treturn ERR_PTR(-EINVAL);\n \t}\n@@ -106,8 +104,8 @@ void of_i2c_register_devices(struct i2c_adapter *adap)\n \t\tclient = of_i2c_register_device(adap, node);\n \t\tif (IS_ERR(client)) {\n \t\t\tdev_warn(&adap->dev,\n-\t\t\t\t \"Failed to create I2C device for %s\\n\",\n-\t\t\t\t node->full_name);\n+\t\t\t\t \"Failed to create I2C device for %pOF\\n\",\n+\t\t\t\t node);\n \t\t\tof_node_clear_flag(node, OF_POPULATED);\n \t\t}\n \t}\n@@ -243,8 +241,8 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action,\n \t\tput_device(&adap->dev);\n\n \t\tif (IS_ERR(client)) {\n-\t\t\tdev_err(&adap->dev, \"failed to create client for '%s'\\n\",\n-\t\t\t\t rd->dn->full_name);\n+\t\t\tdev_err(&adap->dev, \"failed to create client for '%pOF'\\n\",\n+\t\t\t\t rd->dn);\n \t\t\tof_node_clear_flag(rd->dn, OF_POPULATED);\n \t\t\treturn notifier_from_errno(PTR_ERR(client));\n \t\t}\ndiff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c\nindex 3e6fe1760d82..33ce032cb701 100644\n--- a/drivers/i2c/muxes/i2c-demux-pinctrl.c\n+++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c\n@@ -167,8 +167,8 @@ static ssize_t available_masters_show(struct device *dev,\n \tint count = 0, i;\n\n \tfor (i = 0; i < priv->num_chan && count < PAGE_SIZE; i++)\n-\t\tcount += scnprintf(buf + count, PAGE_SIZE - count, \"%d:%s%c\",\n-\t\t\t\t i, priv->chan[i].parent_np->full_name,\n+\t\tcount += scnprintf(buf + count, PAGE_SIZE - count, \"%d:%pOF%c\",\n+\t\t\t\t i, priv->chan[i].parent_np,\n \t\t\t\t i == priv->num_chan - 1 ? '\\n' : ' ');\n\n \treturn count;\n", "prefixes": [] }