Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/790119/?format=api
{ "id": 790119, "url": "http://patchwork.ozlabs.org/api/patches/790119/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/20170718104008.9624-2-npiggin@gmail.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170718104008.9624-2-npiggin@gmail.com>", "list_archive_url": null, "date": "2017-07-18T10:40:06", "name": "[RFC,1/3] build: LDFLAGS pass -pie flag explicitly to ld", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f2b0b0795afd7cf7b5e7b5bee27bfc59c5c9a983", "submitter": { "id": 69518, "url": "http://patchwork.ozlabs.org/api/people/69518/?format=api", "name": "Nicholas Piggin", "email": "npiggin@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/20170718104008.9624-2-npiggin@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/790119/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/790119/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xBcC31B9dz9t2M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 18 Jul 2017 20:41:03 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xBcC300FKzDrFs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 18 Jul 2017 20:41:02 +1000 (AEST)", "from mail-pf0-x243.google.com (mail-pf0-x243.google.com\n\t[IPv6:2607:f8b0:400e:c00::243])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xBcBM4lySzDrFV\n\tfor <skiboot@lists.ozlabs.org>; Tue, 18 Jul 2017 20:40:27 +1000 (AEST)", "by mail-pf0-x243.google.com with SMTP id e199so2243149pfh.0\n\tfor <skiboot@lists.ozlabs.org>; Tue, 18 Jul 2017 03:40:27 -0700 (PDT)", "from roar.ozlabs.ibm.com ([122.99.82.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tm5sm4096982pfg.22.2017.07.18.03.40.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 18 Jul 2017 03:40:24 -0700 (PDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"eVVD+YMn\"; dkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"eVVD+YMn\"; dkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"eVVD+YMn\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=2WJpg3f8o0Zcc88vRTd6md3+IWGVYfaY9Geor/7Mmx0=;\n\tb=eVVD+YMnq926446ghGdAXq7MqFS1aZh/fsagauSNFFzL2p7YxiRrM1V7OCleWIPGVF\n\twJAO2c7R7nx50mycs3+DSwFmei9rlS+0VTCQ0fawxrhfBw93oIjHfjD1VOJH5IMS5WJ+\n\tIf/U1PKD+HDLPUYkHaazPKF1+SbojMwLj/nLo89ftHTyj5dT/iV2W4yj3o5E5E5BboRR\n\tpHUDIgouMr6kogiNqFBEuR9t/uRM0wsLTYrJMNFPZMqmaEZT9aHS2e3qKiH7iXsOJsn0\n\tyUOOaRxGHboYXIQUiDAgtW2cCgD0T3ojBErrqbLioJNDLUSWrvgnatKIAcnKlgBYJ3qL\n\thQvw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=2WJpg3f8o0Zcc88vRTd6md3+IWGVYfaY9Geor/7Mmx0=;\n\tb=JhJT+dPIWAX5xBoM3pLyHuPMJqXqeCeM2LV07xgID/McSXIQ7HS7OAMAzxTQvTyZUv\n\tEhbyAPY0JRU7g9cWdOgVnFjgMiMpPvJlS5gUmOxu+8bEEKD01Iq0jS9FMdvq/42nRtE1\n\tyV9vQdG3JyK1+z6dH86sXt1DIpxfopC7aadZdQQmTx3mKzVFFqXSWQWCkeu15rq6oJNM\n\tsCLekdm7+4sBnSkGZ2A1evWMzxDbY8yF4Ia9wvz5tI60lpJgiwO0DgFdT9I6kwfKCix0\n\tlAyVjNVj3p4Zl+9RtBTv39k6ViTq/A7BK9gdBfYf/0Wo5kWDQfSED1B3vQTTTCimCZqA\n\tC3QA==", "X-Gm-Message-State": "AIVw110zg4zUHIjDiDbR+D3+z5v54xqx3fM+V+1HbEneYAHcJos12MXw\n\tlelpxXuyjPjouJTl", "X-Received": "by 10.84.232.13 with SMTP id h13mr1032225plk.168.1500374425729; \n\tTue, 18 Jul 2017 03:40:25 -0700 (PDT)", "From": "Nicholas Piggin <npiggin@gmail.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Tue, 18 Jul 2017 20:40:06 +1000", "Message-Id": "<20170718104008.9624-2-npiggin@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170718104008.9624-1-npiggin@gmail.com>", "References": "<20170718104008.9624-1-npiggin@gmail.com>", "Subject": "[Skiboot] [RFC PATCH 1/3] build: LDFLAGS pass -pie flag explicitly\n\tto ld", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "When building with some toolchains, the gcc -pie option does not\nenable the linker pie without explicitly passing it to ld,\nresulting in a non-PIE binary that silently fails (due to\nrelocation failure). This was observed with the powerpc64le\ncross compiler for Debian.\n\nPass -Wl,-pie explicitly, which allows the powerpc64le toolchain\nto create a position independnet binary that boots.\n\nSigned-off-by: Nicholas Piggin <npiggin@gmail.com>\n---\n Makefile.main | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/Makefile.main b/Makefile.main\nindex 438dcb27..c421cbc6 100644\n--- a/Makefile.main\n+++ b/Makefile.main\n@@ -106,6 +106,7 @@ CFLAGS += $(call try-cflag,$(CC),-Wjump-misses-init) \\\n CFLAGS += $(CWARNS) $(OPTS) $(DBG)\n \n LDFLAGS := -m64 -static -nostdlib -pie \n+LDFLAGS += -Wl,-pie\n LDFLAGS += -Wl,-Ttext-segment,$(LD_TEXT) -Wl,-N -Wl,--build-id=none\n LDFLAGS += -Wl,--no-multi-toc\n LDFLAGS += -mbig-endian -Wl,--oformat,elf64-powerpc\n", "prefixes": [ "RFC", "1/3" ] }