Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/788798/?format=api
{ "id": 788798, "url": "http://patchwork.ozlabs.org/api/patches/788798/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170714132709.52657-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170714132709.52657-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-07-14T13:27:00", "name": "[next,S77-V3,01/10] i40e: fix for flow director counters not wrapping as expected", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0bc8a6a9001cde6b968624ff26ca34851fb94522", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170714132709.52657-1-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/788798/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/788798/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x8QqH0TNGz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 15 Jul 2017 07:31:23 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4012A8A41F;\n\tFri, 14 Jul 2017 21:31:21 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tYAFIDpKh7Aa; Fri, 14 Jul 2017 21:31:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 33DB68A420;\n\tFri, 14 Jul 2017 21:31:20 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E38021C42AA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:31:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DBAE08A41C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:31:18 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eqVMRm8ZI1ys for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:31:16 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 9B3A08A400\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:31:16 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga105.jf.intel.com with ESMTP; 14 Jul 2017 14:31:16 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga005.jf.intel.com with ESMTP; 14 Jul 2017 14:31:16 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,360,1496127600\"; d=\"scan'208\";a=\"125288619\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 14 Jul 2017 09:27:00 -0400", "Message-Id": "<20170714132709.52657-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "Cc": "Mariusz Stachura <mariusz.stachura@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S77-V3 01/10] i40e: fix for flow\n\tdirector counters not wrapping as expected", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Mariusz Stachura <mariusz.stachura@intel.com>\n\nAn eratta with GLQF_PCNT causes it to not wrap as expected. This\ncan cause an error in flow director statistics. This patch resets\naffected counters just after reading.\n\nTesting Hints (required if no HSD): DCR 2187\n\nSigned-off-by: Mariusz Stachura <mariusz.stachura@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 35 +++++++++++++++++++----------\n 1 file changed, 23 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 647a7a6..43ed431 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -600,6 +600,20 @@ static void i40e_stat_update32(struct i40e_hw *hw, u32 reg,\n }\n \n /**\n+ * i40e_stat_update_and_clear32 - read and clear hw reg, update a 32 bit stat\n+ * @hw: ptr to the hardware info\n+ * @reg: the hw reg to read and clear\n+ * @stat: ptr to the stat\n+ **/\n+static void i40e_stat_update_and_clear32(struct i40e_hw *hw, u32 reg, u64 *stat)\n+{\n+\tu32 new_data = rd32(hw, reg);\n+\n+\twr32(hw, reg, 1); /* must write a nonzero value to clear register */\n+\t*stat += new_data;\n+}\n+\n+/**\n * i40e_update_eth_stats - Update VSI-specific ethernet statistics counters.\n * @vsi: the VSI to be updated\n **/\n@@ -1040,18 +1054,15 @@ static void i40e_update_pf_stats(struct i40e_pf *pf)\n \t\t\t &osd->rx_jabber, &nsd->rx_jabber);\n \n \t/* FDIR stats */\n-\ti40e_stat_update32(hw,\n-\t\t\t I40E_GLQF_PCNT(I40E_FD_ATR_STAT_IDX(pf->hw.pf_id)),\n-\t\t\t pf->stat_offsets_loaded,\n-\t\t\t &osd->fd_atr_match, &nsd->fd_atr_match);\n-\ti40e_stat_update32(hw,\n-\t\t\t I40E_GLQF_PCNT(I40E_FD_SB_STAT_IDX(pf->hw.pf_id)),\n-\t\t\t pf->stat_offsets_loaded,\n-\t\t\t &osd->fd_sb_match, &nsd->fd_sb_match);\n-\ti40e_stat_update32(hw,\n-\t\t I40E_GLQF_PCNT(I40E_FD_ATR_TUNNEL_STAT_IDX(pf->hw.pf_id)),\n-\t\t pf->stat_offsets_loaded,\n-\t\t &osd->fd_atr_tunnel_match, &nsd->fd_atr_tunnel_match);\n+\ti40e_stat_update_and_clear32(hw,\n+\t\t\tI40E_GLQF_PCNT(I40E_FD_ATR_STAT_IDX(hw->pf_id)),\n+\t\t\t&nsd->fd_atr_match);\n+\ti40e_stat_update_and_clear32(hw,\n+\t\t\tI40E_GLQF_PCNT(I40E_FD_SB_STAT_IDX(hw->pf_id)),\n+\t\t\t&nsd->fd_sb_match);\n+\ti40e_stat_update_and_clear32(hw,\n+\t\t\tI40E_GLQF_PCNT(I40E_FD_ATR_TUNNEL_STAT_IDX(hw->pf_id)),\n+\t\t\t&nsd->fd_atr_tunnel_match);\n \n \tval = rd32(hw, I40E_PRTPM_EEE_STAT);\n \tnsd->tx_lpi_status =\n", "prefixes": [ "next", "S77-V3", "01/10" ] }