Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/788793/?format=api
{ "id": 788793, "url": "http://patchwork.ozlabs.org/api/patches/788793/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170714131019.52530-9-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170714131019.52530-9-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-07-14T13:10:15", "name": "[next,S76-V2,09/13] i40e: Fix unqualified module message while bringing link up", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8fc8493c3269170092cab1fca8114ef7d2fe601b", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170714131019.52530-9-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/788793/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/788793/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x8QRp2CYGz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 15 Jul 2017 07:14:30 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9121C8841F;\n\tFri, 14 Jul 2017 21:14:28 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xiRlPNpY99TC; Fri, 14 Jul 2017 21:14:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6495288416;\n\tFri, 14 Jul 2017 21:14:25 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E12BB1C0683\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DBFCC8A41C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:21 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mgYHf-5eRTY6 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:19 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 2F3888A41D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:19 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga105.fm.intel.com with ESMTP; 14 Jul 2017 14:14:18 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga002.jf.intel.com with ESMTP; 14 Jul 2017 14:14:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,360,1496127600\"; d=\"scan'208\";a=\"111486601\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 14 Jul 2017 09:10:15 -0400", "Message-Id": "<20170714131019.52530-9-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170714131019.52530-1-alice.michael@intel.com>", "References": "<20170714131019.52530-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S76-V2 09/13] i40e: Fix unqualified\n\tmodule message while bringing link up", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>\n\nIn current driver, when ifconfig ethx up is done, the link state\ndoesn't transition to UP inside i40e_open(). It changes after AQ\ncommand response is handled in i40e_handle_link_event().\n\nWhen pf->hw.phy.link_info.link_info is DOWN inside i40e_open(),\nThe state is transient and invalid. So log message gets printed\nbased on incorrect info (i.e link_info and an_info).\n\nThis commit removes check for unqualified module inside\ni40e_up_complete(). The existing check in i40e_handle_link_event()\nlogs the error message based on correct link state information.\n\nSigned-off-by: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 9 ---------\n 1 file changed, 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex abf4025..beeeeeb 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -5457,15 +5457,6 @@ static int i40e_up_complete(struct i40e_vsi *vsi)\n \t\ti40e_print_link_message(vsi, true);\n \t\tnetif_tx_start_all_queues(vsi->netdev);\n \t\tnetif_carrier_on(vsi->netdev);\n-\t} else if (vsi->netdev) {\n-\t\ti40e_print_link_message(vsi, false);\n-\t\t/* need to check for qualified module here*/\n-\t\tif ((pf->hw.phy.link_info.link_info &\n-\t\t\tI40E_AQ_MEDIA_AVAILABLE) &&\n-\t\t (!(pf->hw.phy.link_info.an_info &\n-\t\t\tI40E_AQ_QUALIFIED_MODULE)))\n-\t\t\tnetdev_err(vsi->netdev,\n-\t\t\t\t \"the driver failed to link because an unqualified module was detected.\");\n \t}\n \n \t/* replay FDIR SB filters */\n", "prefixes": [ "next", "S76-V2", "09/13" ] }