Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/788790/?format=api
{ "id": 788790, "url": "http://patchwork.ozlabs.org/api/patches/788790/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170714131019.52530-8-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170714131019.52530-8-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-07-14T13:10:14", "name": "[next,S76-V2,08/13] i40e/i40evf: rename bytes_per_int to bytes_per_usec", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4bead72e3811a5ea6169f000ecb52c510999af56", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170714131019.52530-8-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/788790/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/788790/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x8QRm6Q2Bz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 15 Jul 2017 07:14:28 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 36B2788402;\n\tFri, 14 Jul 2017 21:14:27 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id B--MIjcFKsgm; Fri, 14 Jul 2017 21:14:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C6BFC88434;\n\tFri, 14 Jul 2017 21:14:24 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id A357E1C42AA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 95F462F5F2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:20 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PjqEIhjH2L5A for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:19 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 279CC2F5DA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:19 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga105.fm.intel.com with ESMTP; 14 Jul 2017 14:14:18 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga002.jf.intel.com with ESMTP; 14 Jul 2017 14:14:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,360,1496127600\"; d=\"scan'208\";a=\"111486598\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 14 Jul 2017 09:10:14 -0400", "Message-Id": "<20170714131019.52530-8-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170714131019.52530-1-alice.michael@intel.com>", "References": "<20170714131019.52530-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S76-V2 08/13] i40e/i40evf: rename\n\tbytes_per_int to bytes_per_usec", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThis value is not calculating bytes_per_int, which would actually just\nbe bytes/ITR_COUNTDOWN_START, but rather it's calculating bytes/usecs.\n\nRename the variable for clarity so that future developers understand\nwhat the value is actually calculating.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 12 ++++++------\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 12 ++++++------\n 2 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 74589ed..8cd8203 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -960,14 +960,14 @@ static bool i40e_set_new_dynamic_itr(struct i40e_ring_container *rc)\n {\n \tenum i40e_latency_range new_latency_range = rc->latency_range;\n \tu32 new_itr = rc->itr;\n-\tint bytes_per_int;\n+\tint bytes_per_usec;\n \tunsigned int usecs, estimated_usecs;\n \n \tif (rc->total_packets == 0 || !rc->itr)\n \t\treturn false;\n \n \tusecs = (rc->itr << 1) * ITR_COUNTDOWN_START;\n-\tbytes_per_int = rc->total_bytes / usecs;\n+\tbytes_per_usec = rc->total_bytes / usecs;\n \n \t/* The calculations in this algorithm depend on interrupts actually\n \t * firing at the ITR rate. This may not happen if the packet rate is\n@@ -993,18 +993,18 @@ static bool i40e_set_new_dynamic_itr(struct i40e_ring_container *rc)\n \t */\n \tswitch (new_latency_range) {\n \tcase I40E_LOWEST_LATENCY:\n-\t\tif (bytes_per_int > 10)\n+\t\tif (bytes_per_usec > 10)\n \t\t\tnew_latency_range = I40E_LOW_LATENCY;\n \t\tbreak;\n \tcase I40E_LOW_LATENCY:\n-\t\tif (bytes_per_int > 20)\n+\t\tif (bytes_per_usec > 20)\n \t\t\tnew_latency_range = I40E_BULK_LATENCY;\n-\t\telse if (bytes_per_int <= 10)\n+\t\telse if (bytes_per_usec <= 10)\n \t\t\tnew_latency_range = I40E_LOWEST_LATENCY;\n \t\tbreak;\n \tcase I40E_BULK_LATENCY:\n \tdefault:\n-\t\tif (bytes_per_int <= 20)\n+\t\tif (bytes_per_usec <= 20)\n \t\t\tnew_latency_range = I40E_LOW_LATENCY;\n \t\tbreak;\n \t}\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex b56a193..8167617 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -358,14 +358,14 @@ static bool i40e_set_new_dynamic_itr(struct i40e_ring_container *rc)\n {\n \tenum i40e_latency_range new_latency_range = rc->latency_range;\n \tu32 new_itr = rc->itr;\n-\tint bytes_per_int;\n+\tint bytes_per_usec;\n \tunsigned int usecs, estimated_usecs;\n \n \tif (rc->total_packets == 0 || !rc->itr)\n \t\treturn false;\n \n \tusecs = (rc->itr << 1) * ITR_COUNTDOWN_START;\n-\tbytes_per_int = rc->total_bytes / usecs;\n+\tbytes_per_usec = rc->total_bytes / usecs;\n \n \t/* The calculations in this algorithm depend on interrupts actually\n \t * firing at the ITR rate. This may not happen if the packet rate is\n@@ -391,18 +391,18 @@ static bool i40e_set_new_dynamic_itr(struct i40e_ring_container *rc)\n \t */\n \tswitch (new_latency_range) {\n \tcase I40E_LOWEST_LATENCY:\n-\t\tif (bytes_per_int > 10)\n+\t\tif (bytes_per_usec > 10)\n \t\t\tnew_latency_range = I40E_LOW_LATENCY;\n \t\tbreak;\n \tcase I40E_LOW_LATENCY:\n-\t\tif (bytes_per_int > 20)\n+\t\tif (bytes_per_usec > 20)\n \t\t\tnew_latency_range = I40E_BULK_LATENCY;\n-\t\telse if (bytes_per_int <= 10)\n+\t\telse if (bytes_per_usec <= 10)\n \t\t\tnew_latency_range = I40E_LOWEST_LATENCY;\n \t\tbreak;\n \tcase I40E_BULK_LATENCY:\n \tdefault:\n-\t\tif (bytes_per_int <= 20)\n+\t\tif (bytes_per_usec <= 20)\n \t\t\tnew_latency_range = I40E_LOW_LATENCY;\n \t\tbreak;\n \t}\n", "prefixes": [ "next", "S76-V2", "08/13" ] }