Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/788788/?format=api
{ "id": 788788, "url": "http://patchwork.ozlabs.org/api/patches/788788/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170714131019.52530-10-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170714131019.52530-10-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-07-14T13:10:16", "name": "[next,S76-V2,10/13] i40e: Fix link down message when interface is brought up", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5fc81339d7b172ffd41c9e7fd696d338117b23f0", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170714131019.52530-10-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/788788/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/788788/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x8QRl2nwmz9sNd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 15 Jul 2017 07:14:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F26DC88445;\n\tFri, 14 Jul 2017 21:14:25 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lEXeiz6ZW1YJ; Fri, 14 Jul 2017 21:14:23 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D385B88411;\n\tFri, 14 Jul 2017 21:14:23 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E05561C42AA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D77662F9F9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:19 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id D-dTCszqsuDF for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:19 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 4990B2F5F2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:19 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga105.fm.intel.com with ESMTP; 14 Jul 2017 14:14:18 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga002.jf.intel.com with ESMTP; 14 Jul 2017 14:14:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,360,1496127600\"; d=\"scan'208\";a=\"111486604\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 14 Jul 2017 09:10:16 -0400", "Message-Id": "<20170714131019.52530-10-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170714131019.52530-1-alice.michael@intel.com>", "References": "<20170714131019.52530-1-alice.michael@intel.com>", "Cc": "Mogilappagari@osuosl.org", "Subject": "[Intel-wired-lan] [next PATCH S76-V2 10/13] i40e: Fix link down\n\tmessage when interface is brought up", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>\n\ni40e_print_link_message() is intended to compare new\nlink state with current link state and print log message\nonly if the new state is different from current state.\n\nHowever in current driver the new state does not get updated\nwhen link is going down because of the if condition. When an\ninterface is brought down, vsi->state is set to I40E_VSI_DOWN\nin i40e_vsi_close() and later i40e_print_link_message() does\nnot get invoked in i40e_link_event due to if condition. Hence\nlink down message doesn't appear when link is going down. The\ndown state is seen later during i40e_open() and old state\ngets printed. The actual link state doesn't get updated in\ni40e_close() or i40e_open() but when i40e_handle_link_event is\ncalled inside i40e_clean_adminq_subtask.\n\nThis change allows i40e_print_link_message() to be called when\ninterface is going down and keeps the state information updated.\n\nSigned-off-by: Mogilappagari, Sudheer <sudheer.mogilappagari@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex beeeeeb..b4844e2 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -6406,8 +6406,7 @@ static void i40e_link_event(struct i40e_pf *pf)\n \t new_link == netif_carrier_ok(vsi->netdev)))\n \t\treturn;\n \n-\tif (!test_bit(__I40E_VSI_DOWN, vsi->state))\n-\t\ti40e_print_link_message(vsi, new_link);\n+\ti40e_print_link_message(vsi, new_link);\n \n \t/* Notify the base of the switch tree connected to\n \t * the link. Floating VEBs are not notified.\n", "prefixes": [ "next", "S76-V2", "10/13" ] }