Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/788785/?format=api
{ "id": 788785, "url": "http://patchwork.ozlabs.org/api/patches/788785/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170714131019.52530-2-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170714131019.52530-2-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-07-14T13:10:08", "name": "[next,S76-V2,02/13] i40e: remove workaround for resetting XPS on newer kernels", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ea77fda3c03d7eefc0ce47fd753686e42119ac2c", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170714131019.52530-2-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/788785/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/788785/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x8QRh4sY7z9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 15 Jul 2017 07:14:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3BF3A88416;\n\tFri, 14 Jul 2017 21:14:23 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tNsOPZDpbPws; Fri, 14 Jul 2017 21:14:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A9F8F883FE;\n\tFri, 14 Jul 2017 21:14:22 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 11A4F1CE81B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0805C8A42B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:19 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id z+dgKAgaD9jA for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:18 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 6A3D28A41D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jul 2017 21:14:18 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga105.fm.intel.com with ESMTP; 14 Jul 2017 14:14:17 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga002.jf.intel.com with ESMTP; 14 Jul 2017 14:14:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,360,1496127600\"; d=\"scan'208\";a=\"111486581\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 14 Jul 2017 09:10:08 -0400", "Message-Id": "<20170714131019.52530-2-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170714131019.52530-1-alice.michael@intel.com>", "References": "<20170714131019.52530-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S76-V2 02/13] i40e: remove workaround\n\tfor resetting XPS on newer kernels", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nSince commit 3ffa037d7f78 (\"i40e: Set XPS bit mask to zero in DCB mode\")\nwe've tried to reset the XPS settings by building a custom\nempty CPU mask.\n\nThis workaround is not necessary because we're not really removing the\nXPS setting, but simply setting it so that no CPU is valid. Since v4.10\nwe've had this taken care of for us in the netdev core code.\n\nWe recently added a new macro to COMPAT which allows us to wrap the XPS\nworkaround when it's not necessary.\n\nWhile we're doing this, we change the ordering of the calls, and add an\nearly return statement. This helps make the code easier to understand,\nand reduces the headache of reading these #ifdefs. This should help\nfuture maintainability.\n\nSecond, we shorten the code further by using zalloc_cpumask_var instead\nof a separate call to bitmap_zero().\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 17 +++++------------\n 1 file changed, 5 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 9ee1d0f..5004857 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -2875,22 +2875,15 @@ static void i40e_vsi_free_rx_resources(struct i40e_vsi *vsi)\n static void i40e_config_xps_tx_ring(struct i40e_ring *ring)\n {\n \tstruct i40e_vsi *vsi = ring->vsi;\n-\tcpumask_var_t mask;\n \n \tif (!ring->q_vector || !ring->netdev)\n \t\treturn;\n \n-\t/* Single TC mode enable XPS */\n-\tif (vsi->tc_config.numtc <= 1) {\n-\t\tif (!test_and_set_bit(__I40E_TX_XPS_INIT_DONE, &ring->state))\n-\t\t\tnetif_set_xps_queue(ring->netdev,\n-\t\t\t\t\t &ring->q_vector->affinity_mask,\n-\t\t\t\t\t ring->queue_index);\n-\t} else if (alloc_cpumask_var(&mask, GFP_KERNEL)) {\n-\t\t/* Disable XPS to allow selection based on TC */\n-\t\tbitmap_zero(cpumask_bits(mask), nr_cpumask_bits);\n-\t\tnetif_set_xps_queue(ring->netdev, mask, ring->queue_index);\n-\t\tfree_cpumask_var(mask);\n+\tif ((vsi->tc_config.numtc <= 1) &&\n+\t !test_and_set_bit(__I40E_TX_XPS_INIT_DONE, &ring->state)) {\n+\t\tnetif_set_xps_queue(ring->netdev,\n+\t\t\t\t &ring->q_vector->affinity_mask,\n+\t\t\t\t ring->queue_index);\n \t}\n \n \t/* schedule our worker thread which will take care of\n", "prefixes": [ "next", "S76-V2", "02/13" ] }