Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/787990/?format=api
{ "id": 787990, "url": "http://patchwork.ozlabs.org/api/patches/787990/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712210925.4F647FAA@viggo.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170712210925.4F647FAA@viggo.jf.intel.com>", "list_archive_url": null, "date": "2017-07-12T21:09:25", "name": "igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "7029001a3f8cbc6af3b198e446df7c4e3c55bee3", "submitter": { "id": 66894, "url": "http://patchwork.ozlabs.org/api/people/66894/?format=api", "name": "Dave Hansen", "email": "dave.hansen@linux.intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712210925.4F647FAA@viggo.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/787990/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/787990/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x7pY63h7xz9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 14 Jul 2017 07:16:58 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 85CAC30ADE;\n\tThu, 13 Jul 2017 21:16:56 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JBpaDmlOB+d1; Thu, 13 Jul 2017 21:16:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id C7ED930ABC;\n\tThu, 13 Jul 2017 21:16:55 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id C5AF21C411E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 21:10:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BD8A888AA4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 21:10:44 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8m2yzMWWFK3r for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 21:10:44 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id E33B888A2D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 21:10:43 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga105.fm.intel.com with ESMTP; 12 Jul 2017 14:10:43 -0700", "from viggo.jf.intel.com (HELO localhost.localdomain)\n\t([10.54.39.20])\n\tby orsmga005.jf.intel.com with ESMTP; 12 Jul 2017 14:10:43 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,351,1496127600\"; d=\"scan'208\";a=\"124442295\"", "To": "linux-kernel@vger.kernel.org", "From": "Dave Hansen <dave.hansen@linux.intel.com>", "Date": "Wed, 12 Jul 2017 14:09:25 -0700", "Message-Id": "<20170712210925.4F647FAA@viggo.jf.intel.com>", "X-Mailman-Approved-At": "Thu, 13 Jul 2017 21:16:54 +0000", "Cc": "netdev@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,\n\tintel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH] igb: fix unused igb_deliver_wake_packet()\n\twarning when CONFIG_PM=n", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Dave Hansen <dave.hansen@linux.intel.com>\n\nI'm seeing warnings on kernel configurations where CONFIG_PM is\ndisabled. It happens in 4.12, at least:\n\ndrivers/ethernet/intel/igb/igb_main.c:7988:13: warning: 'igb_deliver_wake_packet' defined but not used [-Wunused-function]\n\nThis is because igb_deliver_wake_packet() is defined outside of\nthe #ifdef\", but is used only a single time within the #ifdef in\nigb_resume(). Fix it by moving igb_deliver_wake_packet() next to\nigb_resume() inside the #ifdef.\n\nThe diff ends up looking a bit funky here. It *looks* like\nigb_suspend() is getting moved, but that's an artifact of how\n'diff' sees the changes.\n\nCc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nCc: intel-wired-lan@lists.osuosl.org\nCc: netdev@vger.kernel.org\nSigned-off-by: Dave Hansen <dave.hansen@linux.intel.com>\n---\n\n b/drivers/net/ethernet/intel/igb/igb_main.c | 46 ++++++++++++++--------------\n 1 file changed, 23 insertions(+), 23 deletions(-)", "diff": "diff -puN drivers/net/ethernet/intel/igb/igb_main.c~undef-igb_deliver_wake_packet drivers/net/ethernet/intel/igb/igb_main.c\n--- a/drivers/net/ethernet/intel/igb/igb_main.c~undef-igb_deliver_wake_packet\t2017-07-12 14:08:37.205721093 -0700\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\t2017-07-12 14:08:37.210721093 -0700\n@@ -7985,6 +7985,29 @@ static int __igb_shutdown(struct pci_dev\n \treturn 0;\n }\n \n+#ifdef CONFIG_PM\n+#ifdef CONFIG_PM_SLEEP\n+static int igb_suspend(struct device *dev)\n+{\n+\tint retval;\n+\tbool wake;\n+\tstruct pci_dev *pdev = to_pci_dev(dev);\n+\n+\tretval = __igb_shutdown(pdev, &wake, 0);\n+\tif (retval)\n+\t\treturn retval;\n+\n+\tif (wake) {\n+\t\tpci_prepare_to_sleep(pdev);\n+\t} else {\n+\t\tpci_wake_from_d3(pdev, false);\n+\t\tpci_set_power_state(pdev, PCI_D3hot);\n+\t}\n+\n+\treturn 0;\n+}\n+#endif /* CONFIG_PM_SLEEP */\n+\n static void igb_deliver_wake_packet(struct net_device *netdev)\n {\n \tstruct igb_adapter *adapter = netdev_priv(netdev);\n@@ -8015,29 +8038,6 @@ static void igb_deliver_wake_packet(stru\n \tnetif_rx(skb);\n }\n \n-#ifdef CONFIG_PM\n-#ifdef CONFIG_PM_SLEEP\n-static int igb_suspend(struct device *dev)\n-{\n-\tint retval;\n-\tbool wake;\n-\tstruct pci_dev *pdev = to_pci_dev(dev);\n-\n-\tretval = __igb_shutdown(pdev, &wake, 0);\n-\tif (retval)\n-\t\treturn retval;\n-\n-\tif (wake) {\n-\t\tpci_prepare_to_sleep(pdev);\n-\t} else {\n-\t\tpci_wake_from_d3(pdev, false);\n-\t\tpci_set_power_state(pdev, PCI_D3hot);\n-\t}\n-\n-\treturn 0;\n-}\n-#endif /* CONFIG_PM_SLEEP */\n-\n static int igb_resume(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n", "prefixes": [] }