Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/787396/?format=api
{ "id": 787396, "url": "http://patchwork.ozlabs.org/api/patches/787396/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712094614.76501-9-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170712094614.76501-9-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-07-12T09:46:12", "name": "[next,S75-V3,09/11] i40e: force VMDQ device name truncation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b07bc55baa7d6b9b3a76bd618f7736ea1942b09b", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712094614.76501-9-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/787396/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/787396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x761r4sHhz9s7C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 13 Jul 2017 03:50:56 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BBC923091A;\n\tWed, 12 Jul 2017 17:50:54 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rxoNEvoiEdaN; Wed, 12 Jul 2017 17:50:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E4B0A30930;\n\tWed, 12 Jul 2017 17:50:48 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 01FE71C4121\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EEC3187EC9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:44 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9mpf2pRu3eEl for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:43 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id AF43C87ECC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:42 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP; 12 Jul 2017 10:50:41 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby FMSMGA003.fm.intel.com with ESMTP; 12 Jul 2017 10:50:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,350,1496127600\"; d=\"scan'208\";a=\"878118686\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 12 Jul 2017 05:46:12 -0400", "Message-Id": "<20170712094614.76501-9-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170712094614.76501-1-alice.michael@intel.com>", "References": "<20170712094614.76501-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S75-V3 09/11] i40e: force VMDQ device\n\tname truncation", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nIn new versions of GCC since 7.x a new warning exists which warns when\na string is truncated before all of the format can be completed.\n\nWhen we setup VMDQ netdev names we are copying a pre-existing interface\nname which could be up to 15 characters in length. Since we also add\n4 bytes, v, the literal %, the d and a \\0 null, we would overrun the\navailable size unless snprintf truncated for us.\n\nThe snprintf call will ofcourse truncate on the end, so lets instead\nmodify the code to force truncation of the copied netdev name by\n4 characters, to create enough space for the 4 bytes we're adding.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 837d434..0c8c07d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -9690,8 +9690,13 @@ static int i40e_config_netdev(struct i40e_vsi *vsi)\n \t\ti40e_add_mac_filter(vsi, mac_addr);\n \t\tspin_unlock_bh(&vsi->mac_filter_hash_lock);\n \t} else {\n-\t\t/* relate the VSI_VMDQ name to the VSI_MAIN name */\n-\t\tsnprintf(netdev->name, IFNAMSIZ, \"%sv%%d\",\n+\t\t/* Relate the VSI_VMDQ name to the VSI_MAIN name. Note that we\n+\t\t * are still limited by IFNAMSIZ, but we're adding 'v%d\\0' to\n+\t\t * the end, which is 4 bytes long, so force truncation of the\n+\t\t * original name by IFNAMSIZ - 4\n+\t\t */\n+\t\tsnprintf(netdev->name, IFNAMSIZ, \"%.*sv%%d\",\n+\t\t\t IFNAMSIZ - 4,\n \t\t\t pf->vsi[pf->lan_vsi]->netdev->name);\n \t\trandom_ether_addr(mac_addr);\n \n", "prefixes": [ "next", "S75-V3", "09/11" ] }