Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/787394/?format=api
{ "id": 787394, "url": "http://patchwork.ozlabs.org/api/patches/787394/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712094614.76501-8-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170712094614.76501-8-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-07-12T09:46:11", "name": "[next,S75-V3,08/11] i40evf: fix possible snprintf truncation of q_vector->name", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c91016724455487483c66fe22f8cd142516f4e40", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712094614.76501-8-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/787394/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/787394/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x761p60sxz9s71\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 13 Jul 2017 03:50:54 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2E6D030917;\n\tWed, 12 Jul 2017 17:50:53 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id g7Gia+ynb93x; Wed, 12 Jul 2017 17:50:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4C66C30927;\n\tWed, 12 Jul 2017 17:50:48 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 628451C411B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5CA0D89FDF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 87JXXHsBtSNR for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:42 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 94D7089FF7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:42 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP; 12 Jul 2017 10:50:41 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby FMSMGA003.fm.intel.com with ESMTP; 12 Jul 2017 10:50:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,350,1496127600\"; d=\"scan'208\";a=\"878118683\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 12 Jul 2017 05:46:11 -0400", "Message-Id": "<20170712094614.76501-8-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170712094614.76501-1-alice.michael@intel.com>", "References": "<20170712094614.76501-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S75-V3 08/11] i40evf: fix possible\n\tsnprintf truncation of q_vector->name", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThe q_vector names are based on the interface name with a driver prefix,\nthe type of q_vector setup, and the queue number. We previously set the\nsize of this variable to IFNAMSIZ + 9, which is incorrect, because we\nactually include a minimum of 14 characters extra beyond the interface\nname size.\n\nNew versions of GCC since 7 include a new warning that detects this\npossible truncation and complains. We can fix this by increasing the\nsize incase our interface name is too large to avoid truncation. We\ndon't need to go beyond 14 because the compiler is smart enough to\nrealize our values can never exceed size of 1. We do go up to 15 here\nbecause possible future changes may increase the number of queues beyond\none digit.\n\nWhile we are here, also change some variables to be unsigned (since they\nare never negative) and stop using an extra unnecessary %s format\nspecifier.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf.h | 2 +-\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 21 +++++++++------------\n 2 files changed, 10 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf.h b/drivers/net/ethernet/intel/i40evf/i40evf.h\nindex c89767e..f028c09 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf.h\n@@ -121,7 +121,7 @@ struct i40e_q_vector {\n #define ITR_COUNTDOWN_START 100\n \tu8 itr_countdown;\t/* when 0 or 1 update ITR */\n \tint v_idx;\t/* vector index in list */\n-\tchar name[IFNAMSIZ + 9];\n+\tchar name[IFNAMSIZ + 15];\n \tbool arm_wb_state;\n \tcpumask_t affinity_mask;\n \tstruct irq_affinity_notify affinity_notify;\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 755f60f..a8bc1ed 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -543,9 +543,9 @@ static void i40evf_irq_affinity_release(struct kref *ref) {}\n static int\n i40evf_request_traffic_irqs(struct i40evf_adapter *adapter, char *basename)\n {\n-\tint vector, err, q_vectors;\n-\tint rx_int_idx = 0, tx_int_idx = 0;\n-\tint irq_num;\n+\tunsigned int vector, q_vectors;\n+\tunsigned int rx_int_idx = 0, tx_int_idx = 0;\n+\tint irq_num, err;\n \n \ti40evf_irq_disable(adapter);\n \t/* Decrement for Other and TCP Timer vectors */\n@@ -556,18 +556,15 @@ i40evf_request_traffic_irqs(struct i40evf_adapter *adapter, char *basename)\n \t\tirq_num = adapter->msix_entries[vector + NONQ_VECS].vector;\n \n \t\tif (q_vector->tx.ring && q_vector->rx.ring) {\n-\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name) - 1,\n-\t\t\t\t \"i40evf-%s-%s-%d\", basename,\n-\t\t\t\t \"TxRx\", rx_int_idx++);\n+\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name),\n+\t\t\t\t \"i40evf-%s-TxRx-%d\", basename, rx_int_idx++);\n \t\t\ttx_int_idx++;\n \t\t} else if (q_vector->rx.ring) {\n-\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name) - 1,\n-\t\t\t\t \"i40evf-%s-%s-%d\", basename,\n-\t\t\t\t \"rx\", rx_int_idx++);\n+\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name),\n+\t\t\t\t \"i40evf-%s-rx-%d\", basename, rx_int_idx++);\n \t\t} else if (q_vector->tx.ring) {\n-\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name) - 1,\n-\t\t\t\t \"i40evf-%s-%s-%d\", basename,\n-\t\t\t\t \"tx\", tx_int_idx++);\n+\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name),\n+\t\t\t\t \"i40evf-%s-tx-%d\", basename, tx_int_idx++);\n \t\t} else {\n \t\t\t/* skip this unused q_vector */\n \t\t\tcontinue;\n", "prefixes": [ "next", "S75-V3", "08/11" ] }