Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/784910/?format=api
{ "id": 784910, "url": "http://patchwork.ozlabs.org/api/patches/784910/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170705225730.8377.3240.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170705225730.8377.3240.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2017-07-05T22:57:30", "name": "[v2] ixgbe: Clear SWFW_SYNC register during init", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "09160ee14070d2588e54189ca52e9fe2ebbb3503", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170705225730.8377.3240.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/784910/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/784910/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x2xC80fWHz9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Jul 2017 08:59:31 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 715658926E;\n\tWed, 5 Jul 2017 22:59:29 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 88d+kEHRGqun; Wed, 5 Jul 2017 22:59:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AE87A89233;\n\tWed, 5 Jul 2017 22:59:28 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 014041BFD86\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Jul 2017 22:59:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E82AC879A3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Jul 2017 22:59:26 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ykhE3SfFY3jf for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Jul 2017 22:59:25 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id CA38B87411\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Jul 2017 22:59:25 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jul 2017 15:59:21 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.78])\n\tby orsmga002.jf.intel.com with ESMTP; 05 Jul 2017 15:59:21 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,314,1496127600\"; d=\"scan'208\";a=\"107503879\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 05 Jul 2017 15:57:30 -0700", "Message-ID": "<20170705225730.8377.3240.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v2] ixgbe: Clear SWFW_SYNC register during\n\tinit", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Added clearing of SW resource bits in the SW/FW synchronization\nregister to ixgbe_init_swfw_sync_X540().\n\nUpdated ixgbe_acquire_swfw_sync_X540 SW Manageability host interface\nresource bit error case to match the error handling of the other SW\nresource bits. Which is to release the SW resource bits if SW times\nout while attempting to acquire the resource.\n\nThis allows the driver to load in cases where the semaphore bits\ncould be stuck after a reset or a crash.\n\n-v2 - fixed title\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 19 ++++++++++++-------\n 1 file changed, 12 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\nindex 6ea0d6a..b8c5fd2 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\n@@ -619,12 +619,6 @@ s32 ixgbe_acquire_swfw_sync_X540(struct ixgbe_hw *hw, u32 mask)\n \t\tusleep_range(5000, 10000);\n \t}\n \n-\t/* Failed to get SW only semaphore */\n-\tif (swmask == IXGBE_GSSR_SW_MNG_SM) {\n-\t\thw_dbg(hw, \"Failed to get SW only semaphore\\n\");\n-\t\treturn IXGBE_ERR_SWFW_SYNC;\n-\t}\n-\n \t/* If the resource is not released by the FW/HW the SW can assume that\n \t * the FW/HW malfunctions. In that case the SW should set the SW bit(s)\n \t * of the requested resource(s) while ignoring the corresponding FW/HW\n@@ -647,7 +641,8 @@ s32 ixgbe_acquire_swfw_sync_X540(struct ixgbe_hw *hw, u32 mask)\n \t */\n \tif (swfw_sync & swmask) {\n \t\tu32 rmask = IXGBE_GSSR_EEP_SM | IXGBE_GSSR_PHY0_SM |\n-\t\t\t IXGBE_GSSR_PHY1_SM | IXGBE_GSSR_MAC_CSR_SM;\n+\t\t\t IXGBE_GSSR_PHY1_SM | IXGBE_GSSR_MAC_CSR_SM |\n+\t\t\t IXGBE_GSSR_SW_MNG_SM;\n \n \t\tif (swi2c_mask)\n \t\t\trmask |= IXGBE_GSSR_I2C_MASK;\n@@ -763,6 +758,8 @@ static void ixgbe_release_swfw_sync_semaphore(struct ixgbe_hw *hw)\n **/\n void ixgbe_init_swfw_sync_X540(struct ixgbe_hw *hw)\n {\n+\tu32 rmask;\n+\n \t/* First try to grab the semaphore but we don't need to bother\n \t * looking to see whether we got the lock or not since we do\n \t * the same thing regardless of whether we got the lock or not.\n@@ -771,6 +768,14 @@ void ixgbe_init_swfw_sync_X540(struct ixgbe_hw *hw)\n \t */\n \tixgbe_get_swfw_sync_semaphore(hw);\n \tixgbe_release_swfw_sync_semaphore(hw);\n+\n+\t/* Acquire and release all software resources. */\n+\trmask = IXGBE_GSSR_EEP_SM | IXGBE_GSSR_PHY0_SM |\n+\t\tIXGBE_GSSR_PHY1_SM | IXGBE_GSSR_MAC_CSR_SM |\n+\t\tIXGBE_GSSR_SW_MNG_SM | IXGBE_GSSR_I2C_MASK;\n+\n+\tixgbe_acquire_swfw_sync_X540(hw, rmask);\n+\tixgbe_release_swfw_sync_X540(hw, rmask);\n }\n \n /**\n", "prefixes": [ "v2" ] }