Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/779845/?format=api
{ "id": 779845, "url": "http://patchwork.ozlabs.org/api/patches/779845/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170623074624.32405-1-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170623074624.32405-1-sassmann@kpanic.de>", "list_archive_url": null, "date": "2017-06-23T07:46:24", "name": "i40e: handle setting administratively set MAC address back to zero", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "855490c7208897fbc2d274dc19a3d1e064293d09", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170623074624.32405-1-sassmann@kpanic.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/779845/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/779845/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wv9hf0jQqz9s4q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 23 Jun 2017 17:54:41 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 580372F212;\n\tFri, 23 Jun 2017 07:54:39 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kKn3VEKuOdmZ; Fri, 23 Jun 2017 07:54:38 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id B403525AD8;\n\tFri, 23 Jun 2017 07:54:38 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id BB2511C037C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 23 Jun 2017 07:54:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AFDCA25D37\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 23 Jun 2017 07:54:37 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 25uZCVs40THf for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 23 Jun 2017 07:54:36 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 49D3725AD8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 23 Jun 2017 07:54:36 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 19F7B4ACD0;\n\tFri, 23 Jun 2017 07:46:44 +0000 (UTC)", "from w541.redhat.com (ovpn-116-200.ams2.redhat.com [10.36.116.200])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 360376C1F7;\n\tFri, 23 Jun 2017 07:46:41 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "delayed 00:07:51 by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]); Fri, 23 Jun 2017 07:46:44 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 19F7B4ACD0", "Authentication-Results": [ "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=kpanic.de", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=none smtp.mailfrom=sassmann@kpanic.de" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mx1.redhat.com 19F7B4ACD0", "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 23 Jun 2017 09:46:24 +0200", "Message-Id": "<20170623074624.32405-1-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH] i40e: handle setting administratively set\n\tMAC address back to zero", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When an administratively set MAC was previously set and should now be\nswitched back to 00:00:00:00:00:00 the pf_set_mac flag did not get\ntoggled back to false.\nAs a result VFs were still treated as if an administratively set MAC was\npresent.\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex ecbe40e..af0ff61 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -2764,7 +2764,6 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)\n \n \tspin_unlock_bh(&vsi->mac_filter_hash_lock);\n \n-\tdev_info(&pf->pdev->dev, \"Setting MAC %pM on VF %d\\n\", mac, vf_id);\n \t/* program mac filter */\n \tif (i40e_sync_vsi_filters(vsi)) {\n \t\tdev_err(&pf->pdev->dev, \"Unable to program ucast filters\\n\");\n@@ -2772,7 +2771,16 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)\n \t\tgoto error_param;\n \t}\n \tether_addr_copy(vf->default_lan_addr.addr, mac);\n-\tvf->pf_set_mac = true;\n+\n+\tif (is_zero_ether_addr(mac)) {\n+\t\tvf->pf_set_mac = false;\n+\t\tdev_info(&pf->pdev->dev, \"Removing MAC on VF %d\\n\", vf_id);\n+\t} else {\n+\t\tvf->pf_set_mac = true;\n+\t\tdev_info(&pf->pdev->dev, \"Setting MAC %pM on VF %d\\n\",\n+\t\t\t mac, vf_id);\n+\t}\n+\n \t/* Force the VF driver stop so it has to reload with new MAC address */\n \ti40e_vc_disable_vf(pf, vf);\n \tdev_info(&pf->pdev->dev, \"Reload the VF driver to make this change effective.\\n\");\n", "prefixes": [] }