Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/779617/?format=api
{ "id": 779617, "url": "http://patchwork.ozlabs.org/api/patches/779617/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1498149872-16623-1-git-send-email-tushar.n.dave@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1498149872-16623-1-git-send-email-tushar.n.dave@oracle.com>", "list_archive_url": null, "date": "2017-06-22T16:44:32", "name": "[next-queue] i40evf: Use le32_to_cpu before evaluating HW desc fields", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "01635da1d94b1967c3d2888efb068a79071ea10d", "submitter": { "id": 68023, "url": "http://patchwork.ozlabs.org/api/people/68023/?format=api", "name": "Tushar Dave", "email": "tushar.n.dave@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1498149872-16623-1-git-send-email-tushar.n.dave@oracle.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/779617/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/779617/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wtnWH3Jqnz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 23 Jun 2017 02:45:15 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 74A762FCED;\n\tThu, 22 Jun 2017 16:45:13 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ke310hMYORsb; Thu, 22 Jun 2017 16:45:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id C96C726BD5;\n\tThu, 22 Jun 2017 16:45:09 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 389C21C0C1A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Jun 2017 16:45:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3140081D1C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Jun 2017 16:45:09 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bXIvCmrQibaB for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Jun 2017 16:45:06 +0000 (UTC)", "from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 60BA0819AC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Jun 2017 16:45:06 +0000 (UTC)", "from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v5MGj3Ks022623\n\t(version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\n\tThu, 22 Jun 2017 16:45:04 GMT", "from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])\n\tby aserv0021.oracle.com (8.13.8/8.14.4) with ESMTP id v5MGj2MN028329\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\n\tThu, 22 Jun 2017 16:45:03 GMT", "from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16])\n\tby userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv5MGj28A001341; Thu, 22 Jun 2017 16:45:02 GMT", "from tndave-linux.us.oracle.com (/10.159.129.153)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 22 Jun 2017 09:45:01 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Tushar Dave <tushar.n.dave@oracle.com>", "To": "jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,\n\tnetdev@vger.kernel.org", "Date": "Thu, 22 Jun 2017 09:44:32 -0700", "Message-Id": "<1498149872-16623-1-git-send-email-tushar.n.dave@oracle.com>", "X-Mailer": "git-send-email 1.9.1", "X-Source-IP": "aserv0021.oracle.com [141.146.126.233]", "Subject": "[Intel-wired-lan] [next-queue PATCH] i40evf: Use le32_to_cpu before\n\tevaluating HW desc fields", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "i40e hardware descriptor fields are in little-endian format. Driver\nmust use le32_to_cpu while evaluating these fields otherwise on\nbig-endian arch we end up evaluating incorrect values, cause errors\nlike:\ni40evf 0000:03:0a.0: Expected response 24 from PF, received 402653184\ni40evf 0000:03:0a.1: Expected response 7 from PF, received 117440512\n\nSigned-off-by: Tushar Dave <tushar.n.dave@oracle.com>\nReviewed-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 7c213a3..93536b9 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1957,8 +1957,8 @@ static void i40evf_adminq_task(struct work_struct *work)\n \t\tcontainer_of(work, struct i40evf_adapter, adminq_task);\n \tstruct i40e_hw *hw = &adapter->hw;\n \tstruct i40e_arq_event_info event;\n-\tstruct virtchnl_msg *v_msg;\n-\ti40e_status ret;\n+\tenum virtchnl_ops v_op;\n+\ti40e_status ret, v_ret;\n \tu32 val, oldval;\n \tu16 pending;\n \n@@ -1970,15 +1970,15 @@ static void i40evf_adminq_task(struct work_struct *work)\n \tif (!event.msg_buf)\n \t\tgoto out;\n \n-\tv_msg = (struct virtchnl_msg *)&event.desc;\n \tdo {\n \t\tret = i40evf_clean_arq_element(hw, &event, &pending);\n-\t\tif (ret || !v_msg->v_opcode)\n+\t\tv_op = (enum virtchnl_ops)le32_to_cpu(event.desc.cookie_high);\n+\t\tv_ret = (i40e_status)le32_to_cpu(event.desc.cookie_low);\n+\n+\t\tif (ret || !v_op)\n \t\t\tbreak; /* No event to process or error cleaning ARQ */\n \n-\t\ti40evf_virtchnl_completion(adapter, v_msg->v_opcode,\n-\t\t\t\t\t (i40e_status)v_msg->v_retval,\n-\t\t\t\t\t event.msg_buf,\n+\t\ti40evf_virtchnl_completion(adapter, v_op, v_ret, event.msg_buf,\n \t\t\t\t\t event.msg_len);\n \t\tif (pending != 0)\n \t\t\tmemset(event.msg_buf, 0, I40EVF_MAX_AQ_BUF_SIZE);\n", "prefixes": [ "next-queue" ] }