Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/778532/?format=api
{ "id": 778532, "url": "http://patchwork.ozlabs.org/api/patches/778532/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620221701.46765-5-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170620221701.46765-5-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2017-06-20T22:16:57", "name": "[next,S73-V2,5/9] i40e: fix odd formatting and indent", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5919fa79bdbfe0fcf0b7f787803d13c6e6cc950d", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620221701.46765-5-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/778532/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/778532/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wshzJ6tYmz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 21 Jun 2017 08:17:16 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8498C82305;\n\tTue, 20 Jun 2017 22:17:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id A0G963cLob0w; Tue, 20 Jun 2017 22:17:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 619A5829D2;\n\tTue, 20 Jun 2017 22:17:13 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id EFD711BFE27\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 40CE9243DF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:05 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5YzUgdz8jTDu for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:01 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 849CF302B7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:01 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Jun 2017 15:17:05 -0700", "from kgaurav1-mobl.amr.corp.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([10.254.77.211])\n\tby orsmga001.jf.intel.com with ESMTP; 20 Jun 2017 15:17:05 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.39,366,1493708400\"; d=\"scan'208\";\n\ta=\"1143227615\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 20 Jun 2017 15:16:57 -0700", "Message-Id": "<20170620221701.46765-5-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.12.2", "In-Reply-To": "<20170620221701.46765-1-jeffrey.t.kirsher@intel.com>", "References": "<20170620221701.46765-1-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S73-V2 5/9] i40e: fix odd formatting\n\tand indent", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe compiler warned on an oddly indented bit of code, and when\ninvestigating that, noted that the functions themselves had\nan odd flow. The if condition was checked, and would exclude\na call to AQ, but then the aq_ret would be checked unconditionally\nwhich just looks really weird, and is likely to cause objections.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 18 ++++++++----------\n 1 file changed, 8 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex ecbe40e..e81cf4d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1741,16 +1741,14 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \t\t\t\t\t\t\t NULL);\n \t} else if (i40e_getnum_vf_vsi_vlan_filters(vsi)) {\n \t\thash_for_each(vsi->mac_filter_hash, bkt, f, hlist) {\n-\t\t\taq_ret = 0;\n-\t\t\tif (f->vlan >= 0 && f->vlan <= I40E_MAX_VLANID) {\n-\t\t\t\taq_ret =\n-\t\t\t\ti40e_aq_set_vsi_uc_promisc_on_vlan(hw,\n-\t\t\t\t\t\t\t\t vsi->seid,\n-\t\t\t\t\t\t\t\t alluni,\n-\t\t\t\t\t\t\t\t f->vlan,\n-\t\t\t\t\t\t\t\t NULL);\n-\t\t\t\taq_err = pf->hw.aq.asq_last_status;\n-\t\t\t}\n+\t\t\tif (f->vlan < 0 || f->vlan > I40E_MAX_VLANID)\n+\t\t\t\tcontinue;\n+\t\t\taq_ret = i40e_aq_set_vsi_uc_promisc_on_vlan(hw,\n+\t\t\t\t\t\t\t\t vsi->seid,\n+\t\t\t\t\t\t\t\t alluni,\n+\t\t\t\t\t\t\t\t f->vlan,\n+\t\t\t\t\t\t\t\t NULL);\n+\t\t\taq_err = pf->hw.aq.asq_last_status;\n \t\t\tif (aq_ret)\n \t\t\t\tdev_err(&pf->pdev->dev,\n \t\t\t\t\t\"Could not add VLAN %d to Unicast promiscuous domain err %s aq_err %s\\n\",\n", "prefixes": [ "next", "S73-V2", "5/9" ] }