Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/778529/?format=api
{ "id": 778529, "url": "http://patchwork.ozlabs.org/api/patches/778529/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620221701.46765-3-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170620221701.46765-3-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2017-06-20T22:16:55", "name": "[next,S73-V2,3/9] i40e: Handle admin Q timeout when releasing NVM", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "022dcffa9a71bdad61a03b8125d256a01f42611d", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620221701.46765-3-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/778529/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/778529/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wshzH1Z4jz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 21 Jun 2017 08:17:15 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C42DA829DD;\n\tTue, 20 Jun 2017 22:17:13 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3raeMtCnV8nH; Tue, 20 Jun 2017 22:17:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2F34882811;\n\tTue, 20 Jun 2017 22:17:12 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id ACFC51BFE27\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id F3E34247B6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:02 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FLAiS4E3LRh2 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:01 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3210F24BF2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:01 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Jun 2017 15:17:04 -0700", "from kgaurav1-mobl.amr.corp.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([10.254.77.211])\n\tby orsmga001.jf.intel.com with ESMTP; 20 Jun 2017 15:17:04 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.39,366,1493708400\"; d=\"scan'208\";\n\ta=\"1143227609\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 20 Jun 2017 15:16:55 -0700", "Message-Id": "<20170620221701.46765-3-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.12.2", "In-Reply-To": "<20170620221701.46765-1-jeffrey.t.kirsher@intel.com>", "References": "<20170620221701.46765-1-jeffrey.t.kirsher@intel.com>", "Cc": "Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S73-V2 3/9] i40e: Handle admin Q\n\ttimeout when releasing NVM", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\n\nThere are some rare cases where the release resource call will return an\nadmin Q timeout. In these cases the code needs to try to release the\nresource again until it succeeds or it times out.\n\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_nvm.c | 21 +++++++++++++++++++--\n 1 file changed, 19 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_nvm.c b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\nindex 800bd55..17607a2 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n@@ -134,8 +134,25 @@ i40e_status i40e_acquire_nvm(struct i40e_hw *hw,\n **/\n void i40e_release_nvm(struct i40e_hw *hw)\n {\n-\tif (!hw->nvm.blank_nvm_mode)\n-\t\ti40e_aq_release_resource(hw, I40E_NVM_RESOURCE_ID, 0, NULL);\n+\ti40e_status ret_code = I40E_SUCCESS;\n+\tu32 total_delay = 0;\n+\n+\tif (hw->nvm.blank_nvm_mode)\n+\t\treturn;\n+\n+\tret_code = i40e_aq_release_resource(hw, I40E_NVM_RESOURCE_ID, 0, NULL);\n+\n+\t/* there are some rare cases when trying to release the resource\n+\t * results in an admin Q timeout, so handle them correctly\n+\t */\n+\twhile ((ret_code == I40E_ERR_ADMIN_QUEUE_TIMEOUT) &&\n+\t (total_delay < hw->aq.asq_cmd_timeout)) {\n+\t\tusleep_range(1000, 2000);\n+\t\tret_code = i40e_aq_release_resource(hw,\n+\t\t\t\t\t\t I40E_NVM_RESOURCE_ID,\n+\t\t\t\t\t\t 0, NULL);\n+\t\t\ttotal_delay++;\n+\t}\n }\n \n /**\n", "prefixes": [ "next", "S73-V2", "3/9" ] }