Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/778528/?format=api
{ "id": 778528, "url": "http://patchwork.ozlabs.org/api/patches/778528/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620221701.46765-8-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170620221701.46765-8-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2017-06-20T22:17:00", "name": "[next,S73-V2,8/9] i40e: display correct UDP tunnel type name", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a3f85548ff01f346da5ff13397e44c27048eebe7", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620221701.46765-8-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/778528/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/778528/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wshzG1Pxnz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 21 Jun 2017 08:17:14 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AFB588292C;\n\tTue, 20 Jun 2017 22:17:12 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Dp5WJcC0hJeU; Tue, 20 Jun 2017 22:17:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B1C33826EA;\n\tTue, 20 Jun 2017 22:17:11 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7F5401CE9E6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C469B247B6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:02 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id swwXuaqdpZ5J for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:02 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id D7BE130340\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:01 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Jun 2017 15:17:05 -0700", "from kgaurav1-mobl.amr.corp.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([10.254.77.211])\n\tby orsmga001.jf.intel.com with ESMTP; 20 Jun 2017 15:17:05 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.39,366,1493708400\"; d=\"scan'208\";\n\ta=\"1143227624\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 20 Jun 2017 15:17:00 -0700", "Message-Id": "<20170620221701.46765-8-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.12.2", "In-Reply-To": "<20170620221701.46765-1-jeffrey.t.kirsher@intel.com>", "References": "<20170620221701.46765-1-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S73-V2 8/9] i40e: display correct UDP\n\ttunnel type name", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThe i40e driver attempts to display the UDP tunnel name by doing a check\nagainst the type, where for non-zero types we use \"vxlan\" and for zero\ntype we use \"geneve\". This is not future proof, because if new tunnel\ntypes get added, we'll incorrectly label them. It also depends on the\nvalue of UDP_TUNNEL_TYPE_GENEVE == 0, which is brittle.\n\nInstead, replace this with a function that can return a constant string\ndepending on the type. For now we'll use \"unknown\" for types we don't\nknow about, and we can expand this in the future if new types get added.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 28 ++++++++++++++++++++--------\n 1 file changed, 20 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 1f05ce3..21705d5 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -7520,6 +7520,18 @@ static void i40e_handle_mdd_event(struct i40e_pf *pf)\n \ti40e_flush(hw);\n }\n \n+static const char *i40e_tunnel_name(struct i40e_udp_port_config *port)\n+{\n+\tswitch (port->type) {\n+\tcase UDP_TUNNEL_TYPE_VXLAN:\n+\t\treturn \"vxlan\";\n+\tcase UDP_TUNNEL_TYPE_GENEVE:\n+\t\treturn \"geneve\";\n+\tdefault:\n+\t\treturn \"unknown\";\n+\t}\n+}\n+\n /**\n * i40e_sync_udp_filters - Trigger a sync event for existing UDP filters\n * @pf: board private structure\n@@ -7565,14 +7577,14 @@ static void i40e_sync_udp_filters_subtask(struct i40e_pf *pf)\n \t\t\t\tret = i40e_aq_del_udp_tunnel(hw, i, NULL);\n \n \t\t\tif (ret) {\n-\t\t\t\tdev_dbg(&pf->pdev->dev,\n-\t\t\t\t\t\"%s %s port %d, index %d failed, err %s aq_err %s\\n\",\n-\t\t\t\t\tpf->udp_ports[i].type ? \"vxlan\" : \"geneve\",\n-\t\t\t\t\tport ? \"add\" : \"delete\",\n-\t\t\t\t\tport, i,\n-\t\t\t\t\ti40e_stat_str(&pf->hw, ret),\n-\t\t\t\t\ti40e_aq_str(&pf->hw,\n-\t\t\t\t\t\t pf->hw.aq.asq_last_status));\n+\t\t\t\tdev_info(&pf->pdev->dev,\n+\t\t\t\t\t \"%s %s port %d, index %d failed, err %s aq_err %s\\n\",\n+\t\t\t\t\t i40e_tunnel_name(&pf->udp_ports[i]),\n+\t\t\t\t\t port ? \"add\" : \"delete\",\n+\t\t\t\t\t port, i,\n+\t\t\t\t\t i40e_stat_str(&pf->hw, ret),\n+\t\t\t\t\t i40e_aq_str(&pf->hw,\n+\t\t\t\t\t\t pf->hw.aq.asq_last_status));\n \t\t\t\tpf->udp_ports[i].port = 0;\n \t\t\t}\n \t\t}\n", "prefixes": [ "next", "S73-V2", "8/9" ] }