Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/778527/?format=api
{ "id": 778527, "url": "http://patchwork.ozlabs.org/api/patches/778527/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620221701.46765-7-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170620221701.46765-7-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2017-06-20T22:16:59", "name": "[next,S73-V2,7/9] i40e/i40evf: remove mismatched type warnings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b980897978819f98af189453975e33a7bf5b7e82", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620221701.46765-7-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/778527/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/778527/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wshzD2YZgz9sNS\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 21 Jun 2017 08:17:12 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 797B8825C7;\n\tTue, 20 Jun 2017 22:17:10 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bIP5gAfPl7md; Tue, 20 Jun 2017 22:17:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0D99A82305;\n\tTue, 20 Jun 2017 22:17:09 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 61A081BFE27\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A640C247B6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:02 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EPmZ2p0GaXyP for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:02 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id B669D302E5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:01 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Jun 2017 15:17:05 -0700", "from kgaurav1-mobl.amr.corp.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([10.254.77.211])\n\tby orsmga001.jf.intel.com with ESMTP; 20 Jun 2017 15:17:05 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.39,366,1493708400\"; d=\"scan'208\";\n\ta=\"1143227621\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 20 Jun 2017 15:16:59 -0700", "Message-Id": "<20170620221701.46765-7-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.12.2", "In-Reply-To": "<20170620221701.46765-1-jeffrey.t.kirsher@intel.com>", "References": "<20170620221701.46765-1-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S73-V2 7/9] i40e/i40evf: remove\n\tmismatched type warnings", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nCompiler reported several places where driver compared\nsigned and unsigned types. Cast or change the types to remove\nthe warnings.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 +++---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 6 +++---\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 6 +++---\n drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c | 4 ++--\n 5 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 9692a52..1d29152 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1091,7 +1091,7 @@ static void i40e_get_regs(struct net_device *netdev, struct ethtool_regs *regs,\n \tstruct i40e_pf *pf = np->vsi->back;\n \tstruct i40e_hw *hw = &pf->hw;\n \tu32 *reg_buf = p;\n-\tint i, j, ri;\n+\tunsigned int i, j, ri;\n \tu32 reg;\n \n \t/* Tell ethtool which driver-version-specific regs output we have.\n@@ -1550,9 +1550,9 @@ static void i40e_get_ethtool_stats(struct net_device *netdev,\n \tstruct i40e_ring *tx_ring, *rx_ring;\n \tstruct i40e_vsi *vsi = np->vsi;\n \tstruct i40e_pf *pf = vsi->back;\n+\tunsigned int j;\n \tint i = 0;\n \tchar *p;\n-\tint j;\n \tstruct rtnl_link_stats64 *net_stats = i40e_get_vsi_stats_struct(vsi);\n \tunsigned int start;\n \n@@ -1637,7 +1637,7 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset,\n \tstruct i40e_vsi *vsi = np->vsi;\n \tstruct i40e_pf *pf = vsi->back;\n \tchar *p = (char *)data;\n-\tint i;\n+\tunsigned int i;\n \n \tswitch (stringset) {\n \tcase ETH_SS_TEST:\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex c794e27..1f05ce3 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -4773,7 +4773,7 @@ static void i40e_detect_recover_hung(struct i40e_pf *pf)\n {\n \tstruct net_device *netdev;\n \tstruct i40e_vsi *vsi;\n-\tint i;\n+\tunsigned int i;\n \n \t/* Only for LAN VSI */\n \tvsi = pf->vsi[pf->lan_vsi];\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex c9a1496..d464fce 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -860,7 +860,7 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi,\n \tnetdev_tx_completed_queue(txring_txq(tx_ring),\n \t\t\t\t total_packets, total_bytes);\n \n-#define TX_WAKE_THRESHOLD (DESC_NEEDED * 2)\n+#define TX_WAKE_THRESHOLD ((s16)(DESC_NEEDED * 2))\n \tif (unlikely(total_packets && netif_carrier_ok(tx_ring->netdev) &&\n \t\t (I40E_DESC_UNUSED(tx_ring) >= TX_WAKE_THRESHOLD))) {\n \t\t/* Make sure that anybody stopping the queue after this\n@@ -2063,7 +2063,7 @@ static int i40e_clean_rx_irq(struct i40e_ring *rx_ring, int budget)\n \tu16 cleaned_count = I40E_DESC_UNUSED(rx_ring);\n \tbool failure = false, xdp_xmit = false;\n \n-\twhile (likely(total_rx_packets < budget)) {\n+\twhile (likely(total_rx_packets < (unsigned int)budget)) {\n \t\tstruct i40e_rx_buffer *rx_buffer;\n \t\tunion i40e_rx_desc *rx_desc;\n \t\tstruct xdp_buff xdp;\n@@ -2196,7 +2196,7 @@ static int i40e_clean_rx_irq(struct i40e_ring *rx_ring, int budget)\n \trx_ring->q_vector->rx.total_bytes += total_rx_bytes;\n \n \t/* guarantee a trip back through this routine if there was a failure */\n-\treturn failure ? budget : total_rx_packets;\n+\treturn failure ? budget : (int)total_rx_packets;\n }\n \n static u32 i40e_buildreg_itr(const int type, const u16 itr)\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 12b02e5..d91676c 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -275,7 +275,7 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi,\n \tnetdev_tx_completed_queue(txring_txq(tx_ring),\n \t\t\t\t total_packets, total_bytes);\n \n-#define TX_WAKE_THRESHOLD (DESC_NEEDED * 2)\n+#define TX_WAKE_THRESHOLD ((s16)(DESC_NEEDED * 2))\n \tif (unlikely(total_packets && netif_carrier_ok(tx_ring->netdev) &&\n \t\t (I40E_DESC_UNUSED(tx_ring) >= TX_WAKE_THRESHOLD))) {\n \t\t/* Make sure that anybody stopping the queue after this\n@@ -1299,7 +1299,7 @@ static int i40e_clean_rx_irq(struct i40e_ring *rx_ring, int budget)\n \tu16 cleaned_count = I40E_DESC_UNUSED(rx_ring);\n \tbool failure = false;\n \n-\twhile (likely(total_rx_packets < budget)) {\n+\twhile (likely(total_rx_packets < (unsigned int)budget)) {\n \t\tstruct i40e_rx_buffer *rx_buffer;\n \t\tunion i40e_rx_desc *rx_desc;\n \t\tunsigned int size;\n@@ -1406,7 +1406,7 @@ static int i40e_clean_rx_irq(struct i40e_ring *rx_ring, int budget)\n \trx_ring->q_vector->rx.total_bytes += total_rx_bytes;\n \n \t/* guarantee a trip back through this routine if there was a failure */\n-\treturn failure ? budget : total_rx_packets;\n+\treturn failure ? budget : (int)total_rx_packets;\n }\n \n static u32 i40e_buildreg_itr(const int type, const u16 itr)\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\nindex 838e57c..db79fb3 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n@@ -165,7 +165,7 @@ static void i40evf_get_ethtool_stats(struct net_device *netdev,\n \t\t\t\t struct ethtool_stats *stats, u64 *data)\n {\n \tstruct i40evf_adapter *adapter = netdev_priv(netdev);\n-\tint i, j;\n+\tunsigned int i, j;\n \tchar *p;\n \n \tfor (i = 0; i < I40EVF_GLOBAL_STATS_LEN; i++) {\n@@ -197,7 +197,7 @@ static void i40evf_get_strings(struct net_device *netdev, u32 sset, u8 *data)\n \tint i;\n \n \tif (sset == ETH_SS_STATS) {\n-\t\tfor (i = 0; i < I40EVF_GLOBAL_STATS_LEN; i++) {\n+\t\tfor (i = 0; i < (int)I40EVF_GLOBAL_STATS_LEN; i++) {\n \t\t\tmemcpy(p, i40evf_gstrings_stats[i].stat_string,\n \t\t\t ETH_GSTRING_LEN);\n \t\t\tp += ETH_GSTRING_LEN;\n", "prefixes": [ "next", "S73-V2", "7/9" ] }