Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/778526/?format=api
{ "id": 778526, "url": "http://patchwork.ozlabs.org/api/patches/778526/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620221701.46765-2-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170620221701.46765-2-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2017-06-20T22:16:54", "name": "[next,S73-V2,2/9] i40e: remove WQ_UNBOUND and the task limit of our workqueue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3e959b0cdad3c40bf0181fe7e6b7deb15cdde51f", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620221701.46765-2-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/778526/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/778526/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wshzC40j3z9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 21 Jun 2017 08:17:10 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 943468226F;\n\tTue, 20 Jun 2017 22:17:08 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TDAEewiBTWvy; Tue, 20 Jun 2017 22:17:07 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D85EA81D22;\n\tTue, 20 Jun 2017 22:17:07 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id C64C31BFE27\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:06 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 10A753034B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:02 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5GmpIW1sSpSL for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:01 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 09C02247B6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 22:17:01 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Jun 2017 15:17:04 -0700", "from kgaurav1-mobl.amr.corp.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([10.254.77.211])\n\tby orsmga001.jf.intel.com with ESMTP; 20 Jun 2017 15:17:04 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.39,366,1493708400\"; d=\"scan'208\";\n\ta=\"1143227606\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 20 Jun 2017 15:16:54 -0700", "Message-Id": "<20170620221701.46765-2-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.12.2", "In-Reply-To": "<20170620221701.46765-1-jeffrey.t.kirsher@intel.com>", "References": "<20170620221701.46765-1-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S73-V2 2/9] i40e: remove WQ_UNBOUND\n\tand the task limit of our workqueue", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nDuring certain events such as a CORER, multiple devices will run a work\ntask to handle some cleanup. This can cause issues due to\na single-threaded workqueue which can mean that a device doesn't cleanup\nin time. Prevent this by removing the single-threaded restriction on the\nmodule workqueue. This avoids the need to add more complex yielding\nlogic in our service task routine. This is also similar to what other\ndrivers such as fm10k do.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 4490264..c794e27 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -12180,12 +12180,14 @@ static int __init i40e_init_module(void)\n \t\ti40e_driver_string, i40e_driver_version_str);\n \tpr_info(\"%s: %s\\n\", i40e_driver_name, i40e_copyright);\n \n-\t/* we will see if single thread per module is enough for now,\n-\t * it can't be any worse than using the system workqueue which\n-\t * was already single threaded\n+\t/* There is no need to throttle the number of active tasks because\n+\t * each device limits its own task using a state bit for scheduling\n+\t * the service task, and the device tasks do not interfere with each\n+\t * other, so we don't set a max task limit. We must set WQ_MEM_RECLAIM\n+\t * since we need to be able to guarantee forward progress even under\n+\t * memory pressure.\n \t */\n-\ti40e_wq = alloc_workqueue(\"%s\", WQ_UNBOUND | WQ_MEM_RECLAIM, 1,\n-\t\t\t\t i40e_driver_name);\n+\ti40e_wq = alloc_workqueue(\"%s\", WQ_MEM_RECLAIM, 0, i40e_driver_name);\n \tif (!i40e_wq) {\n \t\tpr_err(\"%s: Failed to create workqueue\\n\", i40e_driver_name);\n \t\treturn -ENOMEM;\n", "prefixes": [ "next", "S73-V2", "2/9" ] }