Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/778495/?format=api
{ "id": 778495, "url": "http://patchwork.ozlabs.org/api/patches/778495/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620212234.GA10957@embeddedgus/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170620212234.GA10957@embeddedgus>", "list_archive_url": null, "date": "2017-06-20T21:22:34", "name": "net: intel: e1000e: add check on e1e_wphy() return value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5f80b106496cba1090de1d4d19376645d47a7d50", "submitter": { "id": 71553, "url": "http://patchwork.ozlabs.org/api/people/71553/?format=api", "name": "Gustavo A. R. Silva", "email": "garsilva@embeddedor.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170620212234.GA10957@embeddedgus/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/778495/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/778495/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wsgmK37XBz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 21 Jun 2017 07:22:41 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EEEA5881EE;\n\tTue, 20 Jun 2017 21:22:39 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bjUhdCmhOxlm; Tue, 20 Jun 2017 21:22:39 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1B47B86C92;\n\tTue, 20 Jun 2017 21:22:39 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 314FD1BFC6F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 21:22:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 28FC0856E3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 21:22:38 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HLtuk2GlZ8pv for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 21:22:36 +0000 (UTC)", "from gateway34.websitewelcome.com (gateway34.websitewelcome.com\n\t[192.185.149.105])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id AF9678566A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 21:22:36 +0000 (UTC)", "from cm13.websitewelcome.com (cm13.websitewelcome.com\n\t[100.42.49.6])\n\tby gateway34.websitewelcome.com (Postfix) with ESMTP id CAF662034E5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Jun 2017 16:22:35 -0500 (CDT)", "from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP\n\tid NQeYdOd6crCyUNQeYdmxlO; Tue, 20 Jun 2017 16:25:38 -0500", "from [189.152.192.143] (port=42172 helo=embeddedgus)\n\tby gator4166.hostgator.com with esmtpa (Exim 4.87)\n\t(envelope-from <garsilva@embeddedor.com>)\n\tid 1dNQbb-001EeZ-GR; Tue, 20 Jun 2017 16:22:35 -0500" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "Date": "Tue, 20 Jun 2017 16:22:34 -0500", "From": "\"Gustavo A. R. Silva\" <garsilva@embeddedor.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Message-ID": "<20170620212234.GA10957@embeddedgus>", "MIME-Version": "1.0", "Content-Disposition": "inline", "In-Reply-To": "<20170518172223.Horde.5kLLwxMJWThQKv0bAxTsk4D@gator4166.hostgator.com>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-AntiAbuse": [ "This header was added to track abuse,\n\tplease include it with any abuse report", "Primary Hostname - gator4166.hostgator.com", "Original Domain - lists.osuosl.org", "Originator/Caller UID/GID - [47 12] / [47 12]", "Sender Address Domain - embeddedor.com" ], "X-BWhitelist": "no", "X-Source-IP": "189.152.192.143", "X-Exim-ID": "1dNQbb-001EeZ-GR", "X-Source": "", "X-Source-Args": "", "X-Source-Dir": "", "X-Source-Sender": "(embeddedgus) [189.152.192.143]:42172", "X-Source-Auth": "garsilva@embeddedor.com", "X-Email-Count": "2", "X-Source-Cap": "Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org,\n\t\"Gustavo A. R. Silva\" <garsilva@embeddedor.com>", "Subject": "[Intel-wired-lan] [PATCH] net: intel: e1000e: add check on\n\te1e_wphy() return value", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Check return value from call to e1e_wphy(). This value is being\nchecked during previous calls to function e1e_wphy() and it seems\na check was missing here.\n\nAddresses-Coverity-ID: 1226905\nSigned-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>\n---\n drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c\nindex 68ea8b4..d6d4ed7 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c\n@@ -2437,6 +2437,8 @@ static s32 e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw)\n \t\tif (hw->phy.revision < 2) {\n \t\t\te1000e_phy_sw_reset(hw);\n \t\t\tret_val = e1e_wphy(hw, MII_BMCR, 0x3140);\n+\t\t\tif (ret_val)\n+\t\t\t\treturn ret_val;\n \t\t}\n \t}\n \n", "prefixes": [] }