Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/777977/?format=api
{ "id": 777977, "url": "http://patchwork.ozlabs.org/api/patches/777977/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170619203043.120598-1-cspradlin@google.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170619203043.120598-1-cspradlin@google.com>", "list_archive_url": null, "date": "2017-06-19T20:30:43", "name": "igb: protect TX timestamping from API misuse", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6006b47b1a4381b9308e14682aee9cabfc315e18", "submitter": { "id": 71812, "url": "http://patchwork.ozlabs.org/api/people/71812/?format=api", "name": "Cliff Spradlin", "email": "cspradlin@google.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170619203043.120598-1-cspradlin@google.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/777977/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/777977/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ws3BQ2fhpz9s75\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 20 Jun 2017 06:54:38 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AA4802F732;\n\tMon, 19 Jun 2017 20:54:36 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vmkLCObaPcI3; Mon, 19 Jun 2017 20:54:36 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 058D22E23E;\n\tMon, 19 Jun 2017 20:54:36 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id E48A81C1677\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Jun 2017 20:54:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D69778550D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Jun 2017 20:54:33 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XaZjJ9D3K1CD for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Jun 2017 20:54:33 +0000 (UTC)", "from mail-ot0-f202.google.com (mail-ot0-f202.google.com\n\t[74.125.82.202])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 5130283623\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Jun 2017 20:54:33 +0000 (UTC)", "by mail-ot0-f202.google.com with SMTP id s7so3215872otb.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Jun 2017 13:54:33 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"LUNHB5HA\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:18:31 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; h=mime-version:date:message-id:subject:from:to;\n\tbh=sLMNN2NgA59enNxd9Scxtc6A7J9E7eIoR0xTQR8UHgg=;\n\tb=LUNHB5HAf26CQ0z5qMpRhT8Eu3fI/rwlb22vfDul8Dk3PvFpGnyDWw0gsWvw2O2iPa\n\tkJhOYFIExmpE6VrdzLYEN2pyMUJBGCO17KJndBqiqI/Ktz9Ro+Tq0SzI/p5dC1eJRh7m\n\tlvjuPCPpdAQD2mhrMLc5xnO/Lrebd/FKNzDHWYA8NHen+nA9BzU7tObOqvs91a9wU7ar\n\t5kPUsdxwrgkhaicKkdF01F5bNXKASaeRv23XZiLhzL4aTOhM0rEpWmwfBZS96TXi2fh1\n\tq4CjQ8YtEA4IjkcTdtDU75pDkAcuodvXKKVdAAhQHKUUsiS4vh7efD2i7Ed1gGJt9mSU\n\tUzug==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:date:message-id:subject:from:to;\n\tbh=sLMNN2NgA59enNxd9Scxtc6A7J9E7eIoR0xTQR8UHgg=;\n\tb=sDdxoLjMFWLO5aFg6dceI0uCENLM4b3S15Dip85iXoBgJyyhPonIVG+HG/fJY+J4GZ\n\tbuncverM3Wcrmc43ENEjFP04kLNthqpYz4EqMKx0CV0xWiiCmNdpp2OTotK/wlTOv3S7\n\tFziRWCZAo9imAP4WdDzh2FXoBbLz+XjCo9AAg5nFoXlTDnoFPYgRxyx50HDXbYUFMi48\n\taBgY1m2mquVPiCkg8OeHISIHdYwSoPruGeV4HFr6Oh9Wrd/KqwePJYlkPqbr9xDFgfEJ\n\ti27qPJMFuGLDcUYgCKXj8i/cB7quLuu1uVWeuMzPwPlyhQHrCmJOdWpfIgKgdBnWEe8k\n\t+2Vw==", "X-Gm-Message-State": "AKS2vOzWRnTKnW6oyBl71gmf4uqKRNpx6HykRuY+yH6Zz3clp0j/y2cy\n\tjX8QPPMXpF+hdKHyG0Cap6fR825tBLV20VDQU+w233AXSrFOcLfoWy38gA8XsOat2vrwgGmY7UT\n\tGZa65xzAeY2WKDU0+S9ZbrKRdnk+OO09rDnnRMRpLkwtaM3qsJOl+HJ0SDuoxdpOmoGjy+uQGRA\n\t==", "MIME-Version": "1.0", "X-Received": "by 10.157.58.73 with SMTP id j67mr14174212otc.8.1497904246611;\n\tMon, 19 Jun 2017 13:30:46 -0700 (PDT)", "Date": "Mon, 19 Jun 2017 13:30:43 -0700", "Message-Id": "<20170619203043.120598-1-cspradlin@google.com>", "X-Mailer": "git-send-email 2.13.1.518.g3df882009-goog", "From": "Cliff Spradlin <cspradlin@google.com>", "To": "intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH] igb: protect TX timestamping from API\n\tmisuse", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "HW timestamping can only be requested for a packet if the NIC is first\nsetup via ioctl(SIOCSHWTSTAMP). If this step was skipped, then the igb\ndriver still allowed TX packets to request HW timestamping. In this\nsituation, the _IGB_PTP_TX_IN_PROGRESS flag was set and would never\nclear. This prevented any future HW timestamping requests to succeed.\n\nFix this by checking that the NIC is configured for HW TX timestamping\nbefore accepting a HW TX timestamping request.\n\nSigned-off-by: Cliff Spradlin <cspradlin@google.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 63b035454cd0..4077a09fd4c2 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -5388,7 +5388,8 @@ netdev_tx_t igb_xmit_frame_ring(struct sk_buff *skb,\n \tif (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP)) {\n \t\tstruct igb_adapter *adapter = netdev_priv(tx_ring->netdev);\n \n-\t\tif (!test_and_set_bit_lock(__IGB_PTP_TX_IN_PROGRESS,\n+\t\tif (adapter->tstamp_config.tx_type & HWTSTAMP_TX_ON &&\n+\t\t !test_and_set_bit_lock(__IGB_PTP_TX_IN_PROGRESS,\n \t\t\t\t\t &adapter->state)) {\n \t\t\tskb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;\n \t\t\ttx_flags |= IGB_TX_FLAGS_TSTAMP;\n", "prefixes": [] }