Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/776058/?format=api
{ "id": 776058, "url": "http://patchwork.ozlabs.org/api/patches/776058/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170615023826.GA8136@embeddedgus/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170615023826.GA8136@embeddedgus>", "list_archive_url": null, "date": "2017-06-15T02:38:26", "name": "intel: i40e: virtchnl: fix incorrect variable assignment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "da64753be8885cdb9dab6dd8687448deba03fc81", "submitter": { "id": 71553, "url": "http://patchwork.ozlabs.org/api/people/71553/?format=api", "name": "Gustavo A. R. Silva", "email": "garsilva@embeddedor.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170615023826.GA8136@embeddedgus/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/776058/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/776058/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wp73c1Tmrz9s72\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 15 Jun 2017 12:38:35 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AEBDE8821C;\n\tThu, 15 Jun 2017 02:38:33 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id g7c0NzuivP3f; Thu, 15 Jun 2017 02:38:33 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 145D18755D;\n\tThu, 15 Jun 2017 02:38:33 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id D09811C26FE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Jun 2017 02:38:30 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C3E1487E43\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Jun 2017 02:38:30 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BJmT55O9QxLU for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Jun 2017 02:38:28 +0000 (UTC)", "from gateway32.websitewelcome.com (gateway32.websitewelcome.com\n\t[192.185.145.189])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 3F3578755D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Jun 2017 02:38:28 +0000 (UTC)", "from cm17.websitewelcome.com (cm17.websitewelcome.com\n\t[100.42.49.20])\n\tby gateway32.websitewelcome.com (Postfix) with ESMTP id 35432AAAA84\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 14 Jun 2017 21:38:27 -0500 (CDT)", "from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP\n\tid LKfjdUs8lL3F9LKfjdM0U4; Wed, 14 Jun 2017 21:38:11 -0500", "from [189.152.189.231] (port=42402 helo=embeddedgus)\n\tby gator4166.hostgator.com with esmtpa (Exim 4.87)\n\t(envelope-from <garsilva@embeddedor.com>)\n\tid 1dLKfy-000CDT-QA; Wed, 14 Jun 2017 21:38:26 -0500" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "Date": "Wed, 14 Jun 2017 21:38:26 -0500", "From": "\"Gustavo A. R. Silva\" <garsilva@embeddedor.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Message-ID": "<20170615023826.GA8136@embeddedgus>", "MIME-Version": "1.0", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-AntiAbuse": [ "This header was added to track abuse,\n\tplease include it with any abuse report", "Primary Hostname - gator4166.hostgator.com", "Original Domain - lists.osuosl.org", "Originator/Caller UID/GID - [47 12] / [47 12]", "Sender Address Domain - embeddedor.com" ], "X-BWhitelist": "no", "X-Source-IP": "189.152.189.231", "X-Exim-ID": "1dLKfy-000CDT-QA", "X-Source": "", "X-Source-Args": "", "X-Source-Dir": "", "X-Source-Sender": "(embeddedgus) [189.152.189.231]:42402", "X-Source-Auth": "garsilva@embeddedor.com", "X-Email-Count": "2", "X-Source-Cap": "Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org,\n\t\"Gustavo A. R. Silva\" <garsilva@embeddedor.com>", "Subject": "[Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect\n\tvariable assignment", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Fix incorrect variable assignment.\nBased on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be\nused in this instance is aq_ret instead of ret. Also, variable ret is\nupdated at line 1602 just before return, so assigning a value to this\nvariable in this code block is useless.\n\nAddresses-Coverity-ID: 1397693\nSigned-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 6bee254..fb1f018 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1567,7 +1567,7 @@ static int i40e_vc_get_vf_resources_msg(struct i40e_vf *vf, u8 *msg)\n \t\t\tdev_err(&pf->pdev->dev,\n \t\t\t\t\"VF %d requested polling mode: this feature is supported only when the device is running in single function per port (SFP) mode\\n\",\n \t\t\t\t vf->vf_id);\n-\t\t\tret = I40E_ERR_PARAM;\n+\t\t\taq_ret = I40E_ERR_PARAM;\n \t\t\tgoto err;\n \t\t}\n \t\tvfres->vf_offload_flags |= VIRTCHNL_VF_OFFLOAD_RX_POLLING;\n", "prefixes": [] }