Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/772709/?format=api
{ "id": 772709, "url": "http://patchwork.ozlabs.org/api/patches/772709/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170607213621.18256-2-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170607213621.18256-2-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2017-06-07T21:36:18", "name": "[2/5] ixgbe: Enable LASI interrupts for X552 devices", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "34dd48dfe4b35c33fb873b105dbe765060fbbd39", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170607213621.18256-2-anthony.l.nguyen@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/772709/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/772709/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wjhlz2Dcgz9s8N\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 8 Jun 2017 07:39:43 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BDEC72680A;\n\tWed, 7 Jun 2017 21:39:41 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RB9JFVq66S-t; Wed, 7 Jun 2017 21:39:38 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E811426371;\n\tWed, 7 Jun 2017 21:39:38 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 126B21C3EC8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 21:39:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 067DD82110\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 21:39:35 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BjUY2B45qKVG for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 21:39:33 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 5F5748218B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 21:39:33 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Jun 2017 14:39:32 -0700", "from anguy11-linux.jf.intel.com ([134.134.145.139])\n\tby orsmga004.jf.intel.com with ESMTP; 07 Jun 2017 14:39:32 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.39,311,1493708400\"; d=\"scan'208\";a=\"95714300\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 7 Jun 2017 14:36:18 -0700", "Message-Id": "<20170607213621.18256-2-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170607213621.18256-1-anthony.l.nguyen@intel.com>", "References": "<20170607213621.18256-1-anthony.l.nguyen@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 2/5] ixgbe: Enable LASI interrupts for\n\tX552 devices", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Enable LASI interrupts on X552 devices in order to receive notifications of\nlink configurations of the external PHY and support the configuration of\nthe internal iXFI link since iXFI does not support auto-negotiation. This\nis not required for X553 devices; add a check to avoid enabling LASI\ninterrupts for X553 devices.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 31 +++++++++++++++++++--------\n 1 file changed, 22 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex b90d676..a1bf67b 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -2404,17 +2404,30 @@ static s32 ixgbe_enable_lasi_ext_t_x550em(struct ixgbe_hw *hw)\n \tstatus = ixgbe_get_lasi_ext_t_x550em(hw, &lsc);\n \n \t/* Enable link status change alarm */\n-\tstatus = hw->phy.ops.read_reg(hw, IXGBE_MDIO_PMA_TX_VEN_LASI_INT_MASK,\n-\t\t\t\t MDIO_MMD_AN, ®);\n-\tif (status)\n-\t\treturn status;\n \n-\treg |= IXGBE_MDIO_PMA_TX_VEN_LASI_INT_EN;\n+\t/* Enable the LASI interrupts on X552 devices to receive notifications\n+\t * of the link configurations of the external PHY and correspondingly\n+\t * support the configuration of the internal iXFI link, since iXFI does\n+\t * not support auto-negotiation. This is not required for X553 devices\n+\t * having KR support, which performs auto-negotiations and which is used\n+\t * as the internal link to the external PHY. Hence adding a check here\n+\t * to avoid enabling LASI interrupts for X553 devices.\n+\t */\n+\tif (hw->mac.type != ixgbe_mac_x550em_a) {\n+\t\tstatus = hw->phy.ops.read_reg(hw,\n+\t\t\t\t\t IXGBE_MDIO_PMA_TX_VEN_LASI_INT_MASK,\n+\t\t\t\t\t MDIO_MMD_AN, ®);\n+\t\tif (status)\n+\t\t\treturn status;\n+\n+\t\treg |= IXGBE_MDIO_PMA_TX_VEN_LASI_INT_EN;\n \n-\tstatus = hw->phy.ops.write_reg(hw, IXGBE_MDIO_PMA_TX_VEN_LASI_INT_MASK,\n-\t\t\t\t MDIO_MMD_AN, reg);\n-\tif (status)\n-\t\treturn status;\n+\t\tstatus = hw->phy.ops.write_reg(hw,\n+\t\t\t\t\t IXGBE_MDIO_PMA_TX_VEN_LASI_INT_MASK,\n+\t\t\t\t\t MDIO_MMD_AN, reg);\n+\t\tif (status)\n+\t\t\treturn status;\n+\t}\n \n \t/* Enable high temperature failure and global fault alarms */\n \tstatus = hw->phy.ops.read_reg(hw, IXGBE_MDIO_GLOBAL_INT_MASK,\n", "prefixes": [ "2/5" ] }