Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/772705/?format=api
{ "id": 772705, "url": "http://patchwork.ozlabs.org/api/patches/772705/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170607213621.18256-1-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170607213621.18256-1-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2017-06-07T21:36:17", "name": "[1/5] ixgbe: Ensure MAC filter was added before setting MACVLAN", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "40cf1e448f515261e57274872aca207d468d0999", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170607213621.18256-1-anthony.l.nguyen@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/772705/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/772705/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wjhlv55THz9sCX\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 8 Jun 2017 07:39:39 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 107F32C892;\n\tWed, 7 Jun 2017 21:39:38 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aV2d167H03zR; Wed, 7 Jun 2017 21:39:35 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6846E2624E;\n\tWed, 7 Jun 2017 21:39:35 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1C5C41C0DFA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 21:39:34 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0E660822BC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 21:39:34 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aYA3iZGkO1mp for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 21:39:33 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 383EA82110\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 21:39:33 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Jun 2017 14:39:32 -0700", "from anguy11-linux.jf.intel.com ([134.134.145.139])\n\tby orsmga004.jf.intel.com with ESMTP; 07 Jun 2017 14:39:32 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.39,311,1493708400\"; d=\"scan'208\";a=\"95714299\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 7 Jun 2017 14:36:17 -0700", "Message-Id": "<20170607213621.18256-1-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.9.3", "Subject": "[Intel-wired-lan] [PATCH 1/5] ixgbe: Ensure MAC filter was added\n\tbefore setting MACVLAN", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch adds a check to ensure that adding the MAC filter was\nsuccessful before setting the MACVLAN. If it was unsuccessful, propagate\nthe error.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\nindex b77f992..df43c59 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n@@ -685,6 +685,7 @@ static int ixgbe_set_vf_macvlan(struct ixgbe_adapter *adapter,\n {\n \tstruct list_head *pos;\n \tstruct vf_macvlans *entry;\n+\ts32 retval = 0;\n \n \tif (index <= 1) {\n \t\tlist_for_each(pos, &adapter->vf_mvs.l) {\n@@ -725,14 +726,15 @@ static int ixgbe_set_vf_macvlan(struct ixgbe_adapter *adapter,\n \tif (!entry || !entry->free)\n \t\treturn -ENOSPC;\n \n-\tentry->free = false;\n-\tentry->is_macvlan = true;\n-\tentry->vf = vf;\n-\tmemcpy(entry->vf_macvlan, mac_addr, ETH_ALEN);\n-\n-\tixgbe_add_mac_filter(adapter, mac_addr, vf);\n+\tretval = ixgbe_add_mac_filter(adapter, mac_addr, vf);\n+\tif (retval >= 0) {\n+\t\tentry->free = false;\n+\t\tentry->is_macvlan = true;\n+\t\tentry->vf = vf;\n+\t\tmemcpy(entry->vf_macvlan, mac_addr, ETH_ALEN);\n+\t}\n \n-\treturn 0;\n+\treturn retval;\n }\n \n static inline void ixgbe_vf_reset_event(struct ixgbe_adapter *adapter, u32 vf)\n", "prefixes": [ "1/5" ] }