Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/772615/?format=api
{ "id": 772615, "url": "http://patchwork.ozlabs.org/api/patches/772615/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170607094313.32060-10-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170607094313.32060-10-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-06-07T09:43:10", "name": "[next,S72-V3,10/13] i40e: fix disabling overflow promiscuous mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "915f1ae6af3b602bc5ca4553827cdad1c3f2ba69", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170607094313.32060-10-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/772615/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/772615/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wjbbH6NTqz9sNP\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 8 Jun 2017 03:46:51 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1565887A70;\n\tWed, 7 Jun 2017 17:46:50 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mKz4vvUzBsQZ; Wed, 7 Jun 2017 17:46:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4DA0A87A20;\n\tWed, 7 Jun 2017 17:46:47 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id B90301C3EB9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 17:46:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B3C4989493\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 17:46:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2yLNKxQby6qm for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 17:46:44 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 282488948C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 17:46:44 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Jun 2017 10:46:41 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga004.jf.intel.com with ESMTP; 07 Jun 2017 10:46:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.39,311,1493708400\"; d=\"scan'208\";a=\"95650694\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 7 Jun 2017 05:43:10 -0400", "Message-Id": "<20170607094313.32060-10-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170607094313.32060-1-alice.michael@intel.com>", "References": "<20170607094313.32060-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S72-V3 10/13] i40e: fix disabling\n\toverflow promiscuous mode", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alan Brady <alan.brady@intel.com>\n\nThere exists a bug in which the driver does not correctly exit overflow\npromiscuous mode. This can occur if \"too many\" mac filters are added,\nputting the driver into overflow promiscuous mode, and the filters are\nthen removed. When the failed filters are removed, the driver reports\nexiting overflow promiscuous mode which is correct, however traffic\ncontinues to be received as if in promiscuous mode still.\n\nThe bug occurs because the conditional for toggling promiscuous mode was\nset to only execute when promiscuous mode was enabled and not when it\nwas disabled as well. This patch fixes the conditional to correctly\nexecute when promiscuous mode is toggled and not just enabled. Without\nthis patch, the driver is unable to correctly exit overflow promiscuous\nmode.\n\nSigned-off-by: Alan Brady <alan.brady@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 5fd4d2f..b7b1f18 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -2281,9 +2281,8 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t\t i40e_aq_str(hw, hw->aq.asq_last_status));\n \t\t}\n \t}\n-\tif ((changed_flags & IFF_PROMISC) ||\n-\t (promisc_changed &&\n-\t test_bit(__I40E_VSI_OVERFLOW_PROMISC, vsi->state))) {\n+\n+\tif ((changed_flags & IFF_PROMISC) || promisc_changed) {\n \t\tbool cur_promisc;\n \n \t\tcur_promisc = (!!(vsi->current_netdev_flags & IFF_PROMISC) ||\n", "prefixes": [ "next", "S72-V3", "10/13" ] }