Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/772614/?format=api
{ "id": 772614, "url": "http://patchwork.ozlabs.org/api/patches/772614/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170607094313.32060-11-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170607094313.32060-11-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-06-07T09:43:11", "name": "[next,S72-V3,11/13] i40e: clear only cause_ena bit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "35c4d222385fcafeca206dd63b0622059fd3c78b", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170607094313.32060-11-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/772614/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/772614/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wjbbH3CBCz9sDG\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 8 Jun 2017 03:46:51 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E1AC787A0A;\n\tWed, 7 Jun 2017 17:46:49 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2eZSHj3pV5k2; Wed, 7 Jun 2017 17:46:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DA86387A3A;\n\tWed, 7 Jun 2017 17:46:47 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id EC76F1C3EBB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 17:46:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E649D8948C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 17:46:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EggYfC29wV6h for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 17:46:44 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 4CF7089476\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Jun 2017 17:46:44 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Jun 2017 10:46:41 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga004.jf.intel.com with ESMTP; 07 Jun 2017 10:46:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.39,311,1493708400\"; d=\"scan'208\";a=\"95650698\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 7 Jun 2017 05:43:11 -0400", "Message-Id": "<20170607094313.32060-11-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170607094313.32060-1-alice.michael@intel.com>", "References": "<20170607094313.32060-1-alice.michael@intel.com>", "Cc": "Shannon Nelson <shannon.nelson@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S72-V3 11/13] i40e: clear only\n\tcause_ena bit", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nWhen disabling interrupts, we should only be clearing the CAUSE_ENA bit,\nnot clearing the whole register. Clearing the whole register sets the\nNEXTQ_IDX field to 0 instead of 0x7ff which can confuse the Firmware in\nsome reset sequences.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex b7b1f18..581a8ff 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -3588,14 +3588,24 @@ static void i40e_vsi_disable_irq(struct i40e_vsi *vsi)\n \tint base = vsi->base_vector;\n \tint i;\n \n+\t/* disable interrupt causation from each queue */\n \tfor (i = 0; i < vsi->num_queue_pairs; i++) {\n-\t\twr32(hw, I40E_QINT_TQCTL(vsi->tx_rings[i]->reg_idx), 0);\n-\t\twr32(hw, I40E_QINT_RQCTL(vsi->rx_rings[i]->reg_idx), 0);\n+\t\tu32 val;\n+\n+\t\tval = rd32(hw, I40E_QINT_TQCTL(vsi->tx_rings[i]->reg_idx));\n+\t\tval &= ~I40E_QINT_TQCTL_CAUSE_ENA_MASK;\n+\t\twr32(hw, I40E_QINT_TQCTL(vsi->tx_rings[i]->reg_idx), val);\n+\n+\t\tval = rd32(hw, I40E_QINT_RQCTL(vsi->rx_rings[i]->reg_idx));\n+\t\tval &= ~I40E_QINT_RQCTL_CAUSE_ENA_MASK;\n+\t\twr32(hw, I40E_QINT_RQCTL(vsi->rx_rings[i]->reg_idx), val);\n+\n \t\tif (!i40e_enabled_xdp_vsi(vsi))\n \t\t\tcontinue;\n \t\twr32(hw, I40E_QINT_TQCTL(vsi->xdp_rings[i]->reg_idx), 0);\n \t}\n \n+\t/* disable each interrupt */\n \tif (pf->flags & I40E_FLAG_MSIX_ENABLED) {\n \t\tfor (i = vsi->base_vector;\n \t\t i < (vsi->num_q_vectors + vsi->base_vector); i++)\n", "prefixes": [ "next", "S72-V3", "11/13" ] }