Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/772071/?format=api
{ "id": 772071, "url": "http://patchwork.ozlabs.org/api/patches/772071/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170606235407.6478-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170606235407.6478-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2017-06-06T23:54:07", "name": "i40evf: remove redundant null check on key", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "d4875de71fe7cacc69949a6247c49ca4a12ba80f", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170606235407.6478-1-colin.king@canonical.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/772071/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/772071/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wj7nl14Qwz9s7B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 7 Jun 2017 09:54:18 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6512787252;\n\tTue, 6 Jun 2017 23:54:17 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OhxvaOfaR96H; Tue, 6 Jun 2017 23:54:15 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EAF68871DE;\n\tTue, 6 Jun 2017 23:54:15 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 53A681BFE5F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Jun 2017 23:54:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3D83D871DE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Jun 2017 23:54:14 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TfZaCfSZDlrY for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Jun 2017 23:54:13 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 76BE7871B7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Jun 2017 23:54:13 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1dIOIa-0001O7-1i; Tue, 06 Jun 2017 23:54:08 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Wed, 7 Jun 2017 00:54:07 +0100", "Message-Id": "<20170606235407.6478-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.11.0", "MIME-Version": "1.0", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] i40evf: remove redundant null check on key", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nkey has previously been null checked so the subsequent null check\nis redundant as key can never be null at that point, so remove it.\n\nDetected by CoverityScan, CID#1357164 (\"Logically dead code\")\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\nindex 9bb2cc7dd4e4..838e57c6e176 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n@@ -732,9 +732,7 @@ static int i40evf_set_rxfh(struct net_device *netdev, const u32 *indir,\n \tif (!indir)\n \t\treturn 0;\n \n-\tif (key) {\n-\t\tmemcpy(adapter->rss_key, key, adapter->rss_key_size);\n-\t}\n+\tmemcpy(adapter->rss_key, key, adapter->rss_key_size);\n \n \t/* Each 32 bits pointed by 'indir' is stored with a lut entry */\n \tfor (i = 0; i < adapter->rss_lut_size; i++)\n", "prefixes": [] }