Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/771477/?format=api
{ "id": 771477, "url": "http://patchwork.ozlabs.org/api/patches/771477/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/12c75353-174a-d6de-27bc-83cebba68c13@suse.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<12c75353-174a-d6de-27bc-83cebba68c13@suse.com>", "list_archive_url": null, "date": "2017-06-03T22:01:17", "name": "ixgbe: pci_set_drvdata must be called before register_netdev", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "70b6773841cb82c36ecffb99147f37064acbd029", "submitter": { "id": 1833, "url": "http://patchwork.ozlabs.org/api/people/1833/?format=api", "name": "Jeff Mahoney", "email": "jeffm@suse.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/12c75353-174a-d6de-27bc-83cebba68c13@suse.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/771477/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/771477/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3whT5p0BCFz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 6 Jun 2017 07:50:53 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8B3BD30014;\n\tMon, 5 Jun 2017 21:50:52 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qb0M3dpwiNNA; Mon, 5 Jun 2017 21:50:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id CB52B2FFE0;\n\tMon, 5 Jun 2017 21:50:51 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id DA58C1BFA57\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 3 Jun 2017 22:13:57 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BB6432224B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 3 Jun 2017 22:13:57 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id u5R9IWGs6WU8 for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 3 Jun 2017 22:13:55 +0000 (UTC)", "from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 5CAB620198\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 3 Jun 2017 22:13:55 +0000 (UTC)", "from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id 0CEC4AE2E;\n\tSat, 3 Jun 2017 22:01:19 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org", "by amavisd-new at test-mx.suse.de" ], "X-Greylist": "delayed 00:12:33 by SQLgrey-1.7.6", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org", "From": "Jeff Mahoney <jeffm@suse.com>", "Message-ID": "<12c75353-174a-d6de-27bc-83cebba68c13@suse.com>", "Date": "Sat, 3 Jun 2017 18:01:17 -0400", "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)\n\tGecko/20100101 Thunderbird/45.8.0", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Mon, 05 Jun 2017 21:50:50 +0000", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: pci_set_drvdata must be called\n\tbefore register_netdev", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We call pci_set_drvdata immediately after calling register_netdev,\nwhich leaves a window where tasks writing to the sriov_numvfs sysfs\nattribute can sneak in and crash the kernel. register_netdev cleans\nup after itself so placing pci_set_drvdata immediately before it\nshould preserve the intent of commit 0fb6a55cc31f (ixgbe: fix crash\non rmmod after probe fail).\n\nFixes: 0fb6a55cc31f (ixgbe: fix crash on rmmod after probe fail)\nSigned-off-by: Jeff Mahoney <jeffm@suse.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\n \t\thw->mac.ops.disable_tx_laser(hw);", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nb/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex d39cba214320..ec257eeb2ca1 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -10341,12 +10341,11 @@ static int ixgbe_probe(struct pci_dev *pdev,\nconst struct pci_device_id *ent)\n \t\t\t \"hardware.\\n\");\n \t}\n \tstrcpy(netdev->name, \"eth%d\");\n+\tpci_set_drvdata(pdev, adapter);\n \terr = register_netdev(netdev);\n \tif (err)\n \t\tgoto err_register;\n\n-\tpci_set_drvdata(pdev, adapter);\n-\n \t/* power down the optics for 82599 SFP+ fiber */\n \tif (hw->mac.ops.disable_tx_laser)\n", "prefixes": [] }