Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/770018/?format=api
{ "id": 770018, "url": "http://patchwork.ozlabs.org/api/patches/770018/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170601224051.6106-4-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170601224051.6106-4-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2017-06-01T22:40:39", "name": "[03/15] fm10k: avoid possible truncation of q_vector->name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "95942882cb63efbb9de9f5607045a62bfeaa83ab", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170601224051.6106-4-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/770018/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/770018/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wf2Pz2p4sz9sN8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 2 Jun 2017 08:41:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DB3DE30C72;\n\tThu, 1 Jun 2017 22:41:25 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DuW30ZnDTTF5; Thu, 1 Jun 2017 22:41:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id A98D030C80;\n\tThu, 1 Jun 2017 22:41:10 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id D26D31C3EBE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Jun 2017 22:40:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C8EE530C63\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Jun 2017 22:40:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gM2KkMG14lyg for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Jun 2017 22:40:56 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 2D64130C68\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Jun 2017 22:40:56 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Jun 2017 15:40:55 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.35.158])\n\tby fmsmga001.fm.intel.com with ESMTP; 01 Jun 2017 15:40:54 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.39,281,1493708400\"; d=\"scan'208\";\n\ta=\"1155582844\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Thu, 1 Jun 2017 15:40:39 -0700", "Message-Id": "<20170601224051.6106-4-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.13.0.311.g0339965c70d6", "In-Reply-To": "<20170601224051.6106-1-jacob.e.keller@intel.com>", "References": "<20170601224051.6106-1-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 03/15] fm10k: avoid possible truncation of\n\tq_vector->name", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "New versions of GCC since version 7 began warning about possible\ntruncation of calls to snprintf. We can fix this and avoid false\npositives. First, we should pass the full buffer size to snprintf,\nbecause it guarantees a NULL character as part of its passed length, so\npassing len-1 is simply wasting a byte of possible storage.\n\nSecond, if we make the ri and ti variables unsigned, the compiler is\nable to correctly reason that the value never gets larger than 256, so\nit doesn't need to warn about the full space required to print a signed\ninteger.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 3e26d27ad213..80b18f2479b4 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -1544,7 +1544,7 @@ int fm10k_qv_request_irq(struct fm10k_intfc *interface)\n \tstruct net_device *dev = interface->netdev;\n \tstruct fm10k_hw *hw = &interface->hw;\n \tstruct msix_entry *entry;\n-\tint ri = 0, ti = 0;\n+\tunsigned int ri = 0, ti = 0;\n \tint vector, err;\n \n \tentry = &interface->msix_entries[NON_Q_VECTORS(hw)];\n@@ -1554,15 +1554,15 @@ int fm10k_qv_request_irq(struct fm10k_intfc *interface)\n \n \t\t/* name the vector */\n \t\tif (q_vector->tx.count && q_vector->rx.count) {\n-\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name) - 1,\n-\t\t\t\t \"%s-TxRx-%d\", dev->name, ri++);\n+\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name),\n+\t\t\t\t \"%s-TxRx-%u\", dev->name, ri++);\n \t\t\tti++;\n \t\t} else if (q_vector->rx.count) {\n-\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name) - 1,\n-\t\t\t\t \"%s-rx-%d\", dev->name, ri++);\n+\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name),\n+\t\t\t\t \"%s-rx-%u\", dev->name, ri++);\n \t\t} else if (q_vector->tx.count) {\n-\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name) - 1,\n-\t\t\t\t \"%s-tx-%d\", dev->name, ti++);\n+\t\t\tsnprintf(q_vector->name, sizeof(q_vector->name),\n+\t\t\t\t \"%s-tx-%u\", dev->name, ti++);\n \t\t} else {\n \t\t\t/* skip this unused q_vector */\n \t\t\tcontinue;\n", "prefixes": [ "03/15" ] }