Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/770008/?format=api
{ "id": 770008, "url": "http://patchwork.ozlabs.org/api/patches/770008/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170601224051.6106-2-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170601224051.6106-2-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2017-06-01T22:40:37", "name": "[01/15] fm10k: stop spurious link down messages when Tx FIFO is full", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "77a90a5aa08ba9a2ddb6bef5040ea61c460d4e6a", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170601224051.6106-2-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/770008/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/770008/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wf2Pd3bstz9sN8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 2 Jun 2017 08:41:09 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0113730C68;\n\tThu, 1 Jun 2017 22:41:08 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id v3w9f3Xfb+xY; Thu, 1 Jun 2017 22:41:02 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 641FA30C76;\n\tThu, 1 Jun 2017 22:41:00 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4569A1C400B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Jun 2017 22:40:57 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3C10730C6C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Jun 2017 22:40:57 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ChI8+mPIti1a for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Jun 2017 22:40:55 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTPS id B637A30C65\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Jun 2017 22:40:55 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Jun 2017 15:40:54 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.35.158])\n\tby fmsmga001.fm.intel.com with ESMTP; 01 Jun 2017 15:40:54 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.39,281,1493708400\"; d=\"scan'208\";\n\ta=\"1155582838\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Thu, 1 Jun 2017 15:40:37 -0700", "Message-Id": "<20170601224051.6106-2-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.13.0.311.g0339965c70d6", "In-Reply-To": "<20170601224051.6106-1-jacob.e.keller@intel.com>", "References": "<20170601224051.6106-1-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 01/15] fm10k: stop spurious link down\n\tmessages when Tx FIFO is full", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In fm10k_get_host_state_generic, we check the mailbox tx_read() function\nto ensure that the mailbox is still open. This function also checks to\nmake sure we have space to transmit another message. Unfortunately, if\nwe just recently sent a bunch of messages (such as enabling hundreds of\nVLANs on a vF) this can result in a race where the watchdog task thinks\nthe link went down just because we haven't had time to process all these\nmessages yet.\n\nInstead, lets just check whether the mailbox is still open. This ensures\nthat we don't race with the Tx fifo, and we only link down once the\nmailbox is not open.\n\nThis is safe, because if the FIFO fills up and we're unable to send\na message for too long, we'll end up triggering the timeout detection\nwhich results in a reset. Additionally, since we still check to ensure\nthe mailbox state is OPEN, we'll transition to link down whenever the\nmailbox closes as well.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_common.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_common.c b/drivers/net/ethernet/intel/fm10k/fm10k_common.c\nindex 62a6ad9b3eed..736a9f087bc9 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_common.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_common.c\n@@ -1,5 +1,5 @@\n /* Intel(R) Ethernet Switch Host Interface Driver\n- * Copyright(c) 2013 - 2016 Intel Corporation.\n+ * Copyright(c) 2013 - 2017 Intel Corporation.\n *\n * This program is free software; you can redistribute it and/or modify it\n * under the terms and conditions of the GNU General Public License,\n@@ -517,8 +517,8 @@ s32 fm10k_get_host_state_generic(struct fm10k_hw *hw, bool *host_ready)\n \t\tgoto out;\n \t}\n \n-\t/* verify Mailbox is still valid */\n-\tif (!mbx->ops.tx_ready(mbx, FM10K_VFMBX_MSG_MTU))\n+\t/* verify Mailbox is still open */\n+\tif (mbx->state != FM10K_STATE_OPEN)\n \t\tgoto out;\n \n \t/* interface cannot receive traffic without logical ports */\n", "prefixes": [ "01/15" ] }