Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/769323/?format=api
{ "id": 769323, "url": "http://patchwork.ozlabs.org/api/patches/769323/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170531155043.3596-2-jani.nikula@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170531155043.3596-2-jani.nikula@intel.com>", "list_archive_url": null, "date": "2017-05-31T15:50:43", "name": "[v2,1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d44bb945453716e06332f55dddeca943fd448e4a", "submitter": { "id": 64994, "url": "http://patchwork.ozlabs.org/api/people/64994/?format=api", "name": "Jani Nikula", "email": "jani.nikula@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170531155043.3596-2-jani.nikula@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/769323/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/769323/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wdKvG1Lj8z9ryv\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 1 Jun 2017 05:15:54 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AE41E30A14;\n\tWed, 31 May 2017 19:15:52 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id c4qSXX4fdlqQ; Wed, 31 May 2017 19:15:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4369730A34;\n\tWed, 31 May 2017 19:15:47 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id EDEC71C20A4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 May 2017 15:47:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E62B62FA91\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 May 2017 15:47:33 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iqD8gzC1gnx8 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 May 2017 15:47:33 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id E41CD2E7E5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 May 2017 15:47:32 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 May 2017 08:47:32 -0700", "from jnikula-mobl2.fi.intel.com (HELO localhost) ([10.237.72.62])\n\tby FMSMGA003.fm.intel.com with ESMTP; 31 May 2017 08:47:29 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.39,424,1493708400\"; d=\"scan'208\";a=\"863182250\"", "From": "Jani Nikula <jani.nikula@intel.com>", "To": "David Miller <davem@davemloft.net>,\n\tdaniel.vetter@ffwll.ch", "Date": "Wed, 31 May 2017 18:50:43 +0300", "Message-Id": "<20170531155043.3596-2-jani.nikula@intel.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170531155043.3596-1-jani.nikula@intel.com>", "References": "<20170531.110833.1362264472730468352.davem@davemloft.net>\n\t<20170531155043.3596-1-jani.nikula@intel.com>", "Organization": "Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo", "X-Mailman-Approved-At": "Wed, 31 May 2017 19:15:45 +0000", "Cc": "Tvrtko Ursulin <tvrtko.ursulin@intel.com>,\n\tJani Nikula <jani.nikula@intel.com>, netdev@vger.kernel.org,\n\tintel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,\n\tjani.nikula@linux.intel.com, Chris Wilson <chris@chris-wilson.co.uk>, \n\tintel-wired-lan@lists.osuosl.org, dri-devel@lists.freedesktop.org,\n\tDave Ertman <davidx.m.ertman@intel.com>, airlied@gmail.com", "Subject": "[Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if\n\t__e1000_shutdown fails", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Chris Wilson <chris@chris-wilson.co.uk>\n\nAn error during suspend (e100e_pm_suspend),\n\n[ 429.994338] ACPI : EC: event blocked\n[ 429.994633] e1000e: EEE TX LPI TIMER: 00000011\n[ 430.955451] pci_pm_suspend(): e1000e_pm_suspend+0x0/0x30 [e1000e] returns -2\n[ 430.955454] dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2\n[ 430.955458] PM: Device 0000:00:19.0 failed to suspend async: error -2\n[ 430.955581] PM: Some devices failed to suspend, or early wake event detected\n[ 430.957709] ACPI : EC: event unblocked\n\nlead to complete failure:\n\n[ 432.585002] ------------[ cut here ]------------\n[ 432.585013] WARNING: CPU: 3 PID: 8372 at kernel/irq/manage.c:1478 __free_irq+0x9f/0x280\n[ 432.585015] Trying to free already-free IRQ 20\n[ 432.585016] Modules linked in: cdc_ncm usbnet x86_pkg_temp_thermal intel_powerclamp coretemp mii crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hwdep lpc_ich snd_hda_core snd_pcm mei_me mei sdhci_pci sdhci i915 mmc_core e1000e ptp pps_core prime_numbers\n[ 432.585042] CPU: 3 PID: 8372 Comm: kworker/u16:40 Tainted: G U 4.10.0-rc8-CI-Patchwork_3870+ #1\n[ 432.585044] Hardware name: LENOVO 2356GCG/2356GCG, BIOS G7ET31WW (1.13 ) 07/02/2012\n[ 432.585050] Workqueue: events_unbound async_run_entry_fn\n[ 432.585051] Call Trace:\n[ 432.585058] dump_stack+0x67/0x92\n[ 432.585062] __warn+0xc6/0xe0\n[ 432.585065] warn_slowpath_fmt+0x4a/0x50\n[ 432.585070] ? _raw_spin_lock_irqsave+0x49/0x60\n[ 432.585072] __free_irq+0x9f/0x280\n[ 432.585075] free_irq+0x34/0x80\n[ 432.585089] e1000_free_irq+0x65/0x70 [e1000e]\n[ 432.585098] e1000e_pm_freeze+0x7a/0xb0 [e1000e]\n[ 432.585106] e1000e_pm_suspend+0x21/0x30 [e1000e]\n[ 432.585113] pci_pm_suspend+0x71/0x140\n[ 432.585118] dpm_run_callback+0x6f/0x330\n[ 432.585122] ? pci_pm_freeze+0xe0/0xe0\n[ 432.585125] __device_suspend+0xea/0x330\n[ 432.585128] async_suspend+0x1a/0x90\n[ 432.585132] async_run_entry_fn+0x34/0x160\n[ 432.585137] process_one_work+0x1f4/0x6d0\n[ 432.585140] ? process_one_work+0x16e/0x6d0\n[ 432.585143] worker_thread+0x49/0x4a0\n[ 432.585145] kthread+0x107/0x140\n[ 432.585148] ? process_one_work+0x6d0/0x6d0\n[ 432.585150] ? kthread_create_on_node+0x40/0x40\n[ 432.585154] ret_from_fork+0x2e/0x40\n[ 432.585156] ---[ end trace 6712df7f8c4b9124 ]---\n\nThe unwind failures stems from commit 2800209994f8 (\"e1000e: Refactor PM\nflows\"), but it may be a later patch that introduced the non-recoverable\nbehaviour.\n\nFixes: 2800209994f8 (\"e1000e: Refactor PM flows\")\nBugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847\nCc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>\nCc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nCc: Dave Ertman <davidx.m.ertman@intel.com>\nCc: Bruce Allan <bruce.w.allan@intel.com>\nCc: intel-wired-lan@lists.osuosl.org\nCc: netdev@vger.kernel.org\nSigned-off-by: Chris Wilson <chris@chris-wilson.co.uk>\n[Jani: bikeshed repainted]\nSigned-off-by: Jani Nikula <jani.nikula@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex b3679728caac..5cad688be609 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -6630,12 +6630,17 @@ static int e1000e_pm_thaw(struct device *dev)\n static int e1000e_pm_suspend(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n+\tint rc;\n \n \te1000e_flush_lpic(pdev);\n \n \te1000e_pm_freeze(dev);\n \n-\treturn __e1000_shutdown(pdev, false);\n+\trc = __e1000_shutdown(pdev, false);\n+\tif (rc)\n+\t\te1000e_pm_thaw(dev);\n+\n+\treturn rc;\n }\n \n static int e1000e_pm_resume(struct device *dev)\n", "prefixes": [ "v2", "1/1" ] }