Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/768860/?format=api
{ "id": 768860, "url": "http://patchwork.ozlabs.org/api/patches/768860/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1496196731-748-1-git-send-email-baijiaju1990@163.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1496196731-748-1-git-send-email-baijiaju1990@163.com>", "list_archive_url": null, "date": "2017-05-31T02:12:11", "name": "i40e: Fix a sleep-in-atomic bug", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c7962801882afcd24160479f964ff61331b75903", "submitter": { "id": 65398, "url": "http://patchwork.ozlabs.org/api/people/65398/?format=api", "name": "Jia-Ju Bai", "email": "baijiaju1990@163.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1496196731-748-1-git-send-email-baijiaju1990@163.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/768860/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/768860/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wcvTM0G6tz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 31 May 2017 12:25:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8A0AD89B74;\n\tWed, 31 May 2017 02:25:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sqT1pMuuH0k0; Wed, 31 May 2017 02:25:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 25BBB89B5D;\n\tWed, 31 May 2017 02:25:24 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0DD2B1C14F8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 May 2017 02:25:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 02DAB87399\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 May 2017 02:25:22 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ae5vz4DPllya for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 May 2017 02:25:21 +0000 (UTC)", "from m12-17.163.com (m12-17.163.com [220.181.12.17])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BD9A28738D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 May 2017 02:25:20 +0000 (UTC)", "from bai-oslab.tsinghua.edu.cn (unknown [166.111.70.19])\n\tby smtp13 (Coremail) with SMTP id EcCowAAXH1P4JS5ZBgWFHQ--.42304S2;\n\tWed, 31 May 2017 10:10:04 +0800 (CST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=163.com header.i=@163.com header.b=\"TKK1rWoy\";\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:15:08 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:Subject:Date:Message-Id; bh=og94CC1zyiztUTbCxB\n\tNZy3LLbnD4LCoFtsIKHhqrpoA=; b=TKK1rWoy5tYc3cYzizu/Cx13OmcFEWf1vd\n\th8eJZHJbPVBlDyKJolgwqauzLMm29aUsn8GgBOly5MvGTX0uROMjnQw8qZ+ghqV9\n\tr2UvQBo7N3p5YG2zb0czR7cUMmMx1SM170RpIJ7Ax+HbCpagkKQThklgO1N/4VWk\n\t0tySg6uEw=", "From": "Jia-Ju Bai <baijiaju1990@163.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Wed, 31 May 2017 10:12:11 +0800", "Message-Id": "<1496196731-748-1-git-send-email-baijiaju1990@163.com>", "X-Mailer": "git-send-email 1.7.9.5", "X-CM-TRANSID": "EcCowAAXH1P4JS5ZBgWFHQ--.42304S2", "X-Coremail-Antispam": "1Uf129KBjvJXoW7XryfCw18tFy5uFWUAr1DKFg_yoW8JF45p3\n\tyjqa45ur4kXws8W3y7Ja18uFZ5Ww4kK34YganxC3s8uFs8tFs5XF47KFy7C340vrWkGFsx\n\tXr1DZr15Crs8AaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRZYFNUUUUU=", "X-Originating-IP": "[166.111.70.19]", "X-CM-SenderInfo": "xedlyx5dmximizq6il2tof0z/1tbipRvoelUMFBU+PgAAs0", "Cc": "netdev@vger.kernel.org, Jia-Ju Bai <baijiaju1990@163.com>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] i40e: Fix a sleep-in-atomic bug", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The driver may sleep under a spin lock, and the function call path is:\ni40e_ndo_set_vf_port_vlan (acquire the lock by spin_lock_bh)\n i40e_vsi_remove_pvid\n i40e_vlan_stripping_disable\n i40e_aq_update_vsi_params\n i40e_asq_send_command\n mutex_lock --> may sleep\n\nTo fixed it, the spin lock is released before \"i40e_vsi_remove_pvid\", and \nthe lock is acquired again after this function.\n\nSigned-off-by: Jia-Ju Bai <baijiaju1990@163.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 95c23fb..0fb38ca 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -3017,10 +3017,12 @@ int i40e_ndo_set_vf_port_vlan(struct net_device *netdev, int vf_id,\n \t\t\t\t\t VLAN_VID_MASK));\n \t}\n \n+\tspin_unlock_bh(&vsi->mac_filter_hash_lock);\n \tif (vlan_id || qos)\n \t\tret = i40e_vsi_add_pvid(vsi, vlanprio);\n \telse\n \t\ti40e_vsi_remove_pvid(vsi);\n+\tspin_lock_bh(&vsi->mac_filter_hash_lock);\n \n \tif (vlan_id) {\n \t\tdev_info(&pf->pdev->dev, \"Setting VLAN %d, QOS 0x%x on VF %d\\n\",\n", "prefixes": [] }