Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/767633/?format=api
{ "id": 767633, "url": "http://patchwork.ozlabs.org/api/patches/767633/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1495847873-845-1-git-send-email-gangfeng.huang@ni.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1495847873-845-1-git-send-email-gangfeng.huang@ni.com>", "list_archive_url": null, "date": "2017-05-27T01:17:53", "name": "[v2] igb: Fix error of RX network flow classification", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "467a37b0958c9bb199f7c119a11fa4287fcf4832", "submitter": { "id": 67513, "url": "http://patchwork.ozlabs.org/api/people/67513/?format=api", "name": "Gangfeng Huang", "email": "gangfeng.huang@ni.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1495847873-845-1-git-send-email-gangfeng.huang@ni.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/767633/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/767633/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wZQDz5jDvz9s8P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 May 2017 11:21:06 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6901189EFB;\n\tSat, 27 May 2017 01:21:04 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8cIXMtxB6Ark; Sat, 27 May 2017 01:21:01 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C965C89DFF;\n\tSat, 27 May 2017 01:21:01 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9857D1C001E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 27 May 2017 01:21:00 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 776DE246F6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 27 May 2017 01:21:00 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id p275u8DgrfKD for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 27 May 2017 01:20:59 +0000 (UTC)", "from mx0b-00010702.pphosted.com (mx0a-00010702.pphosted.com\n\t[148.163.156.75])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C5A3C2443B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 27 May 2017 01:20:59 +0000 (UTC)", "from pps.filterd (m0098780.ppops.net [127.0.0.1])\n\tby mx0a-00010702.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id\n\tv4R1Kxl4001934 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 May 2017 20:20:59 -0500", "from ni.com (skprod3.natinst.com [130.164.80.24])\n\tby mx0a-00010702.pphosted.com with ESMTP id 2anes5j8w6-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT) for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 May 2017 20:20:59 -0500", "from us-aus-exhub1.ni.corp.natinst.com\n\t(us-aus-exhub1.ni.corp.natinst.com [130.164.68.41])\n\tby us-aus-skprod3.natinst.com (8.16.0.17/8.16.0.17) with ESMTPS id\n\tv4R1KuVZ024909\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 May 2017 20:20:58 -0500", "from us-aus-exhub1.ni.corp.natinst.com (130.164.68.41) by\n\tus-aus-exhub1.ni.corp.natinst.com (130.164.68.41) with Microsoft SMTP\n\tServer (TLS) id 15.0.1156.6; Fri, 26 May 2017 20:18:31 -0500", "from ni.com (130.164.49.7) by us-aus-exhub1.ni.corp.natinst.com\n\t(130.164.68.41) with Microsoft SMTP Server id 15.0.1156.6 via\n\tFrontend Transport; Fri, 26 May 2017 20:18:30 -0500" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Gangfeng <gangfeng.huang@ni.com>", "To": "<intel-wired-lan@lists.osuosl.org>", "Date": "Sat, 27 May 2017 09:17:53 +0800", "Message-ID": "<1495847873-845-1-git-send-email-gangfeng.huang@ni.com>", "X-Mailer": "git-send-email 2.7.2", "MIME-Version": "1.0", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-05-27_01:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_policy_notspam\n\tpolicy=outbound_policy score=30\n\tpriorityscore=1501 malwarescore=0 suspectscore=13 phishscore=0\n\tbulkscore=0\n\tspamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0\n\tadultscore=0\n\tclassifier=spam adjust=30 reason=mlx scancount=1\n\tengine=8.0.1-1703280000\n\tdefinitions=main-1705270025", "Cc": "Gangfeng Huang <gangfeng.huang@ni.com>", "Subject": "[Intel-wired-lan] [PATCH v2] igb: Fix error of RX network flow\n\tclassification", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Gangfeng Huang <gangfeng.huang@ni.com>\n\nAfter add an ethertype filter, if user change the adapter speed several\ntimes, the error \"ethtool -N: etype filters are all used\" is reported by\nigb driver.\n\nIn older patch, function igb_nfc_filter_exit() and igb_nfc_filter_restore()\nis not paried. igb_nfc_filter_restore() exist in igb_up(), but function\nigb_nfc_filter_exit() is exist in __igb_close(). In the process of speed\nchanging, only igb_nfc_filter_restore() is called, it will take a position\nof ethertype bitmap.\n\nReproduce steps:\nStep 1: Add a etype filter by ethtool\n$ethtool -N eth0 flow-type ether proto 0x88F8 action 1\nStep 2: Change the adapter speed to 100M/full duplex\n$ethtool -s eth0 speed 100 duplex full\nStep 3: Change the adapter speed to 1000M/full duplex\nethtool -s eth0 speed 1000 duplex full\nRepeat step2 and step3, then dmesg the system log, you can find the error\nmessage, add new ethtype filter is also failed.\n\nThis fixing is move igb_nfc_filter_exit() from __igb_close() to igb_down()\nto make igb_nfc_filter_restore()/igb_nfc_filter_exit() is paired.\n\nSigned-off-by: Gangfeng <gangfeng.huang@ni.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 64fd230..d834765 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -1791,6 +1791,8 @@ void igb_down(struct igb_adapter *adapter)\n \twr32(E1000_RCTL, rctl & ~E1000_RCTL_EN);\n \t/* flush and sleep below */\n \n+\tigb_nfc_filter_exit(adapter);\n+\n \tnetif_carrier_off(netdev);\n \tnetif_tx_stop_all_queues(netdev);\n \n@@ -3317,8 +3319,6 @@ static int __igb_close(struct net_device *netdev, bool suspending)\n \tigb_down(adapter);\n \tigb_free_irq(adapter);\n \n-\tigb_nfc_filter_exit(adapter);\n-\n \tigb_free_all_tx_resources(adapter);\n \tigb_free_all_rx_resources(adapter);\n \n", "prefixes": [ "v2" ] }