Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/764217/?format=api
{ "id": 764217, "url": "http://patchwork.ozlabs.org/api/patches/764217/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170518234506.32551.44123.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170518234506.32551.44123.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2017-05-18T23:45:06", "name": "[v2] ixgbe: fix incorrect status check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5f8f81df9798137631710f2fe2a4f1e7b6462eca", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170518234506.32551.44123.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/764217/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/764217/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wTSZN4BJ5z9s2s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 19 May 2017 09:48:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 858192681C;\n\tThu, 18 May 2017 23:48:57 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ypIqzhZ4qO-J; Thu, 18 May 2017 23:48:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id AB857261F7;\n\tThu, 18 May 2017 23:48:55 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 562501BFF95\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 May 2017 23:48:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4BCFF261F7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 May 2017 23:48:54 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3AC-5S3XIITn for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 May 2017 23:48:53 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 681EB23F70\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 May 2017 23:48:53 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 May 2017 16:48:52 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.78])\n\tby fmsmga006.fm.intel.com with ESMTP; 18 May 2017 16:48:52 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.38,361,1491289200\"; d=\"scan'208\";a=\"104276619\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 18 May 2017 16:45:06 -0700", "Message-ID": "<20170518234506.32551.44123.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v2] ixgbe: fix incorrect status check", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Check for ret_val instead of !ret_val to allow the rest of\nthe code to execute and configure the speed properly.\n\nv2 - fixed few more cases in ixgbe_setup_mac_link_sfp_n()\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex cb5d363..c729ef0 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -1750,14 +1750,14 @@ static s32 ixgbe_setup_sfi_x550a(struct ixgbe_hw *hw, ixgbe_link_speed *speed)\n \tif (ret_val == IXGBE_ERR_SFP_NOT_PRESENT)\n \t\treturn 0;\n \n-\tif (!ret_val)\n+\tif (ret_val)\n \t\treturn ret_val;\n \n \t/* Configure internal PHY for native SFI based on module type */\n \tret_val = hw->mac.ops.read_iosf_sb_reg(hw,\n \t\t\t\tIXGBE_KRM_PMD_FLX_MASK_ST20(hw->bus.lan_id),\n \t\t\t\tIXGBE_SB_IOSF_TARGET_KR_PHY, ®_phy_int);\n-\tif (!ret_val)\n+\tif (ret_val)\n \t\treturn ret_val;\n \n \treg_phy_int &= IXGBE_KRM_PMD_FLX_MASK_ST20_SFI_10G_DA;\n@@ -1767,7 +1767,7 @@ static s32 ixgbe_setup_sfi_x550a(struct ixgbe_hw *hw, ixgbe_link_speed *speed)\n \tret_val = hw->mac.ops.write_iosf_sb_reg(hw,\n \t\t\t\tIXGBE_KRM_PMD_FLX_MASK_ST20(hw->bus.lan_id),\n \t\t\t\tIXGBE_SB_IOSF_TARGET_KR_PHY, reg_phy_int);\n-\tif (!ret_val)\n+\tif (ret_val)\n \t\treturn ret_val;\n \n \t/* Setup SFI internal link. */\n@@ -1798,7 +1798,7 @@ static s32 ixgbe_setup_sfi_x550a(struct ixgbe_hw *hw, ixgbe_link_speed *speed)\n \tif (ret_val == IXGBE_ERR_SFP_NOT_PRESENT)\n \t\treturn 0;\n \n-\tif (!ret_val)\n+\tif (ret_val)\n \t\treturn ret_val;\n \n \t/* Configure internal PHY for KR/KX. */\n", "prefixes": [ "v2" ] }