Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/763797/?format=api
{ "id": 763797, "url": "http://patchwork.ozlabs.org/api/patches/763797/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170517221751.15538.97694.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170517221751.15538.97694.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2017-05-17T22:17:51", "name": "[3/5] ixgbe: always call setup_mac_link for multispeed fiber", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "70900b0c4b0e731ffea0f89d67ae9f2f5d6786b2", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170517221751.15538.97694.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/763797/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/763797/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wSph96nd8z9s06\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 18 May 2017 08:21:45 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1972A87FCE;\n\tWed, 17 May 2017 22:21:44 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nuqxeFnG09qy; Wed, 17 May 2017 22:21:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E132187FC9;\n\tWed, 17 May 2017 22:21:42 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id C75F11C2092\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 22:21:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C0B0C87FCE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 22:21:40 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Wreml_82nc10 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 22:21:40 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 46DE687FC7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 22:21:40 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 May 2017 15:21:39 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.78])\n\tby fmsmga006.fm.intel.com with ESMTP; 17 May 2017 15:21:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.38,356,1491289200\"; d=\"scan'208\";a=\"103449803\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 17 May 2017 15:17:51 -0700", "Message-ID": "<20170517221751.15538.97694.stgit@localhost6.localdomain6>", "In-Reply-To": "<20170517221424.15538.5968.stgit@localhost6.localdomain6>", "References": "<20170517221424.15538.5968.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 3/5] ixgbe: always call setup_mac_link for\n\tmultispeed fiber", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Remove the logic which would previously skip the link configuration\nin the case where we are already at the requested speed in\nixgbe_setup_mac_link_multispeed_fiber().\n\nBy exiting early we are skipping the link configuration and as such\nthe driver may not always configure the PHY correctly for SFP+.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 18 ------------------\n 1 file changed, 18 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex 3af6127..8a2e8bf8 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -4121,15 +4121,6 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,\n \t\tspeedcnt++;\n \t\thighest_link_speed = IXGBE_LINK_SPEED_10GB_FULL;\n \n-\t\t/* If we already have link at this speed, just jump out */\n-\t\tstatus = hw->mac.ops.check_link(hw, &link_speed, &link_up,\n-\t\t\t\t\t\tfalse);\n-\t\tif (status)\n-\t\t\treturn status;\n-\n-\t\tif (link_speed == IXGBE_LINK_SPEED_10GB_FULL && link_up)\n-\t\t\tgoto out;\n-\n \t\t/* Set the module link speed */\n \t\tswitch (hw->phy.media_type) {\n \t\tcase ixgbe_media_type_fiber:\n@@ -4181,15 +4172,6 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,\n \t\tif (highest_link_speed == IXGBE_LINK_SPEED_UNKNOWN)\n \t\t\thighest_link_speed = IXGBE_LINK_SPEED_1GB_FULL;\n \n-\t\t/* If we already have link at this speed, just jump out */\n-\t\tstatus = hw->mac.ops.check_link(hw, &link_speed, &link_up,\n-\t\t\t\t\t\tfalse);\n-\t\tif (status)\n-\t\t\treturn status;\n-\n-\t\tif (link_speed == IXGBE_LINK_SPEED_1GB_FULL && link_up)\n-\t\t\tgoto out;\n-\n \t\t/* Set the module link speed */\n \t\tswitch (hw->phy.media_type) {\n \t\tcase ixgbe_media_type_fiber:\n", "prefixes": [ "3/5" ] }