Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/763795/?format=api
{ "id": 763795, "url": "http://patchwork.ozlabs.org/api/patches/763795/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170517221741.15538.227.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170517221741.15538.227.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2017-05-17T22:17:41", "name": "[1/5] ixgbe: correct CS4223/7 PHY identification", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ec2b2b88f41e9487e765b51a40c4cf699878f27f", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170517221741.15538.227.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/763795/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/763795/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wSpgy6kz9z9s06\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 18 May 2017 08:21:34 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6FFF387FD5;\n\tWed, 17 May 2017 22:21:33 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0AFfgmyEOk8G; Wed, 17 May 2017 22:21:32 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0B1E987FD1;\n\tWed, 17 May 2017 22:21:32 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id D66731C2092\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 22:21:30 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C71EF88925\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 22:21:30 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ebZMZnUd2ffP for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 22:21:30 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 1C63281EBD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 22:21:30 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 May 2017 15:21:29 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.78])\n\tby orsmga005.jf.intel.com with ESMTP; 17 May 2017 15:21:29 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.38,356,1491289200\"; d=\"scan'208\";a=\"101975199\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 17 May 2017 15:17:41 -0700", "Message-ID": "<20170517221741.15538.227.stgit@localhost6.localdomain6>", "In-Reply-To": "<20170517221424.15538.5968.stgit@localhost6.localdomain6>", "References": "<20170517221424.15538.5968.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 1/5] ixgbe: correct CS4223/7 PHY\n\tidentification", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Previous method was unreliable. Use a different register to\ndiferentiate between the SKUs.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 5 +++--\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 8 ++++----\n 2 files changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h\nindex 5aa2c3c..b0cac96 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h\n@@ -84,8 +84,9 @@\n #define IXGBE_CS4227_GLOBAL_ID_LSB\t\t0\n #define IXGBE_CS4227_GLOBAL_ID_MSB\t\t1\n #define IXGBE_CS4227_SCRATCH\t\t\t2\n-#define IXGBE_CS4223_PHY_ID\t\t\t0x7003\t/* Quad port */\n-#define IXGBE_CS4227_PHY_ID\t\t\t0x3003\t/* Dual port */\n+#define IXGBE_CS4227_EFUSE_PDF_SKU\t\t0x19F\n+#define IXGBE_CS4223_SKU_ID\t\t\t0x0010 /* Quad port */\n+#define IXGBE_CS4227_SKU_ID\t\t\t0x0014 /* Dual port */\n #define IXGBE_CS4227_RESET_PENDING\t\t0x1357\n #define IXGBE_CS4227_RESET_COMPLETE\t\t0x5AA5\n #define IXGBE_CS4227_RETRIES\t\t\t15\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex b8d9097..870f9e1 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -1807,16 +1807,16 @@ static s32 ixgbe_setup_sfi_x550a(struct ixgbe_hw *hw, ixgbe_link_speed *speed)\n \tif (hw->phy.mdio.prtad == MDIO_PRTAD_NONE)\n \t\treturn IXGBE_ERR_PHY_ADDR_INVALID;\n \n-\t/* Get external PHY device id */\n-\tret_val = hw->phy.ops.read_reg(hw, IXGBE_CS4227_GLOBAL_ID_MSB,\n-\t\t\t\t IXGBE_MDIO_ZERO_DEV_TYPE, ®_phy_ext);\n+\t/* Get external PHY SKU id */\n+\tret_val = hw->phy.ops.read_reg(hw, IXGBE_CS4227_EFUSE_PDF_SKU,\n+\t\t\t\t IXGBE_MDIO_ZERO_DEV_TYPE, ®_phy_ext);\n \tif (ret_val)\n \t\treturn ret_val;\n \n \t/* When configuring quad port CS4223, the MAC instance is part\n \t * of the slice offset.\n \t */\n-\tif (reg_phy_ext == IXGBE_CS4223_PHY_ID)\n+\tif (reg_phy_ext == IXGBE_CS4223_SKU_ID)\n \t\tslice_offset = (hw->bus.lan_id +\n \t\t\t\t(hw->bus.instance_id << 1)) << 12;\n \telse\n", "prefixes": [ "1/5" ] }