Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/763758/?format=api
{ "id": 763758, "url": "http://patchwork.ozlabs.org/api/patches/763758/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170517202413.18321-1-bpoirier@suse.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170517202413.18321-1-bpoirier@suse.com>", "list_archive_url": null, "date": "2017-05-17T20:24:13", "name": "[v2] e1000e: Don't return uninitialized stats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "03adea306da618ee61d99e75713e21aedfb0529e", "submitter": { "id": 67008, "url": "http://patchwork.ozlabs.org/api/people/67008/?format=api", "name": "Benjamin Poirier", "email": "bpoirier@suse.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170517202413.18321-1-bpoirier@suse.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/763758/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/763758/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wSm5839GNz9s3s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 18 May 2017 06:24:44 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C19A7886F3;\n\tWed, 17 May 2017 20:24:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RkoDjkR8Pqb3; Wed, 17 May 2017 20:24:40 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E43D4886ED;\n\tWed, 17 May 2017 20:24:40 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2A7C71C203E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 20:24:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1B6F984620\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 20:24:39 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id by_FAOZ6i5s9 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 20:24:38 +0000 (UTC)", "from mail-oi0-f68.google.com (mail-oi0-f68.google.com\n\t[209.85.218.68])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id E6D7981B69\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 20:24:37 +0000 (UTC)", "by mail-oi0-f68.google.com with SMTP id h4so4026989oib.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 May 2017 13:24:37 -0700 (PDT)", "from f1.synalogic.ca ([172.56.7.228])\n\tby smtp.gmail.com with ESMTPSA id\n\ts1sm1579707otd.48.2017.05.17.13.24.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 17 May 2017 13:24:34 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bhJGFSsd\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Niuf9F47KZhSbCaDO5sXZLajqvw3QkIDiWrSrpQRQgM=;\n\tb=bhJGFSsd0ReDegxZw+sr6u+mOSFmmkiqHgMr7O+o6VaDuptcwZK5w16lw3rpBvhBG/\n\ti9hnksVYY4YcEPwCDNFj+SdMc/Nj8Kf06bIpRUaT6tofACuCHz2crvWJsXqPgLkIAAOS\n\tyKcKKRTJebs4acbv5e+XjE8p2npCSfwyN2Cd8rb/oyq8zsNacwQ2QktYs6Dm9AYAs9b3\n\tb1VY4CpwgFvdh6saVdnZFi3C25HV+KvcbhqHb+9fnfBfh+Y1Fqm7fI1PIxA6J255WDwn\n\tHbzmsclA01Cpi3r/C7s/QzGE2I2ZsI02iaVZXlUHCtKQKTbt9Y5aXWBnM9/rauGl6Ee+\n\t8SUw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=Niuf9F47KZhSbCaDO5sXZLajqvw3QkIDiWrSrpQRQgM=;\n\tb=Hh63nIjwfPTuMtfi4oc/6HIk6YmmJmtdOgyKqVwj9lW7G+Zr+0MTFyfQTeiXof+aV3\n\taVODALfb4vbAy/+YCpYSUrZH1VRiJOeJX93oQlmcMDGQWuuuq0IwPeHzzPdPDrH8SOrn\n\tw8x2+VDjOtXZSCzBTy8svjET3Aq+NhBSCvRKNmowFCvWwQg3EHlBKoT9Lz+JWwvYjGOu\n\tfgWtcAL7khDvuZELaVgunY1E7Unqx1eqPxik43yfZlA4S/OXFIAubD53n1irocW3xvV5\n\tTKr7DaasiSQkENVycK87VVx1Mqd8WQBo9YUE2dgJXrRx4aU7z6yYeHIwv0mHqJIqsF/d\n\trjqQ==", "X-Gm-Message-State": "AODbwcA2x3X7A1obaXKJsb76eReecuPwDlv1ipsPN6ke8IjV2iJ4vcFj\n\tvFBnyFPOntw+bg==", "X-Received": "by 10.157.63.10 with SMTP id m10mr360431otc.125.1495052675810;\n\tWed, 17 May 2017 13:24:35 -0700 (PDT)", "From": "Benjamin Poirier <bpoirier@suse.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Wed, 17 May 2017 16:24:13 -0400", "Message-Id": "<20170517202413.18321-1-bpoirier@suse.com>", "X-Mailer": "git-send-email 2.12.2", "In-Reply-To": "<20170425175433.ykc6ilm6uo7e6my2@f1.synalogic.ca>", "References": "<20170425175433.ykc6ilm6uo7e6my2@f1.synalogic.ca>", "Cc": "Paul Menzel <pmenzel@molgen.mpg.de>,\n\tStefan Priebe <s.priebe@profihost.ag>, \n\tnetdev@vger.kernel.org, Stephen Hemminger <stephen@networkplumber.org>,\n\tintel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH v2] e1000e: Don't return uninitialized\n\tstats", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Some statistics passed to ethtool are garbage because e1000e_get_stats64()\ndoesn't write them, for example: tx_heartbeat_errors. This leaks kernel\nmemory to userspace and confuses users.\n\nDo like ixgbe and use dev_get_stats() which first zeroes out\nrtnl_link_stats64.\n\nFixes: 5944701df90d (\"net: remove useless memset's in drivers get_stats64\")\nReported-by: Stefan Priebe <s.priebe@profihost.ag>\nSigned-off-by: Benjamin Poirier <bpoirier@suse.com>\n---\n\nNotes:\n Changes v1->v2:\n * add the Fixes tag\n\n drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c\nindex e23dbd9190d6..5b4d97570896 100644\n--- a/drivers/net/ethernet/intel/e1000e/ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000e/ethtool.c\n@@ -2072,7 +2072,7 @@ static void e1000_get_ethtool_stats(struct net_device *netdev,\n \n \tpm_runtime_get_sync(netdev->dev.parent);\n \n-\te1000e_get_stats64(netdev, &net_stats);\n+\tdev_get_stats(netdev, &net_stats);\n \n \tpm_runtime_put_sync(netdev->dev.parent);\n \n", "prefixes": [ "v2" ] }