Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/763221/?format=api
{ "id": 763221, "url": "http://patchwork.ozlabs.org/api/patches/763221/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170516225516.65557-1-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170516225516.65557-1-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2017-05-16T22:55:16", "name": "[next-queue,v2] igb: Remove useless argument", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "24f507b99749e513d627fca51a128d248d731bfa", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170516225516.65557-1-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/763221/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/763221/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wSCTT5ZwYz9s7k\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 May 2017 08:55:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 15A16885DD;\n\tTue, 16 May 2017 22:55:23 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jCpmwFzXJSwb; Tue, 16 May 2017 22:55:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CD096885C9;\n\tTue, 16 May 2017 22:55:21 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id E69491C0B0E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 May 2017 22:55:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DF0BC863DB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 May 2017 22:55:20 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ad-ry9NLsdoo for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 May 2017 22:55:20 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 3827085A4B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 May 2017 22:55:20 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga104.jf.intel.com with ESMTP; 16 May 2017 15:55:19 -0700", "from siradov-mobl6.amr.corp.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([10.254.25.137])\n\tby orsmga001.jf.intel.com with ESMTP; 16 May 2017 15:55:19 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.38,351,1491289200\"; d=\"scan'208\";\n\ta=\"1131168730\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 16 May 2017 15:55:16 -0700", "Message-Id": "<20170516225516.65557-1-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.12.2", "Cc": "Benjamin Poirier <bpoirier@suse.com>", "Subject": "[Intel-wired-lan] [next-queue v2] igb: Remove useless argument", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Benjamin Poirier <bpoirier@suse.com>\n\nGiven that all callers of igb_update_stats() pass the same two arguments:\n(adapter, &adapter->stats64), the second argument can be removed.\n\nSigned-off-by: Benjamin Poirier <bpoirier@suse.com>\n---\n drivers/net/ethernet/intel/igb/igb.h | 2 +-\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-\n drivers/net/ethernet/intel/igb/igb_main.c | 10 +++++-----\n 3 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h\nindex ff4d9073781a..06ffb2bc713e 100644\n--- a/drivers/net/ethernet/intel/igb/igb.h\n+++ b/drivers/net/ethernet/intel/igb/igb.h\n@@ -667,7 +667,7 @@ void igb_setup_tctl(struct igb_adapter *);\n void igb_setup_rctl(struct igb_adapter *);\n netdev_tx_t igb_xmit_frame_ring(struct sk_buff *, struct igb_ring *);\n void igb_alloc_rx_buffers(struct igb_ring *, u16);\n-void igb_update_stats(struct igb_adapter *, struct rtnl_link_stats64 *);\n+void igb_update_stats(struct igb_adapter *);\n bool igb_has_link(struct igb_adapter *adapter);\n void igb_set_ethtool_ops(struct net_device *);\n void igb_power_up_link(struct igb_adapter *);\ndiff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex 8730f7cbce68..d06a8db514d4 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -2316,7 +2316,7 @@ static void igb_get_ethtool_stats(struct net_device *netdev,\n \tchar *p;\n \n \tspin_lock(&adapter->stats64_lock);\n-\tigb_update_stats(adapter, net_stats);\n+\tigb_update_stats(adapter);\n \n \tfor (i = 0; i < IGB_GLOBAL_STATS_LEN; i++) {\n \t\tp = (char *)adapter + igb_gstrings_stats[i].stat_offset;\ndiff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 8f624af3fa47..64fd23045e0c 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -1818,7 +1818,7 @@ void igb_down(struct igb_adapter *adapter)\n \n \t/* record the stats before reset*/\n \tspin_lock(&adapter->stats64_lock);\n-\tigb_update_stats(adapter, &adapter->stats64);\n+\tigb_update_stats(adapter);\n \tspin_unlock(&adapter->stats64_lock);\n \n \tadapter->link_speed = 0;\n@@ -4686,7 +4686,7 @@ static void igb_watchdog_task(struct work_struct *work)\n \t}\n \n \tspin_lock(&adapter->stats64_lock);\n-\tigb_update_stats(adapter, &adapter->stats64);\n+\tigb_update_stats(adapter);\n \tspin_unlock(&adapter->stats64_lock);\n \n \tfor (i = 0; i < adapter->num_tx_queues; i++) {\n@@ -5499,7 +5499,7 @@ static void igb_get_stats64(struct net_device *netdev,\n \tstruct igb_adapter *adapter = netdev_priv(netdev);\n \n \tspin_lock(&adapter->stats64_lock);\n-\tigb_update_stats(adapter, &adapter->stats64);\n+\tigb_update_stats(adapter);\n \tmemcpy(stats, &adapter->stats64, sizeof(*stats));\n \tspin_unlock(&adapter->stats64_lock);\n }\n@@ -5548,9 +5548,9 @@ static int igb_change_mtu(struct net_device *netdev, int new_mtu)\n * igb_update_stats - Update the board statistics counters\n * @adapter: board private structure\n **/\n-void igb_update_stats(struct igb_adapter *adapter,\n-\t\t struct rtnl_link_stats64 *net_stats)\n+void igb_update_stats(struct igb_adapter *adapter)\n {\n+\tstruct rtnl_link_stats64 *net_stats = &adapter->stats64;\n \tstruct e1000_hw *hw = &adapter->hw;\n \tstruct pci_dev *pdev = adapter->pdev;\n \tu32 reg, mpc;\n", "prefixes": [ "next-queue", "v2" ] }