Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/762220/?format=api
{ "id": 762220, "url": "http://patchwork.ozlabs.org/api/patches/762220/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170515045200.27789-1-bjorn.topel@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170515045200.27789-1-bjorn.topel@gmail.com>", "list_archive_url": null, "date": "2017-05-15T04:52:00", "name": "[net,v2] i40e/i40evf: proper update of the page_offset field", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "14636b9a7d5fefc537fc95010a2bff05b47965c2", "submitter": { "id": 70569, "url": "http://patchwork.ozlabs.org/api/people/70569/?format=api", "name": "Björn Töpel", "email": "bjorn.topel@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170515045200.27789-1-bjorn.topel@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/762220/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/762220/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wR7VT640mz9s8D\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 15 May 2017 14:52:33 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2F1A98607F;\n\tMon, 15 May 2017 04:52:32 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Tlj+VXqaTUrT; Mon, 15 May 2017 04:52:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 724638606C;\n\tMon, 15 May 2017 04:52:31 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 227AE1C2250\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 May 2017 04:52:30 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1CA1986C9C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 May 2017 04:52:30 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YOPr8zMAzZoC for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 May 2017 04:52:28 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 1D7CC86C0E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 May 2017 04:52:28 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 May 2017 21:52:27 -0700", "from poram-mobl1.ger.corp.intel.com (HELO localhost.localdomain)\n\t([10.252.9.23])\n\tby orsmga002.jf.intel.com with ESMTP; 14 May 2017 21:52:24 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.38,343,1491289200\"; d=\"scan'208\";a=\"86765335\"", "From": "=?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= <bjorn.topel@gmail.com>", "To": "netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Mon, 15 May 2017 06:52:00 +0200", "Message-Id": "<20170515045200.27789-1-bjorn.topel@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "MIME-Version": "1.0", "Cc": "=?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= <bjorn.topel@intel.com>", "Subject": "[Intel-wired-lan] [PATCH net v2] i40e/i40evf: proper update of the\n\tpage_offset field", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Björn Töpel <bjorn.topel@intel.com>\n\nIn f8b45b74cc62 (\"i40e/i40evf: Use build_skb to build frames\")\ni40e_build_skb updates the page_offset field with an incorrect offset,\nwhich can lead to data corruption. This patch updates page_offset\ncorrectly, by properly setting truesize.\n\nNote that the bug only appears on architectures where PAGE_SIZE is\n8192 or larger.\n\nFixes: f8b45b74cc62 (\"i40e/i40evf: Use build_skb to build frames\")\nSigned-off-by: Björn Töpel <bjorn.topel@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 ++-\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 3 ++-\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 29321a6167a6..cd894f4023b1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -1854,7 +1854,8 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,\n #if (PAGE_SIZE < 8192)\n \tunsigned int truesize = i40e_rx_pg_size(rx_ring) / 2;\n #else\n-\tunsigned int truesize = SKB_DATA_ALIGN(size);\n+\tunsigned int truesize = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) +\n+\t\t\t\tSKB_DATA_ALIGN(I40E_SKB_PAD + size);\n #endif\n \tstruct sk_buff *skb;\n \ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex dfe241a12ad0..12b02e530503 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -1190,7 +1190,8 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,\n #if (PAGE_SIZE < 8192)\n \tunsigned int truesize = i40e_rx_pg_size(rx_ring) / 2;\n #else\n-\tunsigned int truesize = SKB_DATA_ALIGN(size);\n+\tunsigned int truesize = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) +\n+\t\t\t\tSKB_DATA_ALIGN(I40E_SKB_PAD + size);\n #endif\n \tstruct sk_buff *skb;\n \n", "prefixes": [ "net", "v2" ] }