Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/761840/?format=api
{ "id": 761840, "url": "http://patchwork.ozlabs.org/api/patches/761840/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170512183810.26185-2-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170512183810.26185-2-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2017-05-12T18:38:08", "name": "[2/4] ixgbe: Resolve warnings for -Wimplicit-fallthrough", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b3a9cd534a0794d6ebcc2209416f91e60f2084c4", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170512183810.26185-2-anthony.l.nguyen@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/761840/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/761840/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wPgTr2QnDz9s7B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 13 May 2017 05:46:56 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E0D03976B0;\n\tFri, 12 May 2017 19:46:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5eeiHPGIWwcR; Fri, 12 May 2017 19:46:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 32C76976B6;\n\tFri, 12 May 2017 19:46:54 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id C244A1C0ACA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 May 2017 19:46:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AF9E392C2F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 May 2017 19:46:52 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SaRFz8i4qovB for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 May 2017 19:46:52 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 055B3926D1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 May 2017 19:46:51 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 May 2017 12:46:51 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.152.64])\n\tby fmsmga005.fm.intel.com with ESMTP; 12 May 2017 12:46:51 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.38,330,1491289200\"; d=\"scan'208\";a=\"100834267\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 12 May 2017 11:38:08 -0700", "Message-Id": "<20170512183810.26185-2-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170512183810.26185-1-anthony.l.nguyen@intel.com>", "References": "<20170512183810.26185-1-anthony.l.nguyen@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 2/4] ixgbe: Resolve warnings for\n\t-Wimplicit-fallthrough", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch adds/changes fall through comments to address new warnings\nproduced by gcc 7.\n\nFixed formatting on a couple of comments in the function.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 9 ++++++---\n drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 4 ++--\n drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 1 +\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++++--\n drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 7 +++----\n 5 files changed, 18 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\nindex c8ac460..d602637 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\n@@ -1589,15 +1589,17 @@ s32 ixgbe_fdir_set_input_mask_82599(struct ixgbe_hw *hw,\n \n \tswitch (ntohs(input_mask->formatted.vlan_id) & 0xEFFF) {\n \tcase 0x0000:\n-\t\t/* mask VLAN ID, fall through to mask VLAN priority */\n+\t\t/* mask VLAN ID */\n \t\tfdirm |= IXGBE_FDIRM_VLANID;\n+\t\t/* fall through */\n \tcase 0x0FFF:\n \t\t/* mask VLAN priority */\n \t\tfdirm |= IXGBE_FDIRM_VLANP;\n \t\tbreak;\n \tcase 0xE000:\n-\t\t/* mask VLAN ID only, fall through */\n+\t\t/* mask VLAN ID only */\n \t\tfdirm |= IXGBE_FDIRM_VLANID;\n+\t\t/* fall through */\n \tcase 0xEFFF:\n \t\t/* no VLAN fields masked */\n \t\tbreak;\n@@ -1608,8 +1610,9 @@ s32 ixgbe_fdir_set_input_mask_82599(struct ixgbe_hw *hw,\n \n \tswitch (input_mask->formatted.flex_bytes & 0xFFFF) {\n \tcase 0x0000:\n-\t\t/* Mask Flex Bytes, fall through */\n+\t\t/* Mask Flex Bytes */\n \t\tfdirm |= IXGBE_FDIRM_FLEX;\n+\t\t/* fall through */\n \tcase 0xFFFF:\n \t\tbreak;\n \tdefault:\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex 3af6127..76ad0e0 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -155,7 +155,7 @@ s32 ixgbe_setup_fc_generic(struct ixgbe_hw *hw)\n \t\tif (ret_val)\n \t\t\treturn ret_val;\n \n-\t\t/* only backplane uses autoc so fall though */\n+\t\t/* fall through - only backplane uses autoc */\n \tcase ixgbe_media_type_fiber:\n \t\treg = IXGBE_READ_REG(hw, IXGBE_PCS1GANA);\n \n@@ -3549,7 +3549,7 @@ void ixgbe_set_rxpba_generic(struct ixgbe_hw *hw,\n \t\trxpktsize <<= IXGBE_RXPBSIZE_SHIFT;\n \t\tfor (; i < (num_pb / 2); i++)\n \t\t\tIXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), rxpktsize);\n-\t\t/* Fall through to configure remaining packet buffers */\n+\t\t/* fall through - configure remaining packet buffers */\n \tcase (PBA_STRATEGY_EQUAL):\n \t\t/* Divide the remaining Rx packet buffer evenly among the TCs */\n \t\trxpktsize = (pbsize / (num_pb - i)) << IXGBE_RXPBSIZE_SHIFT;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex 0b75d304..2890e92 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -2671,6 +2671,7 @@ static int ixgbe_flowspec_to_flow_type(struct ethtool_rx_flow_spec *fsp,\n \t\t\t\t*flow_type = IXGBE_ATR_FLOW_TYPE_IPV4;\n \t\t\t\tbreak;\n \t\t\t}\n+\t\t\t/* fall through */\n \t\tdefault:\n \t\t\treturn 0;\n \t\t}\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 04ccb64..2813899 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -1452,7 +1452,7 @@ static int __ixgbe_notify_dca(struct device *dev, void *data)\n \t\t\t\t\tIXGBE_DCA_CTRL_DCA_MODE_CB2);\n \t\t\tbreak;\n \t\t}\n-\t\t/* Fall Through since DCA is disabled. */\n+\t\t/* fall through - DCA is disabled. */\n \tcase DCA_PROVIDER_REMOVE:\n \t\tif (adapter->flags & IXGBE_FLAG_DCA_ENABLED) {\n \t\t\tdca_remove_requester(dev);\n@@ -2233,6 +2233,7 @@ static struct sk_buff *ixgbe_run_xdp(struct ixgbe_adapter *adapter,\n \t\tbreak;\n \tdefault:\n \t\tbpf_warn_invalid_xdp_action(act);\n+\t\t/* fallthrough */\n \tcase XDP_ABORTED:\n \t\ttrace_xdp_exception(rx_ring->netdev, xdp_prog, act);\n \t\t/* fallthrough -- handle aborts by dropping packet */\n@@ -4177,7 +4178,7 @@ static void ixgbe_setup_rdrxctl(struct ixgbe_adapter *adapter)\n \tcase ixgbe_mac_x550em_a:\n \t\tif (adapter->num_vfs)\n \t\t\trdrxctl |= IXGBE_RDRXCTL_PSP;\n-\t\t/* fall through for older HW */\n+\t\t/* fall through */\n \tcase ixgbe_mac_82599EB:\n \tcase ixgbe_mac_X540:\n \t\t/* Disable RSC for ACK packets */\n@@ -6885,6 +6886,7 @@ void ixgbe_update_stats(struct ixgbe_adapter *adapter)\n \t\thwstats->o2bspc += IXGBE_READ_REG(hw, IXGBE_O2BSPC);\n \t\thwstats->b2ospc += IXGBE_READ_REG(hw, IXGBE_B2OSPC);\n \t\thwstats->b2ogprc += IXGBE_READ_REG(hw, IXGBE_B2OGPRC);\n+\t\t/* fall through */\n \tcase ixgbe_mac_82599EB:\n \t\tfor (i = 0; i < 16; i++)\n \t\t\tadapter->hw_rx_no_dma_resources +=\n@@ -8222,6 +8224,7 @@ static u16 ixgbe_select_queue(struct net_device *dev, struct sk_buff *skb,\n \n \t\tif (adapter->flags & IXGBE_FLAG_FCOE_ENABLED)\n \t\t\tbreak;\n+\t\t/* fall through */\n \tdefault:\n \t\treturn fallback(dev, skb);\n \t}\n@@ -9957,6 +9960,7 @@ bool ixgbe_wol_supported(struct ixgbe_adapter *adapter, u16 device_id,\n \t\t\t/* only support first port */\n \t\t\tif (hw->bus.func != 0)\n \t\t\t\tbreak;\n+\t\t\t/* fall through */\n \t\tcase IXGBE_SUBDEV_ID_82599_SP_560FLR:\n \t\tcase IXGBE_SUBDEV_ID_82599_SFP:\n \t\tcase IXGBE_SUBDEV_ID_82599_RNDC:\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\nindex 13c96a1..e2766da 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n@@ -540,16 +540,15 @@ static s32 ixgbe_set_vf_lpe(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf)\n \t\tcase ixgbe_mbox_api_11:\n \t\tcase ixgbe_mbox_api_12:\n \t\tcase ixgbe_mbox_api_13:\n-\t\t\t/*\n-\t\t\t * Version 1.1 supports jumbo frames on VFs if PF has\n+\t\t\t/* Version 1.1 supports jumbo frames on VFs if PF has\n \t\t\t * jumbo frames enabled which means legacy VFs are\n \t\t\t * disabled\n \t\t\t */\n \t\t\tif (pf_max_frame > ETH_FRAME_LEN)\n \t\t\t\tbreak;\n+\t\t\t/* fall through */\n \t\tdefault:\n-\t\t\t/*\n-\t\t\t * If the PF or VF are running w/ jumbo frames enabled\n+\t\t\t/* If the PF or VF are running w/ jumbo frames enabled\n \t\t\t * we need to shut down the VF Rx path as we cannot\n \t\t\t * support jumbo frames on legacy VFs\n \t\t\t */\n", "prefixes": [ "2/4" ] }