Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/758161/?format=api
{ "id": 758161, "url": "http://patchwork.ozlabs.org/api/patches/758161/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170503172904.9788-12-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170503172904.9788-12-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2017-05-03T17:29:00", "name": "[v4,11/15] ixgbe: add statistic indicating number of skipped Tx timestamps", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2c405bb0ec31774945c51101b511d42f6485c40a", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170503172904.9788-12-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/758161/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/758161/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wJ4sJ0s6Bz9rxw\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 4 May 2017 03:29:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ACCE789B04;\n\tWed, 3 May 2017 17:29:22 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6Fk+UmkgrLyp; Wed, 3 May 2017 17:29:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 20EE289B6B;\n\tWed, 3 May 2017 17:29:19 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2A0471C0F65\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 May 2017 17:29:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 267272FC9E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 May 2017 17:29:15 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LkbctDrBEkIL for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 May 2017 17:29:14 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby silver.osuosl.org (Postfix) with ESMTPS id BBB933018D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 May 2017 17:29:13 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 May 2017 10:29:12 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([10.166.35.158])\n\tby orsmga002.jf.intel.com with ESMTP; 03 May 2017 10:29:12 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.38,284,1491289200\"; d=\"scan'208\";a=\"82071031\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Wed, 3 May 2017 10:29:00 -0700", "Message-Id": "<20170503172904.9788-12-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.13.0.rc0.317.gcc792a6cad5a", "In-Reply-To": "<20170503172904.9788-1-jacob.e.keller@intel.com>", "References": "<20170503172904.9788-1-jacob.e.keller@intel.com>", "Cc": "Richard Cochran <richardcochran@gmail.com>", "Subject": "[Intel-wired-lan] [PATCH v4 11/15] ixgbe: add statistic indicating\n\tnumber of skipped Tx timestamps", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The ixgbe driver can only handle one Tx timestamp request at a time.\nThis means it is possible for an application timestamp request to be\nignored.\n\nThere is no easy way for an administrator to determine if this occurred.\nAdd a new statistic which tracks this, tx_hwtstamp_skipped.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 +\n drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 3 +++\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 21 ++++++++++++---------\n 3 files changed, 16 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\nindex 76263762bea1..eb36106218ad 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n@@ -733,6 +733,7 @@ struct ixgbe_adapter {\n \tstruct timecounter hw_tc;\n \tu32 base_incval;\n \tu32 tx_hwtstamp_timeouts;\n+\tu32 tx_hwtstamp_skipped;\n \tu32 rx_hwtstamp_cleared;\n \tvoid (*ptp_setup_sdp)(struct ixgbe_adapter *);\n \ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex cced74dd5a63..0b75d304b009 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -111,6 +111,9 @@ static const struct ixgbe_stats ixgbe_gstrings_stats[] = {\n \t{\"os2bmc_tx_by_bmc\", IXGBE_STAT(stats.b2ospc)},\n \t{\"os2bmc_tx_by_host\", IXGBE_STAT(stats.o2bspc)},\n \t{\"os2bmc_rx_by_host\", IXGBE_STAT(stats.b2ogprc)},\n+\t{\"tx_hwtstamp_timeouts\", IXGBE_STAT(tx_hwtstamp_timeouts)},\n+\t{\"tx_hwtstamp_skipped\", IXGBE_STAT(tx_hwtstamp_skipped)},\n+\t{\"rx_hwtstamp_cleared\", IXGBE_STAT(rx_hwtstamp_cleared)},\n #ifdef IXGBE_FCOE\n \t{\"fcoe_bad_fccrc\", IXGBE_STAT(stats.fccrc)},\n \t{\"rx_fcoe_dropped\", IXGBE_STAT(stats.fcoerpdc)},\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex f93330bc7b97..85a10458ab59 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8346,16 +8346,19 @@ netdev_tx_t ixgbe_xmit_frame_ring(struct sk_buff *skb,\n \tprotocol = vlan_get_protocol(skb);\n \n \tif (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP) &&\n-\t adapter->ptp_clock &&\n-\t !test_and_set_bit_lock(__IXGBE_PTP_TX_IN_PROGRESS,\n-\t\t\t\t &adapter->state)) {\n-\t\tskb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;\n-\t\ttx_flags |= IXGBE_TX_FLAGS_TSTAMP;\n+\t adapter->ptp_clock) {\n+\t\tif (!test_and_set_bit_lock(__IXGBE_PTP_TX_IN_PROGRESS,\n+\t\t\t\t\t &adapter->state)) {\n+\t\t\tskb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;\n+\t\t\ttx_flags |= IXGBE_TX_FLAGS_TSTAMP;\n \n-\t\t/* schedule check for Tx timestamp */\n-\t\tadapter->ptp_tx_skb = skb_get(skb);\n-\t\tadapter->ptp_tx_start = jiffies;\n-\t\tschedule_work(&adapter->ptp_tx_work);\n+\t\t\t/* schedule check for Tx timestamp */\n+\t\t\tadapter->ptp_tx_skb = skb_get(skb);\n+\t\t\tadapter->ptp_tx_start = jiffies;\n+\t\t\tschedule_work(&adapter->ptp_tx_work);\n+\t\t} else {\n+\t\t\tadapter->tx_hwtstamp_skipped++;\n+\t\t}\n \t}\n \n \tskb_tx_timestamp(skb);\n", "prefixes": [ "v4", "11/15" ] }