Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/757384/?format=api
{ "id": 757384, "url": "http://patchwork.ozlabs.org/api/patches/757384/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170502050634.7459.50968.stgit@john-Precision-Tower-5810/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170502050634.7459.50968.stgit@john-Precision-Tower-5810>", "list_archive_url": null, "date": "2017-05-02T05:06:34", "name": "ixgbe: prevent driver configuration changes while XDP is loaded", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "91dba570d6595a8e360a300f52fcc1fbb0eb3045", "submitter": { "id": 20028, "url": "http://patchwork.ozlabs.org/api/people/20028/?format=api", "name": "John Fastabend", "email": "john.fastabend@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170502050634.7459.50968.stgit@john-Precision-Tower-5810/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/757384/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/757384/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wH8R13Kwpz9s7n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 2 May 2017 15:06:53 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8FEDF88D57;\n\tTue, 2 May 2017 05:06:51 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2Tm7zfJKFNxK; Tue, 2 May 2017 05:06:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1420E88C5B;\n\tTue, 2 May 2017 05:06:50 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 152B81BFBAD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 May 2017 05:06:48 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 10A30883F6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 May 2017 05:06:48 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Nqgju6m+S2hW for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 May 2017 05:06:47 +0000 (UTC)", "from mail-pf0-f193.google.com (mail-pf0-f193.google.com\n\t[209.85.192.193])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 3611387F86\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 May 2017 05:06:47 +0000 (UTC)", "by mail-pf0-f193.google.com with SMTP id o68so11478362pfj.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 01 May 2017 22:06:47 -0700 (PDT)", "from [127.0.1.1] ([72.168.145.102])\n\tby smtp.gmail.com with ESMTPSA id\n\tu78sm7830582pfa.47.2017.05.01.22.06.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 01 May 2017 22:06:46 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"B/T7T8Rm\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:subject:to:cc:date:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=sF84mJhqlyeJn5vIbLg3wr1MLOONKCRogw61t2dk5Ho=;\n\tb=B/T7T8RmMSNvwQprILA2dsVwzGBnGE2FYG7Qtf+9/ML6ue9XBrM3ItUFkI7j5/CiQj\n\tfKUrKh+tlh7JFXOSx9iO54+DJeKDGOKlGUMTFCI/LZzUjs6LfFuEiZ6It0+LkHZLmgfv\n\tNd5mSMxlCNgBYT/0ZVCh7mZx/o7pXtnh2Ru5Dp5kac8HvBom28ZuFraIvkmsJMmLMnaO\n\tFu89yRwtDpYPHETuolubaSK/Jm052axZ2iq4x1M5U6XT0ll6rkWHkuE88A6LUHKbDnDZ\n\tq0531fxI0PO5bcUmBJTf0NOY1xwWm8clRxgvnlZs+19OcY3jKVy2cZLmukZYz8bS7SDG\n\tfxlQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:subject:to:cc:date:message-id:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=sF84mJhqlyeJn5vIbLg3wr1MLOONKCRogw61t2dk5Ho=;\n\tb=K9wGKmqoC0pW9adko744LIi26LoLaXiN4pz5UjKr88JDd30v8lqjNPTu5X2KuC06iM\n\tn2wubD80yL5RrAL3YJ/ii5w8TIj/tLqzfDKWxUMP00RLARzwFsvx0WHpUnJKSREU2VYi\n\t4RBR2z9XAYjas+NHt/IMHofQEzf6Zg4sLsKJB6X2Mze+0HHbxgR5VLajluP+JeDO0bRO\n\tYX3sndVv2MszmKqq7wSP2+seto0tK1qosxZKkHIs1MFOyMl+p2ReKq2+GoXEF2SbC6r8\n\tpbrxsP4vkHwZ9+YR8a9FfoCfIDSrO3qAwPyQw2fPd7jOxDxwyN3fnbQ4SnzYYBIRk0tD\n\tIFUw==", "X-Gm-Message-State": "AN3rC/7ygkwUVDQ1H1gPbGgJawVKAr6QAoZGYY4wvIuV4MQGBY1yl5yb\n\tKrz+Ap+nTTu5Pg==", "X-Received": "by 10.99.120.206 with SMTP id\n\tt197mr30794405pgc.184.1493701606874; \n\tMon, 01 May 2017 22:06:46 -0700 (PDT)", "From": "John Fastabend <john.fastabend@gmail.com>", "X-Google-Original-From": "John Fastabend <john.r.fastabend@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 01 May 2017 22:06:34 -0700", "Message-ID": "<20170502050634.7459.50968.stgit@john-Precision-Tower-5810>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: prevent driver configuration\n\tchanges while XDP is loaded", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "XDP checks to ensure the MTU is valid and LRO is disabled when it is\nloaded. But user configuration after XDP is loaded could change these\nand cause a misconfiguration.\n\nThis patch adds checks to ensure config changes are valid.\n\nSigned-off-by: John Fastabend <john.r.fastabend@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex ee20a2b..156357e 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -6437,6 +6437,19 @@ static void ixgbe_free_all_rx_resources(struct ixgbe_adapter *adapter)\n static int ixgbe_change_mtu(struct net_device *netdev, int new_mtu)\n {\n \tstruct ixgbe_adapter *adapter = netdev_priv(netdev);\n+\tint i, frame_size = new_mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN;\n+\n+\t/* If XDP is running enforce MTU limitations */\n+\tfor (i = 0; i < adapter->num_rx_queues; i++) {\n+\t\tstruct ixgbe_ring *ring = adapter->rx_ring[i];\n+\n+\t\tif (frame_size > ixgbe_rx_bufsz(ring)) {\n+\t\t\te_warn(probe,\n+\t\t\t \"Setting MTU > %i with XDP is not supported\\n\",\n+\t\t\t ixgbe_rx_bufsz(ring));\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t}\n \n \t/*\n \t * For 82599EB we cannot allow legacy VFs to enable their receive\n@@ -9291,6 +9304,10 @@ static netdev_features_t ixgbe_fix_features(struct net_device *netdev,\n \tif (!(adapter->flags2 & IXGBE_FLAG2_RSC_CAPABLE))\n \t\tfeatures &= ~NETIF_F_LRO;\n \n+\t/* If XDP is enabled we can not enable LRO */\n+\tif (adapter->xdp_prog)\n+\t\tfeatures &= ~NETIF_F_LRO;\n+\n \treturn features;\n }\n \n", "prefixes": [] }