Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/756106/?format=api
{ "id": 756106, "url": "http://patchwork.ozlabs.org/api/patches/756106/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170427191007.1990964-1-arnd@arndb.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170427191007.1990964-1-arnd@arndb.de>", "list_archive_url": null, "date": "2017-04-27T19:09:52", "name": "[net-next] igb: mark PM functions as __maybe_unused", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a4101b92de549b382fe6e42047af91706ebe1a82", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170427191007.1990964-1-arnd@arndb.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/756106/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/756106/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wDRN96fzyz9s7r\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 28 Apr 2017 05:10:00 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 60000894FF;\n\tThu, 27 Apr 2017 19:09:58 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mXDC26YDx-DY; Thu, 27 Apr 2017 19:09:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 952E5894FC;\n\tThu, 27 Apr 2017 19:09:56 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 741311C072D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Apr 2017 19:09:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6A5CB875B3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Apr 2017 19:09:55 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id S0RnDDIAZ9xJ for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Apr 2017 19:09:54 +0000 (UTC)", "from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 1AF6886FAE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Apr 2017 19:09:53 +0000 (UTC)", "from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de\n\t(mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id\n\t0M0bdu-1dxRp12LEc-00unr5; Thu, 27 Apr 2017 21:09:37 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Arnd Bergmann <arnd@arndb.de>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Thu, 27 Apr 2017 21:09:52 +0200", "Message-Id": "<20170427191007.1990964-1-arnd@arndb.de>", "X-Mailer": "git-send-email 2.9.0", "X-Provags-ID": "V03:K0:sfsb2oReddkDqk790eO0ccUvkH0neNOvwzbb0fCZ7qzytQzY76s\n\tcA2BbXBbKJV1v9R+4g5W/rEw3a/zXJxIr2u5CMWeOr2YdcKn86z7Qc1cxDlvncsQ/vv3rvU\n\tc/q8c862kv63Y5oTM1VHkL9Wn6jwn0QBh16rsLmYkfAeJT2DRKO6Ho5BixnRp/71GtlmgeB\n\tNqOZqcjaZKvPORyYfOpqQ==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:Y0UTbEkaTRs=:sTtio68aUtoawkE+02i4Rv\n\trh4DwwhEqnAd5kUN/8U26yKm+m2oZB31+dfk0Z9BIugQ2p4xIkwAQYCVBiq6UoZhMCGxTsx6M\n\tb+UgcpPeM49y9zRZhSfxnseUa0swa7x+iFv+NvtJdWLNhgwV9+V2J0SJV3kpPvFx70hgFlcHx\n\tVEaQx+mpwOD6sb8NmGzLjFINZEvj33Ms9TrtpRDXb8JhYzWXb1kPQFBxU+PFXNMrUzBTBr8/v\n\tPEIcswf9KfbcDd7PiTU0gGSNO/TblGnhVaaaNnPYbWDGPbjkk4Tcgew9fSS+PYpU7bvOwyHBG\n\trNUpXAlf60KN7Zh7wdHIaWYVvfqx2vfgY3q9jZZhpwCF1pLp0nnumcBn5zv5XdQZDutDKevpJ\n\taTbLd06ic+d5xZr+hqVrf7kkdviPPmd0/cCQCp2VUSebjUd6ohF7OTmboWYWAATORCtu2faO6\n\tv1CbWs33y0QWIc/8SPYvc6LN+D7/5rUTHlKMjIwYtR4VIVya1IecxYILtaFgXE/e4TZtk/aNe\n\te0PH+U33emGrU6MlKT3cUvTflwtoYvOg62/KGAKB3qHzekgyQ37ueGvNb3f/LHV8sCaFehLt5\n\tSXAy/+pU8x2oJbXSKCkDZ0/8wOkfjueu2VG0/NXKh4rpnOllvsH23Si0+fR/4rdkHEu0Vedxf\n\tot5HIEqlrCHm/yKf9GjvjFKCDLpzVJmdcGEE8UoL6pkKnAVqlsL3vWB3PGMXfsgQGKPo=", "Cc": "Arnd Bergmann <arnd@arndb.de>, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\t\"David S. Miller\" <davem@davemloft.net>", "Subject": "[Intel-wired-lan] [PATCH net-next] igb: mark PM functions as\n\t__maybe_unused", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The new wake function is only used by the suspend/resume handlers that\nare defined in inside of an #ifdef, which can cause this harmless\nwarning:\n\ndrivers/net/ethernet/intel/igb/igb_main.c:7988:13: warning: 'igb_deliver_wake_packet' defined but not used [-Wunused-function]\n\nRemoving the #ifdef, instead using a __maybe_unused annotation\nsimplifies the code and avoids the warning.\n\nFixes: b90fa8763560 (\"igb: Enable reading of wake up packet\")\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 18 +++++-------------\n 1 file changed, 5 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 1cf74aa4ebd9..2d5bdb1fd37d 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -191,10 +191,7 @@ static int igb_disable_sriov(struct pci_dev *dev);\n static int igb_pci_disable_sriov(struct pci_dev *dev);\n #endif\n \n-#ifdef CONFIG_PM\n-#ifdef CONFIG_PM_SLEEP\n static int igb_suspend(struct device *);\n-#endif\n static int igb_resume(struct device *);\n static int igb_runtime_suspend(struct device *dev);\n static int igb_runtime_resume(struct device *dev);\n@@ -204,7 +201,6 @@ static const struct dev_pm_ops igb_pm_ops = {\n \tSET_RUNTIME_PM_OPS(igb_runtime_suspend, igb_runtime_resume,\n \t\t\tigb_runtime_idle)\n };\n-#endif\n static void igb_shutdown(struct pci_dev *);\n static int igb_pci_sriov_configure(struct pci_dev *dev, int num_vfs);\n #ifdef CONFIG_IGB_DCA\n@@ -8015,9 +8011,7 @@ static void igb_deliver_wake_packet(struct net_device *netdev)\n \tnetif_rx(skb);\n }\n \n-#ifdef CONFIG_PM\n-#ifdef CONFIG_PM_SLEEP\n-static int igb_suspend(struct device *dev)\n+static int __maybe_unused igb_suspend(struct device *dev)\n {\n \tint retval;\n \tbool wake;\n@@ -8036,9 +8030,8 @@ static int igb_suspend(struct device *dev)\n \n \treturn 0;\n }\n-#endif /* CONFIG_PM_SLEEP */\n \n-static int igb_resume(struct device *dev)\n+static int __maybe_unused igb_resume(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n \tstruct net_device *netdev = pci_get_drvdata(pdev);\n@@ -8092,7 +8085,7 @@ static int igb_resume(struct device *dev)\n \treturn err;\n }\n \n-static int igb_runtime_idle(struct device *dev)\n+static int __maybe_unused igb_runtime_idle(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n \tstruct net_device *netdev = pci_get_drvdata(pdev);\n@@ -8104,7 +8097,7 @@ static int igb_runtime_idle(struct device *dev)\n \treturn -EBUSY;\n }\n \n-static int igb_runtime_suspend(struct device *dev)\n+static int __maybe_unused igb_runtime_suspend(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n \tint retval;\n@@ -8124,11 +8117,10 @@ static int igb_runtime_suspend(struct device *dev)\n \treturn 0;\n }\n \n-static int igb_runtime_resume(struct device *dev)\n+static int __maybe_unused igb_runtime_resume(struct device *dev)\n {\n \treturn igb_resume(dev);\n }\n-#endif /* CONFIG_PM */\n \n static void igb_shutdown(struct pci_dev *pdev)\n {\n", "prefixes": [ "net-next" ] }